Code review comment for lp:~dholbach/harvest/packagesets
Revision history for this message
| Daniel Holbach (dholbach) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
On 26.01.2010 04:28, Paul Hummer wrote:
> A docstring here would be really helpful. Something like:
>
> """Return a logged in launchpad object."""
I'll have a look at that later on. Thanks. :)
> It would be better to raise an exception here, instead of printing to standard error and exiting. Sometimes the e part of the except is rather unhelpful.
Ok. I'll have a look and see what I can improve there.
> So, by this model definition, is it safe to say that packages can be in many different package sets? Have you tested this at all? I think we need a property on packagesets that can link back to the SourcePackages as well.
Have a look at http://
search for "mousepad", it ended up in various packagesets. It sure makes
our life more complicated, but it was deemed the best solution for the
reality we are facing.