Merge lp:~dholbach/harvest/664356 into lp:harvest

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 277
Proposed branch: lp:~dholbach/harvest/664356
Merge into: lp:harvest
Diff against target: 44 lines (+6/-3)
2 files modified
harvest/common/views.py (+3/-1)
harvest/opportunities/views.py (+3/-2)
To merge this branch: bzr merge lp:~dholbach/harvest/664356
Reviewer Review Type Date Requested Status
Dave Walker (community) Approve
harvest-dev Pending
Review via email: mp+39022@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'harvest/common/views.py'
2--- harvest/common/views.py 2010-10-06 12:54:43 +0000
3+++ harvest/common/views.py 2010-10-21 08:49:44 +0000
4@@ -3,6 +3,7 @@
5 from django.template import RequestContext
6 from django.contrib.auth import logout
7 from django.contrib.auth.models import User
8+from django.db.models import F
9
10 def index(request):
11 from opportunities.models import SourcePackage, OpportunityList, Opportunity, Note
12@@ -11,7 +12,8 @@
13 'users': User.objects.count(),
14 'sourcepackages': SourcePackage.objects.count(),
15 'opportunitylists': OpportunityList.objects.filter(active=True).count(),
16- 'opportunities': Opportunity.objects.filter(valid=True).count(),
17+ 'opportunities': Opportunity.objects.filter(valid=True,
18+ last_updated=F('opportunitylist__last_updated')).count(),
19 'notes': Note.objects.count(),
20 }
21 return render_to_response('index.html', context,
22
23=== modified file 'harvest/opportunities/views.py'
24--- harvest/opportunities/views.py 2010-10-05 13:31:20 +0000
25+++ harvest/opportunities/views.py 2010-10-21 08:49:44 +0000
26@@ -4,7 +4,7 @@
27 from django.shortcuts import get_object_or_404
28 from django.shortcuts import render_to_response as render
29 from django.http import HttpResponseRedirect
30-
31+from django.db.models import F
32 from django.template import RequestContext
33
34 import models
35@@ -22,7 +22,8 @@
36 sourcepackages_list = filters_pkg.process_queryset(sourcepackages_list)
37
38 #opportunities_list is filtered right away to only check opportunities belonging to selected packages
39- opportunities_list = models.Opportunity.objects.distinct().filter(sourcepackage__in=sourcepackages_list)
40+ opportunities_list = models.Opportunity.objects.distinct().filter(sourcepackage__in=sourcepackages_list,
41+ last_updated=F('opportunitylist__last_updated'))
42 opportunities_list = filters_opp.process_queryset(opportunities_list)
43
44 #TODO: need to filter out opportunities with valid=False again

Subscribers

People subscribed via source and target branches

to all changes: