Merge lp:~dholbach/harvest/581728 into lp:harvest

Proposed by Daniel Holbach
Status: Merged
Approved by: James Westby
Approved revision: 246
Merged at revision: 247
Proposed branch: lp:~dholbach/harvest/581728
Merge into: lp:harvest
Diff against target: 140 lines (+73/-13)
5 files modified
harvest/common/views.py (+3/-0)
harvest/media/css/style.css (+4/-0)
harvest/templates/doc.html (+36/-0)
harvest/templates/index.html (+29/-13)
harvest/urls.py (+1/-0)
To merge this branch: bzr merge lp:~dholbach/harvest/581728
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+33502@code.launchpad.net

This proposal supersedes a proposal from 2010-08-23.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote : Posted in a previous version of this proposal

Do you want to say something about how to get a new list in to
harvest-data? i.e. propose a bzr branch to be merged?

It's fine as is though.

Thanks,

James

review: Approve
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'harvest/common/views.py'
2--- harvest/common/views.py 2010-08-23 14:40:56 +0000
3+++ harvest/common/views.py 2010-08-24 09:48:45 +0000
4@@ -18,6 +18,9 @@
5 return render_to_response('index.html', context,
6 context_instance=RequestContext(request))
7
8+def doc(request):
9+ return render_to_response('doc.html', {}, context_instance=RequestContext(request))
10+
11 def site_logout(request):
12 logout(request)
13 return HttpResponseRedirect('/')
14
15=== modified file 'harvest/media/css/style.css'
16--- harvest/media/css/style.css 2010-08-16 18:57:42 +0000
17+++ harvest/media/css/style.css 2010-08-24 09:48:45 +0000
18@@ -145,6 +145,10 @@
19 max-width:60em;
20 }
21
22+#content > .question {
23+ font-style: italic;
24+ font-weight: bold;
25+}
26
27
28 #filters {
29
30=== added file 'harvest/templates/doc.html'
31--- harvest/templates/doc.html 1970-01-01 00:00:00 +0000
32+++ harvest/templates/doc.html 2010-08-24 09:48:45 +0000
33@@ -0,0 +1,36 @@
34+{% extends "base.html" %}
35+
36+{% load i18n %}
37+
38+{% block content %}
39+<div class="main">
40+<h1>HACKING Harvest</h1>
41+<p>The code of harvest lives in <a href="https://code.launchpad.net/harvest">Launchpad</a> and makes use of <a href="http://python.org/">python</a> and <a href="http://www.djangoproject.com/">Django</a>.</p>
42+<p>Harvest regularly pulls data from URLs stored in the <tt>opportunities</tt> file in <a href="https://code.launchpad.net/harvest-data">this branch</a>. The file layout is pretty simple.</p>
43+<p>Before attempting to download the CSV (comma-separated values) file, Harvest will check the <tt>Last-Modified</tt> entry in the HTTP header and see if any modifications were made. This is done to reduce traffic.</p>
44+<h2>Opportunities?</h2>
45+<p>The <tt>opportunities</tt> file is in CSV and of the following format:</p>
46+<pre>&lt;url&gt;,&lt;description&gt;</pre>
47+<p>The URLs to CSV files must be reachable via HTTP(s). The <tt>description</tt> is optional.</p>
48+<p>The CSV file in turn needs to be of the following form:</p>
49+<pre>&lt;sourcepackage&gt;,&lt;url&gt;,&lt;description&gt;</pre>
50+<p>For example:</p>
51+<pre>vdrift,http://launchpad.net/bugs/106854,106854</pre>
52+<p>Opportunities can be anything:</p>
53+<ul>
54+ <li>Easy bugs</li>
55+ <li>Suitable Upstream patches</li>
56+ <li>Patches of other distributions</li>
57+ <li>Problems in the CD builds that should be fixed</li>
58+ <li>etc.</li>
59+</ul>
60+<p>Let your imagination go wild. :-)</p>
61+<p>To get new opportunities included, please <a href="https://help.launchpad.net/Code/UploadingABranch">push a branch to Launchpad</a> and ask for it to be merged into <a href="https://launchpad.net/harvest-data/trunk">harvest-data</a> trunk.</p>
62+<h2>Setting it up</h2>
63+<p>Just
64+<ol>
65+ <li><tt>bzr branch lp:harvest</tt></li>
66+ <li><tt>less harvest/INSTALL</tt></li>
67+</ol>
68+</div>
69+{% endblock %}
70
71=== modified file 'harvest/templates/index.html'
72--- harvest/templates/index.html 2010-08-23 14:40:56 +0000
73+++ harvest/templates/index.html 2010-08-24 09:48:45 +0000
74@@ -4,25 +4,41 @@
75
76 {% block content %}
77
78-<div class="mainpage">
79-
80+<div class="main">
81 <h1>{% trans "Harvest" %}</h1>
82
83-There is no landing page at the moment :(
84-
85-<p>
86+<div id="aims">{% trans "Harvest's primary aims are:" %}
87+<ul>
88+ <li>{% trans "make it easy to find out about low-hanging fruit (opportunities)" %}</li>
89+ <li>{% trans "aggregate the mass of TODO lists we use day to day" %}</li>
90+ <li>{% trans "simplify work coordination" %}</li>
91+</ul>
92+</div>
93+<div>
94+<h2>Harvest FAQ</h2>
95+<ul id="faq">
96+ <li><span class="question">What can I do with Harvest?</span><br />
97+ Harvest helps to identify both bugs that may be easy to address, and other package changes that are not yet bugs, but could improve the package.
98+ Please take a look at the available opportunities when updating a package.</li>
99+ <li><span class="question">Why is Harvest the way it is?</span><br />
100+ Harvest is essentially based on one design-decision: let others do the hard work of assembling lists. Harvest knows just packages, lists and opportunities. It does not know what an open or fixed bug is or who upstream is.
101+ </li>
102+ <li><span class="question">What does "Mark reviewed" do?</span><br />
103+ It will remove an opportunity from the front pages and only display it in a separate section on the page of the source package.
104+ An obvious use-case for this is opportunities we have no control over, like Fedora patches.
105+ By marking an opportunity as reviewed you will unclutter the main pages (in case it does not apply for us or you integrated it already).</li>
106+ <li><span class="question">I think I found a bug - what do I do?</span><br />
107+ If it's about the UI or the functionality of the page, please file it on <a href="https://bugs.launchpad.net/harvest/+filebug">harvest</a>.
108+ If it's about some piece of data that's on the harvest page, it's likely to be a bug in one of the scripts that fetches the data, please file it on <a href="https://bugs.launchpad.net/harvest-data/+filebug">harvest-data</a> instead.
109+ The <a href="doc/">HACKING Guide</a> has more information about that.</li>
110+</ul>
111+</div>
112+<div id="stats">
113 {% blocktrans count users as counter %}1 user, {% plural %}{{ counter }} users, {% endblocktrans %}&nbsp;
114 {% blocktrans count sourcepackages as counter %}1 source package, {% plural %}{{ counter }} source packages, {% endblocktrans %}&nbsp;
115 {% blocktrans count opportunities as counter %}1 opportunity, {% plural %}{{ counter }} opportunities, {% endblocktrans %}&nbsp;
116 {% blocktrans count opportunitylists as counter %}1 opportunity list, {% plural %}{{ counter }} opportunity lists, {% endblocktrans %}&nbsp;
117 {% blocktrans count notes as counter %}1 note.{% plural %}{{ counter }} notes.{% endblocktrans %}
118-</p>
119-
120-{% if translator_credits %}
121-<p class="footnote">
122-{% trans "Translated by:" %} {{ translator_credits|join:", " }}
123-</p>
124-{% endif %}
125-
126+</div>
127 </div>
128 {% endblock %}
129
130=== modified file 'harvest/urls.py'
131--- harvest/urls.py 2010-08-23 14:15:29 +0000
132+++ harvest/urls.py 2010-08-24 09:48:45 +0000
133@@ -6,6 +6,7 @@
134
135 urlpatterns = patterns('',
136 url(r'^$', 'common.views.index', name='home'),
137+ url(r'^doc/$', 'common.views.doc', name='doc'),
138 url(r'^opportunities/', include('opportunities.urls')),
139 url(r'^services/', include('services.urls')),
140 url(r'^openid/', include('django_openid_auth.urls')),

Subscribers

People subscribed via source and target branches

to all changes: