Merge lp:~dholbach/harvest/581600 into lp:harvest

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 181
Proposed branch: lp:~dholbach/harvest/581600
Merge into: lp:harvest
Diff against target: 34 lines (+12/-0)
1 file modified
harvest/opportunities/management/commands/updatepackagesets.py (+12/-0)
To merge this branch: bzr merge lp:~dholbach/harvest/581600
Reviewer Review Type Date Requested Status
Dylan McCall Approve
Review via email: mp+26434@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Looks good to me :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'harvest/opportunities/management/commands/updatepackagesets.py'
2--- harvest/opportunities/management/commands/updatepackagesets.py 2010-01-22 13:28:04 +0000
3+++ harvest/opportunities/management/commands/updatepackagesets.py 2010-05-31 15:46:32 +0000
4@@ -16,10 +16,14 @@
5 sys.exit(1)
6 lp_packagesets = launchpad.get_packagesets(lp)
7 package_mapping = {}
8+ unseeded, created = PackageSet.objects.get_or_create(name="unseeded")
9+ if created:
10+ unseeded.save()
11 for lp_packageset in lp_packagesets:
12 packageset, created = PackageSet.objects.get_or_create(name=lp_packageset.name)
13 if created:
14 packageset.save()
15+ # record information which package is in which package sets
16 for package_name in lp_packageset.getSourcesIncluded():
17 if not package_mapping.has_key(package_name):
18 package_mapping[package_name] = set()
19@@ -35,7 +39,15 @@
20 package.packagesets.get(name=packageset_name)
21 except PackageSet.DoesNotExist:
22 package.packagesets.add(PackageSet.objects.get(name=packageset_name))
23+ # if package is in mapping, it can't be in the unseeded
24+ # list any more
25+ if package.packagesets.filter(name="unseeded"):
26+ package.packagesets.delete(unseeded)
27 for packageset in package.packagesets.all():
28 if packageset.name not in package_mapping[package_name]:
29 package.packagesets.delete(PackageSet.objects.get(name=packageset))
30 package.save()
31+ unseeded_packages = SourcePackage.objects.filter(packagesets__isnull=True)
32+ for u in unseeded_packages:
33+ u.packagesets.add(unseeded)
34+ u.save()

Subscribers

People subscribed via source and target branches

to all changes: