Merge lp:~dholbach/developer-ubuntu-com/rework-importer into lp:developer-ubuntu-com
| Status: | Superseded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Proposed branch: | lp:~dholbach/developer-ubuntu-com/rework-importer | ||||||||
| Merge into: | lp:developer-ubuntu-com | ||||||||
| Prerequisite: | lp:~developer-ubuntu-com-dev/developer-ubuntu-com/1470715 | ||||||||
| Diff against target: |
886 lines (+636/-75) (has conflicts) 12 files modified
TODO (+7/-0) developer_portal/admin.py (+22/-4) developer_portal/management/commands/import-external-docs-branches.py (+42/-56) developer_portal/management/importer/article.py (+126/-0) developer_portal/management/importer/local_branch.py (+132/-0) developer_portal/management/importer/publish.py (+60/-0) developer_portal/management/importer/source.py (+51/-0) developer_portal/migrations/0002_rework_importer.py (+59/-0) developer_portal/migrations/0003_track_imported_articles.py (+24/-0) developer_portal/models.py (+46/-15) developer_portal/settings.py (+20/-0) requirements.txt (+47/-0) Text conflict in developer_portal/admin.py Text conflict in developer_portal/management/commands/import-external-docs-branches.py Text conflict in developer_portal/settings.py Text conflict in requirements.txt |
||||||||
| To merge this branch: | bzr merge lp:~dholbach/developer-ubuntu-com/rework-importer | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu App Developer site developers | 2015-11-17 | Pending | |
|
Review via email:
|
|||
- 183. By Daniel Holbach on 2015-11-18
-
make admin interface for ExternalDocsBranch* usable
- 184. By Daniel Holbach on 2015-11-19
-
first cut of importer reorg
- break up into individual files
- simplify API a bit, make it more easily extendable and testable
- next steps: implement removal of old articles, fix links - 185. By Daniel Holbach on 2015-11-19
-
we haven't implemented globs yet
- 186. By Daniel Holbach on 2015-12-01
-
merged from trunk
- 187. By Daniel Holbach on 2015-12-02
-
add TODO
- 188. By Daniel Holbach on 2015-12-04
-
merge trunk
- 189. By Daniel Holbach on 2015-12-04
- 190. By Daniel Holbach on 2015-12-04
-
some more package updates
- 191. By Daniel Holbach on 2015-12-04
-
revert reversion upgrade
- 192. By Daniel Holbach on 2015-12-04
-
update migations locations
- 193. By Daniel Holbach on 2015-12-04
-
rename branch_origin to origin, add branch_name and add functionatlity so users can specify which branch of a git branch to import form
- 194. By Daniel Holbach on 2015-12-04
-
make ExternalDocsBra
nch.__str_ _ more revealing - 195. By Daniel Holbach on 2015-12-04
-
update SnappyLocalBranch c'tor to be inline with the added branch_name field
- 196. By Daniel Holbach on 2015-12-04
-
make sure we run 'checkout <branch>' in the right directory
- 197. By Daniel Holbach on 2015-12-07
-
update member name
- 198. By Daniel Holbach on 2015-12-07
-
fix imports, return published articles
- 199. By Daniel Holbach on 2015-12-08
-
update TODO
- 200. By Daniel Holbach on 2015-12-08
-
make pep8 happy, use .format()
- 201. By Daniel Holbach on 2015-12-08
-
allow us to track which pages were imported from which branch
- 202. By Daniel Holbach on 2015-12-08
-
make pep8 happy
- 203. By Daniel Holbach on 2015-12-08
-
first cut at tracking docs-branch/page in a separate table
- 204. By Daniel Holbach on 2015-12-09
-
fix check if directory-import would import already file-imported articles
- 205. By Daniel Holbach on 2015-12-09
-
safe datetime of last_import, fix removal condition of old articles
- 206. By Daniel Holbach on 2015-12-09
-
remove unused import
- 207. By Daniel Holbach on 2015-12-09
-
merge from lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3
- 208. By Daniel Holbach on 2015-12-09
-
add check if the last change was made by our script
- 209. By Daniel Holbach on 2015-12-14
-
merge lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3 again
- 210. By Daniel Holbach on 2015-12-14
-
make __str__ representations of ExternalDocsBra
nchImportDirect ive and ExternalDocsBranch more readable - 211. By Daniel Holbach on 2015-12-14
-
fix syntax error
- 212. By Daniel Holbach on 2015-12-14
-
every branch gets its own tempdir
- 213. By Daniel Holbach on 2015-12-14
-
help with paths starting with '/'
- 214. By Daniel Holbach on 2015-12-14
-
every branch gets its own tempdir
- 215. By Daniel Holbach on 2015-12-14
-
add fenced_code markdown extension - only change links if they are in our url_map
- 216. By Daniel Holbach on 2015-12-14
-
allow github style markdown
- 217. By Daniel Holbach on 2015-12-14
-
remove url_map checks, they are useless
- 218. By Daniel Holbach on 2015-12-14
-
update TODO
- 219. By Daniel Holbach on 2015-12-14
-
support local repositories - useful for testing
- 220. By Daniel Holbach on 2015-12-14
-
add first tests
- 221. By Daniel Holbach on 2015-12-14
-
add another test
- 222. By Daniel Holbach on 2015-12-14
-
pep8 fix
- 223. By Daniel Holbach on 2015-12-15
-
rename tests to be clearer, rewrite tests, so we can reuse a repository we already checked out
- 224. By Daniel Holbach on 2015-12-15
-
rename local_branch to repo - makes more sense these days
- 225. By Daniel Holbach on 2015-12-15
-
add test for post_checkout_
command, fix post_checkout_ command logic by chdir()ing correctly, make pep8+pyflakes happy - 226. By Daniel Holbach on 2015-12-15
-
make create_home_page return home, test page db activities
- 227. By Daniel Holbach on 2015-12-15
-
check if all imported articles have 'home' as parent
- 228. By Daniel Holbach on 2015-12-15
-
add comment, pep8
- 229. By Daniel Holbach on 2015-12-15
-
add function to reset a repo - only useful for tests, where we reuse the same repo to avoid redownloading, add test where only one file is imported and we check the article tree
- 230. By Daniel Holbach on 2015-12-15
-
filter on publisher_
is_draft= True - 231. By Daniel Holbach on 2015-12-15
-
clean up after the test
- 232. By Daniel Holbach on 2015-12-16
-
make index_doc_title available everywhere
- 233. By Daniel Holbach on 2015-12-16
-
add db_add_empty_page convenience function, add simple articletree test, add test for the import of snappy devel
- 234. By Daniel Holbach on 2015-12-16
-
make git quiet
- 235. By Daniel Holbach on 2015-12-16
-
add create_repo convenience function
- 236. By Daniel Holbach on 2015-12-16
-
use create_repo function, add assertions for SnappyRepo vs Repo instantiation
- 237. By Daniel Holbach on 2015-12-17
-
add SnappyTestRepo singleton for re-use, rename variables
- 238. By Daniel Holbach on 2015-12-17
-
add assertions if imported articles have the correct type - drop useless tempdir creation
- 239. By Daniel Holbach on 2015-12-17
-
function article.get was renamed to article.read ages ago...
- 240. By Daniel Holbach on 2015-12-17
-
add test for 'current' snappy import (with check for redirects)
- 241. By Daniel Holbach on 2015-12-17
-
remove superfluous .get() call, add assertion that fetching worked fine
- 242. By Daniel Holbach on 2015-12-17
-
move snappy import tests into their own class
- 243. By Daniel Holbach on 2015-12-18
-
reset snappy test repos at the beginning of the test too
- 244. By Daniel Holbach on 2015-12-18
-
add assertion if snappy repo produces snappy articles
- 245. By Daniel Holbach on 2015-12-18
-
add reset() SnappyRepo to as well, rename variables and function names to be clearer, produce index_doc first, then add other pages, then refer to them in index_doc - this makes sure the parent (index_doc) is in the db first
- 246. By Daniel Holbach on 2015-12-18
-
merge lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3 - resolve conflicts
- 247. By Daniel Holbach on 2015-12-21
-
<ojii|work> because publishing etc will change a pages PK
<ojii|work> Page().publish() creates a new copy of the page (and deletes the old one) - 248. By Daniel Holbach on 2015-12-21
-
improve variable usage
- 249. By Daniel Holbach on 2015-12-21
-
introduce repo.pages to distinguish from .imported_articles
- 250. By Daniel Holbach on 2015-12-21
-
fix tests
- 251. By Daniel Holbach on 2015-12-22
-
check for both 'python-api' and 'script'
- 252. By Daniel Holbach on 2015-12-22
-
break up tests into individual files
- 253. By Daniel Holbach on 2015-12-22
-
update TODO
- 254. By Daniel Holbach on 2016-01-05
-
improve create_repo helper function
- 255. By Daniel Holbach on 2016-01-05
-
allow SourceCode.
_get_branch to use local docs (ie for testing) - 256. By Daniel Holbach on 2016-01-05
-
first cut at testing local links
- 257. By Daniel Holbach on 2016-01-05
-
fix simple link rewrite functionality and test
- 258. By Daniel Holbach on 2016-01-06
-
move md_importer into its own app
- 259. By Daniel Holbach on 2016-01-06
-
add migration for md_importer
- 260. By Daniel Holbach on 2016-01-06
- 261. By Daniel Holbach on 2016-01-06
-
make directory structure clearer
- 262. By Daniel Holbach on 2016-01-06
-
adapt to new name of management command
- 263. By Daniel Holbach on 2016-01-06
-
add more readable error message
- 264. By Daniel Holbach on 2016-01-08
-
add more local test data (imported just the docs from snappy's and snapcraft's git master branches)
- 265. By Daniel Holbach on 2016-01-08
-
WIP commit:
- move and update TODO file
- define some global values for the importer centrally
- don't sys.exit() when adding pages to the db
- add debug messages
- break _find_parent() into its own function
- mostly make use of local test data
- drop singleton, use separate test classes instead
- add more assertions in tests - 266. By Daniel Holbach on 2016-01-08
-
remove debug prints, make Repo class variables actual members
- 267. By Daniel Holbach on 2016-01-08
-
- make pep8 happy, remove unnecessary imports
- use TestLocalBranchImport as base class for almost everything,
reduces a lot of duplication - 268. By Daniel Holbach on 2016-01-08
-
remove unnecessary code, fix publishing of pages in tests
- 269. By Daniel Holbach on 2016-01-08
-
fix test_link_rewrite by fixing the URL
- 270. By Daniel Holbach on 2016-01-08
-
make Article class variables actual members
- 271. By Daniel Holbach on 2016-01-08
-
add new test to check links in snapcraft import, move link checking function into TestLocalBranch
Import - 272. By Daniel Holbach on 2016-01-11
-
merge lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3
- 273. By Daniel Holbach on 2016-01-11
-
allow empty strings in import directives
- 274. By Daniel Holbach on 2016-01-11
-
update migration
- 275. By Daniel Holbach on 2016-01-11
-
check if articles were added below home
- 276. By Daniel Holbach on 2016-01-11
-
remove unnecessary call to set a page's publisher_is_draft bit
- 277. By Daniel Holbach on 2016-01-11
-
give article a .publish() method which gives back the page's public_object
- 278. By Daniel Holbach on 2016-01-11
-
rename home_page to root_page, use cms.test_
utils.testcases .CMSTestCase, make sure we use public_object wherever possible - 279. By Daniel Holbach on 2016-01-11
-
update tests accordingly
- 280. By Daniel Holbach on 2016-01-11
-
disregard anchors, make link checking more flexible (ie not only check for intro.md, but also things like docs/intro.md
- 281. By Daniel Holbach on 2016-01-11
-
make URL work, even if LANG is already part of it
- 282. By Daniel Holbach on 2016-01-11
-
links look like they're working now
- 283. By Daniel Holbach on 2016-01-11
-
add test with a broken link, add convenience function is_local_link, modify tests
- 284. By Daniel Holbach on 2016-01-11
-
import doc fix from https:/
/bugs.launchpad .net/developer- ubuntu- com/+bug/ 1531200 - 285. By Daniel Holbach on 2016-01-11
-
bug fixed
- 286. By Daniel Holbach on 2016-01-12
-
stop import if local images are found, add tests
- 287. By Daniel Holbach on 2016-01-12
-
update TODO
- 288. By Daniel Holbach on 2016-01-12
-
add test to see if importing the same content twice results in the same number of pages
- 289. By Daniel Holbach on 2016-01-15
-
when replacing links, only update HTML if things actually change, only publish if page is dirty
- 290. By Daniel Holbach on 2016-01-15
-
only update page attributes if they actually change, only update the text plugin if the html actually changes, veryify with djangocms_
text_ckeditor. html.clean_ html, add a text plugin to a page, even if html is empty - 291. By Daniel Holbach on 2016-01-15
-
add test to check if running an import twice will update the articles in question
- 292. By Daniel Holbach on 2016-01-15
-
update TODO
- 293. By Daniel Holbach on 2016-01-15
-
add misc tests - forgot to 'bzr add'
- 294. By Daniel Holbach on 2016-01-15
-
make update-mtemplate work again, simplify it
- 295. By Daniel Holbach on 2016-01-15
-
update .pot file
- 296. By Daniel Holbach on 2016-01-15
-
add actual page object to repo.pages
- 297. By Daniel Holbach on 2016-01-15
-
use UTC for ImportedArticle
.last_import, simplify ImportedArticle cleanup - 298. By Daniel Holbach on 2016-01-15
-
use repo instead of branch consistently
- 299. By Daniel Holbach on 2016-01-15
-
break out the process of importing a branch into its own module, add a first simple test for it
- 300. By Daniel Holbach on 2016-01-16
-
fix clean up of imported articles, add a test
- 301. By Daniel Holbach on 2016-01-18
-
update TODO

