Merge lp:~dholbach/developer-ubuntu-com/1525202 into lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3

Proposed by Daniel Holbach on 2015-12-11
Status: Merged
Approved by: David Callé on 2015-12-11
Approved revision: 166
Merged at revision: 163
Proposed branch: lp:~dholbach/developer-ubuntu-com/1525202
Merge into: lp:~developer-ubuntu-com-dev/developer-ubuntu-com/django-1.8-cms-2.3
Diff against target: 95 lines (+26/-20)
1 file modified
developer_portal/management/commands/initdb.py (+26/-20)
To merge this branch: bzr merge lp:~dholbach/developer-ubuntu-com/1525202
Reviewer Review Type Date Requested Status
David Callé 2015-12-11 Approve on 2015-12-11
Review via email: mp+280318@code.launchpad.net

This proposal supersedes a proposal from 2015-12-11.

To post a comment you must log in.
166. By Daniel Holbach on 2015-12-11

use parentheses around print statements, use {} for formatting

David Callé (davidc3) wrote :

Works great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'developer_portal/management/commands/initdb.py'
2--- developer_portal/management/commands/initdb.py 2015-11-06 16:32:19 +0000
3+++ developer_portal/management/commands/initdb.py 2015-12-11 15:44:43 +0000
4@@ -1,17 +1,12 @@
5 #!/usr/bin/python
6
7 from django.core.management.base import BaseCommand
8-from optparse import make_option
9-
10 from django.conf import settings
11
12-import subprocess
13-import os
14-import sys
15-
16-from django.contrib.auth.models import User, Group, Permission
17-from django.contrib.contenttypes.models import ContentType
18+from django.contrib.auth.models import User, Permission
19 from cms.models.permissionmodels import PageUserGroup, GlobalPagePermission
20+from zinnia.models import Category
21+
22
23 class Command(BaseCommand):
24 help = "Make sure the Developer Portal database is set up properly."
25@@ -20,24 +15,25 @@
26
27 all_perms = Permission.objects.filter()
28
29- print "Creating admin user."
30+ print("Creating admin user.")
31 admin, created = User.objects.get_or_create(username='system')
32 admin.is_staff = True
33 admin.is_superuser = True
34 admin.save()
35
36 if hasattr(settings, 'ADMIN_GROUP') and settings.ADMIN_GROUP != "":
37- print "Configuring "+settings.ADMIN_GROUP+" group."
38- admins, created = PageUserGroup.objects.get_or_create(name=settings.ADMIN_GROUP, defaults={'created_by': admin})
39+ print("Configuring {} group.".format(settings.ADMIN_GROUP))
40+ admins, created = PageUserGroup.objects.get_or_create(
41+ name=settings.ADMIN_GROUP, defaults={'created_by': admin})
42 admins.permissions.add(*list(all_perms))
43
44- print "Configuring global permissions for group."
45+ print("Configuring global permissions for group.")
46 adminperms, created = GlobalPagePermission.objects.get_or_create(
47 # who:
48- group = admins,
49+ group=admins,
50
51 # what:
52- defaults = {
53+ defaults={
54 'can_change': True,
55 'can_add': True,
56 'can_delete': True,
57@@ -51,18 +47,20 @@
58 adminperms.sites.add(settings.SITE_ID)
59
60 if hasattr(settings, 'EDITOR_GROUP') and settings.EDITOR_GROUP != "":
61- print "Configuring "+settings.EDITOR_GROUP+" group."
62- editors, created = PageUserGroup.objects.get_or_create(name=settings.EDITOR_GROUP, defaults={'created_by': admin})
63- page_perms = Permission.objects.filter(content_type__app_label='cms', content_type__model='page')
64+ print("Configuring {} group.".format(settings.EDITOR_GROUP))
65+ editors, created = PageUserGroup.objects.get_or_create(
66+ name=settings.EDITOR_GROUP, defaults={'created_by': admin})
67+ page_perms = Permission.objects.filter(
68+ content_type__app_label='cms', content_type__model='page')
69 editors.permissions.add(*list(page_perms))
70
71- print "Configuring global permissions for group."
72+ print("Configuring global permissions for group.")
73 editorsperms, created = GlobalPagePermission.objects.get_or_create(
74 # who:
75- group = editors,
76+ group=editors,
77
78 # what:
79- defaults = {
80+ defaults={
81 'can_change': True,
82 'can_add': True,
83 'can_delete': True,
84@@ -74,3 +72,11 @@
85 }
86 )
87 editorsperms.sites.add(settings.SITE_ID)
88+
89+ print('Adding zinnia categories for the following: {}.'.format(
90+ ', '.join([a[0] for a in settings.LANGUAGES])))
91+ for lang in settings.LANGUAGES:
92+ if lang[1] == 'Simplified Chinese':
93+ Category.objects.get_or_create(title='Chinese', slug=lang[0])
94+ else:
95+ Category.objects.get_or_create(title=lang[1], slug=lang[0])

Subscribers

People subscribed via source and target branches