Merge lp:~dholbach/click-reviewers-tools/run-pyflakes3 into lp:click-reviewers-tools

[Daniel Holbach]

[Michael Vogt (mvo)]

Awesome!

review: Approve

=== modified file 'clickreviews/cr_common.py'
--- clickreviews/cr_common.py	2015-04-10 10:36:49 +0000
+++ clickreviews/cr_common.py	2015-04-10 13:00:11 +0000
@@ -145,7 +145,7 @@
         if pkg_yaml is not None:
             try:
                 self.pkg_yaml = yaml.safe_load(pkg_yaml)
-            except Exception as e:
+            except Exception:
                 error("Could not load package.yaml. Is it properly formatted?")
             self._verify_package_yaml_structure()
             self.is_snap = True

=== modified file 'clickreviews/cr_content_hub.py'
--- clickreviews/cr_content_hub.py	2015-03-18 19:51:13 +0000
+++ clickreviews/cr_content_hub.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error, open_file_read
 import json
 import os
 

=== modified file 'clickreviews/cr_desktop.py'
--- clickreviews/cr_desktop.py	2015-04-07 15:09:51 +0000
+++ clickreviews/cr_desktop.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error, open_file_read
 import glob
 import json
 import os

=== modified file 'clickreviews/cr_online_accounts.py'
--- clickreviews/cr_online_accounts.py	2015-04-10 12:35:06 +0000
+++ clickreviews/cr_online_accounts.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error
 import os
 # http://lxml.de/tutorial.html
 import lxml.etree as etree
@@ -126,7 +126,6 @@
             t = 'info'
             n = '%s_%s_id' % (app, account_type)
             s = "OK"
-            expected_id = "%s_%s" % (self.manifest["name"], app)
             if "id" in self.accounts[app][account_type].keys():
                 t = 'warn'
                 s = "Found 'id' in application tag"
@@ -174,7 +173,6 @@
             t = 'info'
             n = '%s_%s_id' % (app, account_type)
             s = "OK"
-            expected_id = "%s_%s" % (self.manifest["name"], app)
             if "id" in self.accounts[app][account_type].keys():
                 t = 'warn'
                 s = "Found 'id' in service tag"
@@ -223,7 +221,6 @@
             t = 'info'
             n = '%s_%s_id' % (app, account_type)
             s = "OK"
-            expected_id = "%s_%s" % (self.manifest["name"], app)
             if "id" in self.accounts[app][account_type].keys():
                 t = 'warn'
                 s = "Found 'id' in provider tag"

=== modified file 'clickreviews/cr_push_helper.py'
--- clickreviews/cr_push_helper.py	2015-03-18 19:51:13 +0000
+++ clickreviews/cr_push_helper.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error, open_file_read
 import json
 import os
 

=== modified file 'clickreviews/cr_scope.py'
--- clickreviews/cr_scope.py	2015-03-18 19:51:13 +0000
+++ clickreviews/cr_scope.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, msg
+from clickreviews.cr_common import ClickReview, error
 import codecs
 import configparser
 import os

=== modified file 'clickreviews/cr_systemd.py'
--- clickreviews/cr_systemd.py	2015-04-03 22:17:04 +0000
+++ clickreviews/cr_systemd.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error, open_file_read
 import yaml
 import os
 

=== modified file 'clickreviews/cr_url_dispatcher.py'
--- clickreviews/cr_url_dispatcher.py	2015-03-18 19:51:13 +0000
+++ clickreviews/cr_url_dispatcher.py	2015-04-10 13:00:11 +0000
@@ -16,7 +16,7 @@
 
 from __future__ import print_function
 
-from clickreviews.cr_common import ClickReview, error, open_file_read, msg
+from clickreviews.cr_common import ClickReview, error, open_file_read
 import json
 import os
 

=== modified file 'clickreviews/tests/test_cr_framework.py'
--- clickreviews/tests/test_cr_framework.py	2015-04-03 20:00:32 +0000
+++ clickreviews/tests/test_cr_framework.py	2015-04-10 13:00:11 +0000
@@ -13,8 +13,6 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
-import sys
-from io import StringIO
 
 from clickreviews.cr_framework import ClickReviewFramework
 import clickreviews.cr_tests as cr_tests

=== modified file 'debian/control'
--- debian/control	2015-03-04 22:46:47 +0000
+++ debian/control	2015-04-10 13:00:11 +0000
@@ -4,6 +4,7 @@
 Maintainer: Ubuntu Appstore Developers <[e-mail]>
 Build-Depends: debhelper (>= 9~),
                pep8,
+               pyflakes,
                python3-all (>= 3.2~),
                python3-apt,
                python3-debian,

=== modified file 'debian/rules'
--- debian/rules	2014-11-11 16:14:12 +0000
+++ debian/rules	2015-04-10 13:00:11 +0000
@@ -43,4 +43,5 @@
 		$$python setup.py test; \
 	done
 	./run-pep8
+	./run-pyflakes
 endif

=== added file 'run-pyflakes'
--- run-pyflakes	1970-01-01 00:00:00 +0000
+++ run-pyflakes	2015-04-10 13:00:11 +0000
@@ -0,0 +1,9 @@
+#!/bin/sh
+set -e
+
+echo "= pyflakes3 ="
+for i in ./bin/update-* ./bin/click-check-* ./bin/click-show-files ./bin/click-review \
+	 ./clickreviews/*py ./clickreviews/tests/*py ; do
+    echo "Checking $i"
+    pyflakes3 $i
+done