lp:~dholbach/click-reviewers-tools/packaging

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:click-reviewers-tools at revision 72

Jamie Strandboge (community): Approve on 2013-09-26

Diff: 1205 lines (+882/-54)

24 files modified

.bzr-builddeb/default.conf (+2/-0)
COPYING (+674/-0)
README (+7/-7)
bin/click-check-desktop (+8/-4)
bin/click-check-lint (+6/-2)
bin/click-check-security (+6/-2)
bin/click-check-skeleton (+6/-2)
bin/click-run-checks (+22/-13)
bin/repack-click (+7/-3)
bin/show-click-files (+8/-5)
bin/unpack-click (+5/-1)
clickreviews/cr_desktop.py (+1/-1)
clickreviews/cr_lint.py (+1/-1)
clickreviews/cr_security.py (+2/-2)
clickreviews/cr_skeleton.py (+1/-1)
clickreviews/tests/test_cr_lint.py (+9/-9)
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+22/-0)
debian/copyright (+20/-0)
debian/docs (+1/-0)
debian/rules (+45/-0)
run-tests (+1/-1)
setup.py (+22/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1230248: Package click-reviewers-tools

Undecided

Fix Released

Link a bug report

Related blueprints

79. By Daniel Holbach on 2013-09-26

adhere to https://wiki.ubuntu.com/DailyRelease/InlinePackaging

78. By Daniel Holbach on 2013-09-26

add packaging

77. By Daniel Holbach on 2013-09-26

add build system

76. By Daniel Holbach on 2013-09-26

move executables into separate directory

75. By Daniel Holbach on 2013-09-26

move tests below 'clickreviews'

74. By Daniel Holbach on 2013-09-26

adjust to new location of imported code

73. By Daniel Holbach on 2013-09-26

move module in its own place

72. By Daniel Holbach on 2013-09-25

add license

71. By Jamie Strandboge on 2013-09-24

uncomment 'return' to short-circuit if arch is 'unknown' introduced in the last
commit

70. By Jamie Strandboge on 2013-09-24

merge in Martin Albisetti's changes:
This branch adds a very basic test infrastructure as I was chasing a bug and
felt the need to have something a bit more reproduceable :)
I mostly did 3 things:

1) Refactored the classes a bit so the methods that accessed the filesystem
were easily overridable for unit tests
2) Added the unit test for the bug I wanted to fix
3) Fixed a bug where the namespace comparison would fail if the namespace
contained the word "click" (the . was not being escaped

To run tests, make sure you have python-nose installed, and run "nosetests".

This was my very interrupted approach at adding tests, am happy for it to be
rejected in favor of other/better ways of doing it.