APT

Merge lp:~dholbach/apt/1037521 into lp:~ubuntu-core-dev/apt/ubuntu

Proposed by Daniel Holbach
Status: Rejected
Rejected by: Daniel Holbach
Proposed branch: lp:~dholbach/apt/1037521
Merge into: lp:~ubuntu-core-dev/apt/ubuntu
Diff against target: 12 lines (+1/-1)
1 file modified
cmdline/apt-cache.cc (+1/-1)
To merge this branch: bzr merge lp:~dholbach/apt/1037521
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+119902@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Hartwig (wigs) wrote :

> change Warning to Error if source package can not be found, to match
> with ShowPackage behaviour

Changing the Notice(_("No packages found")) to an error would more closely match ShowPackage, which only returns an error if no packages were found at all.

lp:~dholbach/apt/1037521 updated
2001. By Daniel Holbach

Only show an error if no packages were found at all, thanks Daniel Hartwig for the review

Revision history for this message
Daniel Holbach (dholbach) wrote :

I think I'll reject the MP for now, as sbuild seems to rely on this return code.(?)

Unmerged revisions

2001. By Daniel Holbach

Only show an error if no packages were found at all, thanks Daniel Hartwig for the review

2000. By Daniel Holbach

change Warning to Error if source package can not be found, to match with ShowPackage behaviour

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmdline/apt-cache.cc'
2--- cmdline/apt-cache.cc 2012-05-22 14:07:49 +0000
3+++ cmdline/apt-cache.cc 2012-08-17 07:46:19 +0000
4@@ -1454,7 +1454,7 @@
5 }
6 }
7 if (found == 0)
8- _error->Notice(_("No packages found"));
9+ _error->Error(_("No packages found"));
10 return true;
11 }
12 /*}}}*/

Subscribers

People subscribed via source and target branches

to all changes: