Merge ~dgadomski/curtin:grub-config-not-subsciptable into curtin:master

[Dariusz Gadomski]

curthooks: fix deprecated GrubConfig properties syntax

There was a leftover example of accessing GrubConfig properties that has
been removed by commit 4587fd40dfd7eabd6677004e91340edcfe5a7472.

If the user tries to run an automated installation and will set
storage.grub.install_devices most likely they will end up in hitting curtin/commands/curthooks.py:782:
LOG.warn("Storage Config grub device config takes precedence "
                         "over grub 'install_devices' value, ignoring: %s",
                         grubcfg['install_devices'])

This will lead to:
TypeError: 'GrubConfig' object is not subscriptable
'GrubConfig' object is not subscriptable

The syntax used in this line is a pre-refactoring leftover probably skipped by mistake in commit 4587fd40dfd7eabd6677004e91340edcfe5a7472.

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:700b1f8756990ce06b8b57056d227a0d5385f15f
https://jenkins.canonical.com/server-team/job/curtin-ci/268/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/server-team/job/curtin-ci/nodes=metal-amd64/268/
    SUCCESS: https://jenkins.canonical.com/server-team/job/curtin-ci/nodes=metal-arm64/268/
    SUCCESS: https://jenkins.canonical.com/server-team/job/curtin-ci/nodes=metal-ppc64el/268/
    SUCCESS: https://jenkins.canonical.com/server-team/job/curtin-ci/nodes=metal-s390x/268/

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/curtin-ci/268//rebuild

review: Approve (continuous-integration)

[Dan Bungert (dbungert)]

The code change certainly looks correct but what sort of things should we be testing for to reproduce the issue? A new test would be preferable, or at least I would like information on a concrete example that produces the problem.

[Dariusz Gadomski (dgadomski)]

Thank you for looking into this Dan. I have added some info of how the user run into this problem. Reproducing it by setting install_devices in subiquity autoinstall seems consistent.

Unmerged commits

700b1f8... by Dariusz Gadomski on 2024-05-14

curthooks: fix deprecated GrubConfig properties syntax

There was a leftover example of accessing GrubConfig properties that has
been removed by commit 4587fd40dfd7eabd6677004e91340edcfe5a7472.

diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
index 34ff660..264d7d0 100644
--- a/curtin/commands/curthooks.py
+++ b/curtin/commands/curthooks.py
@@ -779,7 +779,7 @@ def setup_grub(
                grubcfg.install_devices is not grubcfg.install_devices_default:
                 LOG.warn("Storage Config grub device config takes precedence "
                          "over grub 'install_devices' value, ignoring: %s",
-                         grubcfg['install_devices'])
+                         grubcfg.install_devices)
             grubcfg.install_devices = storage_grub_devices
 
     LOG.debug("install_devices: %s", grubcfg.install_devices)