“Ubuntu Developer Membership Board” team

Merge ~developer-membership-board/+git/packageset:tweak-the-script into ~developer-membership-board/+git/packageset:master

  1. Git
  2. lp:~developer-membership-board/+git/packageset
  3. tweak-the-script
  4. Merge into master
Proposed by Sebastien Bacher
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: 80e2ef6338e49e1866843273727268eb88e12938
Proposed branch: ~developer-membership-board/+git/packageset:tweak-the-script
Merge into: ~developer-membership-board/+git/packageset:master
Diff against target: 44 lines (+6/-6)
1 file modified
Makefile (+6/-6)
Reviewer Review Type Date Requested Status
Robie Basak Approve
Review via email: mp+426471@code.launchpad.net

Description of the change

Unsure if the script is meant to be install but since there is no instruction for doing so it seems it would make sense to get it working from a checkout?

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

Yes I agree this seems completely reasonable.

FWIW, I think you're the only one looking at this at the moment (thank you!), so for minor tweaks I think you should feel free to land without an MP unless you specifically want a review, or there's some material change in DMB policy being applied by the script that you think the DMB needs to agree to first.

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

> Change the rules to work for a local checkout and fix a spacing issue

FWIW, if a commit message needs to say (A and B) and they are unrelated then that's usually a hint that they should be two separate commits. I think that probably applies to this commit. But this isn't important.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've split the change as suggested and pushed now

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index fc9235a..eeb2e46 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -6,33 +6,33 @@ all:
6 $(MAKE) --quiet report; \
7 $(MAKE) --quiet changes; \
8 echo "Don't forget: run \"$(MAKE) push\" to commit changes"; \
9- else \
10+ else \
11 echo "Please run \"$(MAKE) fetch\" first"; \
12 fi
13
14 fetch:
15- @fetch.sh
16+ @./fetch.sh
17
18 germinate:
19 @if test -f germinated/core.seed; then \
20 echo "Run \"$(MAKE) clean\" before a new germinate"; \
21 else \
22 echo "Germinating (dir: ./germinated/)"; \
23- germinate.sh; \
24+ ./germinate.sh; \
25 fi
26
27 report:
28 @echo "Generating Report (file: ./output/output)"
29- @pkgset-report.py > ./output/output
30+ @./pkgset-report.py > ./output/output
31
32 changes:
33 @echo "Generating Changes (file: ./output/changes)"
34- @pkgset-push.py -vn ./output/output > ./output/changes
35+ @./pkgset-push.py -vn ./output/output > ./output/changes
36 @less ./output/changes
37
38 push:
39 @echo "Pushing Changes"
40- @pkgset-push.py -v ./output/output
41+ @./pkgset-push.py -v ./output/output
42
43 clean:
44 @echo "Cleaning temporary files"

Subscribers

People subscribed via source and target branches