Merge lp:~devcamcar/django-nova/fix_volume_maintenance into lp:django-nova

Proposed by Devin Carlen
Status: Merged
Approved by: Devin Carlen
Approved revision: 10
Merged at revision: 10
Proposed branch: lp:~devcamcar/django-nova/fix_volume_maintenance
Merge into: lp:django-nova
Diff against target: 56 lines (+7/-7)
1 file modified
src/django_nova/views/volumes.py (+7/-7)
To merge this branch: bzr merge lp:~devcamcar/django-nova/fix_volume_maintenance
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+47477@code.launchpad.net

Description of the change

Made volume views use the handle_nova_error decorator.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/django_nova/views/volumes.py'
2--- src/django_nova/views/volumes.py 2011-01-18 23:07:26 +0000
3+++ src/django_nova/views/volumes.py 2011-01-25 23:18:44 +0000
4@@ -24,14 +24,14 @@
5 from django.contrib import messages
6 from django.contrib.auth.decorators import login_required
7 from django.shortcuts import redirect, render_to_response
8-from django.views.decorators.cache import never_cache
9 from django_nova import exceptions
10 from django_nova import forms
11-from django_nova.shortcuts import get_project_or_404, get_projects
12+from django_nova.exceptions import handle_nova_error
13+from django_nova.shortcuts import get_project_or_404
14
15
16 @login_required
17-@never_cache
18+@handle_nova_error
19 def index(request, project_id):
20 project = get_project_or_404(request, project_id)
21 volumes = project.get_volumes()
22@@ -46,7 +46,7 @@
23
24
25 @login_required
26-@never_cache
27+@handle_nova_error
28 def add(request, project_id):
29 project = get_project_or_404(request, project_id)
30
31@@ -79,7 +79,7 @@
32
33
34 @login_required
35-@never_cache
36+@handle_nova_error
37 def delete(request, project_id, volume_id):
38 project = get_project_or_404(request, project_id)
39
40@@ -98,7 +98,7 @@
41
42
43 @login_required
44-@never_cache
45+@handle_nova_error
46 def attach(request, project_id):
47 project = get_project_or_404(request, project_id)
48
49@@ -133,7 +133,7 @@
50
51
52 @login_required
53-@never_cache
54+@handle_nova_error
55 def detach(request, project_id, volume_id):
56 project = get_project_or_404(request, project_id)
57

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: