Merge lp:~deuns-martinez/loggerhead/flup into lp:loggerhead
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Matt Nordhoff on 2009-11-29 | ||||
Proposed branch: | lp:~deuns-martinez/loggerhead/flup | ||||
Merge into: | lp:loggerhead | ||||
Diff against target: |
15 lines (+5/-0) 1 file modified
loggerhead/main.py (+5/-0) |
||||
To merge this branch: | bzr merge lp:~deuns-martinez/loggerhead/flup | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matt Nordhoff | 2009-11-27 | Disapprove on 2009-11-27 | |
Review via email:
|
This proposal supersedes a proposal from 2009-11-23.
Denis Martinez (deuns-martinez) wrote : | # |
Matt Nordhoff (mnordhoff) wrote : | # |
This looks nice to be, though I don't want to set up something to test it.
The (optional) flup dependency should be added to the README, but that's something than can be done when it's merged.
39 + return
That should be sys.exit(1), IMO.
Robert Collins (lifeless) wrote : | # |
Matt, why sys.exit(1) rather than return? to get a non-zero exit code?
Matt Nordhoff (mnordhoff) wrote : | # |
(Oops, didn't see this email.)
Robert Collins wrote:
> Matt, why sys.exit(1) rather than return? to get a non-zero exit code?
Yeah. Plus, it's consistent with the other code.
Martin Albisetti (beuno) wrote : | # |
Denis, could you tweak these bits so we can merge?
Denis Martinez (deuns-martinez) wrote : | # |
Alright, it's done.
Matt Nordhoff (mnordhoff) wrote : | # |
I already tweaked and landed it. Sorry.
(Except I made an error, which I just noticed when looking at your patch, and fixed. Thanks!)
(I can never land anything without doing one little fix after-the-fact. Darnit!)
Unmerged revisions
- 395. By Denis Martinez on 2009-11-27
-
sys.exit(1) instead of return
Proposal to add FastCGI, SCGI and AJP support using flup.
This makes it usable under the Cherokee web server and others.