DBus Menu

Merge lp:~desrt/libdbusmenu/dont-send-event-replies into lp:libdbusmenu/0.6

  1. dont-send-event-replies
  2. Merge into trunk.0.6
Proposed by Allison Karlitskaya
Status: Merged
Approved by: Ted Gould
Approved revision: 390
Merged at revision: 391
Proposed branch: lp:~desrt/libdbusmenu/dont-send-event-replies
Merge into: lp:libdbusmenu/0.6
Diff against target: 14 lines (+3/-1)
1 file modified
libdbusmenu-glib/server.c (+3/-1)
To merge this branch: bzr merge lp:~desrt/libdbusmenu/dont-send-event-replies
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+99545@code.launchpad.net

Description of the change

server: don't send replies for events that don't request replies

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/server.c'
2--- libdbusmenu-glib/server.c 2012-02-15 17:17:18 +0000
3+++ libdbusmenu-glib/server.c 2012-03-27 15:44:18 +0000
4@@ -1626,7 +1626,9 @@
5
6 g_timeout_add(0, event_local_handler, event_data);
7
8- g_dbus_method_invocation_return_value(invocation, NULL);
9+ if (~g_dbus_message_get_flags (g_dbus_method_invocation_get_message (invocation)) & G_DBUS_MESSAGE_FLAGS_NO_REPLY_EXPECTED) {
10+ g_dbus_method_invocation_return_value(invocation, NULL);
11+ }
12 }
13
14 return;

Subscribers

People subscribed via source and target branches