Merge lp:~desrt/indicator-appmenu/no-zero-indicator-penalty into lp:indicator-appmenu/0.4

[Allison Karlitskaya]

    hud: never allow perfect match for indicators

    The old scoring algorithm would assign a penalty of one for searching
    for "item" and finding "Item" (due to the case). The new algorithm
    ignores case.

    This caused an unintended problem: the fact that we would never get
    perfect matches (due to the fact that nobody ever properly capitalised
    their search strings) was a good thing. The indicator penalty is
    expressed as a percentage by which to increase whatever the distance
    already was, and that doesn't work well with the now-common case of a
    perfect match (since 0 + 50% is still 0).

    We tweak this situation by never allowing a match from an indicator have
    a perfect score. If the indicator penalty is requested, then the
    distance must be at least 1.

[Charles Kerr (charlesk)]

looks good.

Thanks for the good description, too...

review: Approve

=== modified file 'src/hudresult.c'
--- src/hudresult.c	2012-03-31 03:54:13 +0000
+++ src/hudresult.c	2012-04-11 13:53:19 +0000
@@ -201,6 +201,9 @@
 
   result->distance += (result->distance * penalty) / 100;
 
+  if (result->distance == 0 && penalty > 0)
+    result->distance = 1;
+
   return result;
 }