Merge lp:~desrt/indicator-appmenu/hud-rewrite-wip into lp:indicator-appmenu/0.4
Proposed by
Allison Karlitskaya
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 175 | ||||||||
Proposed branch: | lp:~desrt/indicator-appmenu/hud-rewrite-wip | ||||||||
Merge into: | lp:indicator-appmenu/0.4 | ||||||||
Diff against target: |
312 lines (+75/-96) 5 files modified
src/hud-service.c (+29/-67) src/huditem.c (+44/-0) src/huditem.h (+2/-0) src/hudquery.c (+0/-27) src/hudquery.h (+0/-2) |
||||||||
To merge this branch: | bzr merge lp:~desrt/indicator-appmenu/hud-rewrite-wip | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Indicator Applet Developers | Pending | ||
Review via email: mp+96476@code.launchpad.net |
Description of the change
Switch to identifying items by unique identifier rather than their index in a possibly-changing list of results.
This should improve the reliability of item activation.
To post a comment you must log in.
I haven't been following hud enough to review the 'why' of this patch, but the 'how' looks fine except for item_key, which can be leaked iff its type isn't uint64