Merge lp:~deryck/lazr-js/choiceedit-select-fix-529049 into lp:lazr-js

[Deryck Hodge]

Do not assume there is a selected item for choiceedit.js.

[Deryck Hodge (deryck)]

This branch fixes the choice edit widget to not assume there is a selected item. This fixes the "affects me too" widget on LP, which doesn't have a selected item by default.

[Graham Binns (gmb)]

review: Approve (js)

=== modified file 'src-js/lazrjs/choiceedit/choiceedit.js'
--- src-js/lazrjs/choiceedit/choiceedit.js	2010-02-23 13:14:18 +0000
+++ src-js/lazrjs/choiceedit/choiceedit.js	2010-02-27 16:56:18 +0000
@@ -523,10 +523,15 @@
         var boundingBox = this.get('boundingBox');
         var selectedListItem = boundingBox.query('span.current');
         valueX = this._mouseX - (boundingBox.get('offsetWidth') / 2);
-        valueY = (this._mouseY -
-                  this.get("headerContent").get('offsetHeight') -
-                  selectedListItem.get('offsetTop') -
-                  (selectedListItem.get('offsetHeight') / 2));
+        var valueY;
+        if (Y.Lang.isValue(selectedListItem)) {
+            valueY = (this._mouseY -
+                      this.get("headerContent").get('offsetHeight') -
+                      selectedListItem.get('offsetTop') -
+                      (selectedListItem.get('offsetHeight') / 2));
+        } else {
+             valueY = this._mouseY - (boundingBox.get('offsetHeight') / 2);
+        }
         if (valueX < 0) {
             valueX = 0;
         }