Merge lp:~deryck/launchpad/ubuntu-bugs-front-timeout-590992 into lp:launchpad

Proposed by Deryck Hodge
Status: Merged
Approved by: Deryck Hodge
Approved revision: no longer in the source branch.
Merged at revision: 10968
Proposed branch: lp:~deryck/launchpad/ubuntu-bugs-front-timeout-590992
Merge into: lp:launchpad
Diff against target: 15 lines (+0/-5)
1 file modified
lib/lp/bugs/browser/ (+0/-5)
To merge this branch: bzr merge lp:~deryck/launchpad/ubuntu-bugs-front-timeout-590992
Reviewer Review Type Date Requested Status
Björn Tillenius (community) code/rc Approve
Review via email:

Commit message

Remove an unused bug count variable that is causing timeouts on Ubuntu bugs home.

Description of the change is timing out. See bug 590992.

This branch removes an unused bug_count_items from browser code.
Getting this bug count for all Ubuntu bugs was causing the timeout. I
I have tested on staging and confirmed that the timeout is fixed with
dropping these lines. Spot checks of tests see no fallout from
removing the code.

The branch is going off to ec2 as I type this MP.

I'n also interested in getting RC approval and getting this change
cowboyed onto lpnet and edge to get the bugs home working again until
the branch can work its way through ec2 and landing.

To post a comment you must log in.
Revision history for this message
Björn Tillenius (bjornt) wrote :

< BjornT> deryck: have you confirmed that that view isn't used on other
< deryck> BjornT, the view is for every top-level bugs page, not just
          distro. a grep for bug_count_items turns up nothing. doc and
          browser tests pass. I'll look at zcml to make sure nothing
          else uses it, though....

review: Approve (code/rc)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/'
2--- lib/lp/bugs/browser/ 2010-06-04 14:16:17 +0000
3+++ lib/lp/bugs/browser/ 2010-06-08 11:34:27 +0000
4@@ -1164,11 +1164,6 @@
5 bug_statuses_to_show = list(UNRESOLVED_BUGTASK_STATUSES)
6 if IDistroSeries.providedBy(self.context):
7 bug_statuses_to_show.append(BugTaskStatus.FIXRELEASED)
8- bug_counts = sorted(self.context.getBugCounts(
9- self.user, bug_statuses_to_show).items())
10- self.bug_count_items = [
11- BugCountDataItem(status.title, count, self.status_color[status])
12- for status, count in bug_counts]
14 @property
15 def uses_launchpad_bugtracker(self):