Launchpad itself

Merge lp:~deryck/launchpad/remove-unused-templates-424316 into lp:launchpad

  1. remove-unused-templates-424316
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Merged at revision: not available
Proposed branch: lp:~deryck/launchpad/remove-unused-templates-424316
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~deryck/launchpad/remove-unused-templates-424316
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Review via email: mp+11197@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

This branch removes malone-about.pt and watches-index.pt. The is bug
424316.

The malone about page is unused; there is a configuration in
marketing.zcml that redirects bugs.lp.net/+about to +tour/bugs. There
was some zcml for watches-index.pt, but neither Graham nor myself could
find a real URL that could be hit to invoke the template. So it also
seems safe to remove.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/browser/configure.zcml

Revision history for this message
Guilherme Salgado (salgado) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/configure.zcml'
2--- lib/lp/bugs/browser/configure.zcml 2009-09-03 10:24:58 +0000
3+++ lib/lp/bugs/browser/configure.zcml 2009-09-04 13:13:35 +0000
4@@ -203,18 +203,13 @@
5 permission="zope.Public"
6 name="+index"
7 template="../templates/malone-index.pt"/>
8- <browser:pages
9+ <browser:page
10 for="lp.bugs.interfaces.malone.IMaloneApplication"
11 class="lp.bugs.browser.bug.MaloneView"
12 facet="bugs"
13- permission="zope.Public">
14- <browser:page
15- name="+about"
16- template="../templates/malone-about.pt"/>
17- <browser:page
18- name="+portlet-stats"
19- template="../templates/malone-portlet-stats.pt"/>
20- </browser:pages>
21+ permission="zope.Public"
22+ name="+portlet-stats"
23+ template="../templates/malone-portlet-stats.pt"/>
24 <browser:page
25 name="+filebug"
26 for="lp.bugs.interfaces.malone.IMaloneApplication"
27@@ -1112,12 +1107,5 @@
28 module="lp.bugs.browser.bugwatch"
29 classes="
30 BugWatchSetNavigation"/>
31- <browser:pages
32- for="lp.bugs.interfaces.bugwatch.IBugWatchSet"
33- permission="zope.Public">
34- <browser:page
35- name="+index"
36- template="../templates/watches-index.pt"/>
37- </browser:pages>
38 </facet>
39 </configure>
40
41=== removed file 'lib/lp/bugs/templates/malone-about.pt'
42--- lib/lp/bugs/templates/malone-about.pt 2009-07-17 17:59:07 +0000
43+++ lib/lp/bugs/templates/malone-about.pt 1970-01-01 00:00:00 +0000
44@@ -1,56 +0,0 @@
45-<html
46- xmlns="http://www.w3.org/1999/xhtml"
47- xmlns:tal="http://xml.zope.org/namespaces/tal"
48- xmlns:metal="http://xml.zope.org/namespaces/metal"
49- xmlns:i18n="http://xml.zope.org/namespaces/i18n"
50- xml:lang="en"
51- lang="en"
52- dir="ltr"
53- metal:use-macro="context/@@main_template/master"
54- i18n:domain="malone"
55->
56- <body>
57- <metal:heading fill-slot="pageheading">
58- <h1>About the Launchpad Bug Tracker</h1>
59- </metal:heading>
60-
61-<metal:leftportlets fill-slot="portlets_one">
62- <div tal:replace="structure context/@@+portlet-stats" />
63-</metal:leftportlets>
64-
65-<div metal:fill-slot="main">
66-
67- <p>
68- The Launchpad Bug Tracker is a collaborative bug tracker for the
69- Free Software universe. It works a bit differently from other
70- trackers.
71- </p>
72- <h2>One bug, many places</h2>
73- <p>
74- Some people find bugs in software they install directly from its
75- developers.
76- Other people find bugs in software packages they install as part of
77- a distribution.
78- </p>
79- <p>
80- When these are the same bug, Launchpad can link them together.
81- Once one team fixes the bug, others can share the fix.
82- </p>
83- <h2>One world, many bug trackers</h2>
84- <p>
85- The more software teams use Launchpad, the more useful it becomes.
86- But if a team uses Bugzilla, Sourceforge, or debbugs,
87- Launchpad can link their bug reports with those in Launchpad,
88- and let you know when they&#8217;re fixed.
89- </p>
90- <h2>How to get started</h2>
91- <p>
92- To use Launchpad for your project, first
93- <a href="/projects">check whether it&#8217;s registered already</a>.
94- The admin for a project can set that project to use Launchpad
95- (this is off by default so that people don&#8217;t report bugs that
96- nobody reads).
97- </p>
98- </div>
99- </body>
100-</html>
101
102=== removed file 'lib/lp/bugs/templates/watches-index.pt'
103--- lib/lp/bugs/templates/watches-index.pt 2009-07-17 17:59:07 +0000
104+++ lib/lp/bugs/templates/watches-index.pt 1970-01-01 00:00:00 +0000
105@@ -1,15 +0,0 @@
106-<html
107- xmlns="http://www.w3.org/1999/xhtml"
108- xmlns:tal="http://xml.zope.org/namespaces/tal"
109- xmlns:metal="http://xml.zope.org/namespaces/metal"
110- xmlns:i18n="http://xml.zope.org/namespaces/i18n"
111- xml:lang="en"
112- lang="en"
113- dir="ltr"
114- metal:use-macro="context/@@main_template/master"
115- i18n:domain="launchpad"
116- tal:replace="python:request.response.redirect('..')">
117- <body>
118- <a href=".">Here</a>
119- </body>
120-</html>