Merge lp:~deryck/launchpad/product-specification-sharing-policy-idx-1057617 into lp:launchpad

[Deryck Hodge]

Add db index for Product.specification_sharing_policy.

This adds an index for Product.specification_sharing_policy. It's one of a couple final branches to finish out the schema changes for Product.specification_sharing_policy. As I understand, this will be applied live, so I'm proposing for merge into lp:launchpad. If I misunderstood this process, please let me know.

[Stuart Bishop (stub)]

The DB patch is fine, but we can't think why it is needed. This index is really only helpful for selecting all products with a particular policy in an arbitrary order, which might be useful for initial population of the column but probably not given the Product table doesn't have that many rows.

review: Needs Information (db)

[Deryck Hodge (deryck)]

Ah, fair point. I was thinking of selecting products by policy, but we don't actually need to do that. Sorry. Thanks for catching that. I'll reject the MP and drop the branch.

Unmerged revisions

16043. By Deryck Hodge on 2012-09-27

Add patch for index for Product.specification_sharing_policy.

=== added file 'database/schema/patch-2209-31-2.sql'
--- database/schema/patch-2209-31-2.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-31-2.sql	2012-09-27 16:42:21 +0000
@@ -0,0 +1,9 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE INDEX product__specicification_sharing_policy__idx
+    ON Product(specification_sharing_policy);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 31, 2);