Merge lp:~deryck/launchpad/orderbybar-integration-fixes into lp:launchpad
Proposed by
Deryck Hodge
Status: | Merged |
---|---|
Approved by: | Deryck Hodge |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14217 |
Proposed branch: | lp:~deryck/launchpad/orderbybar-integration-fixes |
Merge into: | lp:launchpad |
Diff against target: |
134 lines (+79/-1) 4 files modified
buildout-templates/bin/combine-css.in (+1/-0) lib/lp/app/javascript/ordering/assets/ordering-core.css (+26/-0) lib/lp/app/javascript/ordering/ordering.js (+37/-1) lib/lp/app/javascript/ordering/tests/test_orderby_widget.js (+15/-0) |
To merge this branch: | bzr merge lp:~deryck/launchpad/orderbybar-integration-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+80705@code.launchpad.net |
Commit message
[r=bac][no-qa] Add CSS for OrderByBar and fix a bug where active-sort class wasn't being changed.
Description of the change
This branch contains my fixes to OrderByBar that were discovered as I began to integrate the widget into the LP page. This includes:
* Adding CSS for the widget
* Adding a test and fixing the issue that active-sort
class was not being applied to the node that was clicked
Actually, it's more accurate to say I have a large branch going doing integration work, and this widget stuff could be broken out into this branch to make it easier to get reviewed.
To post a comment you must log in.
This change looks good Deryck. Thanks for fixing the lint issues.