Merge lp:~deryck/launchpad/no-lp-bugs-homepage-439245 into lp:launchpad

[Deryck Hodge]

Don't enable a bugs home page for projects that don't use Launchpad for bug tracking.

[Deryck Hodge (deryck)]

= Summary =

This branch started as a fix for Bug #439245, hot bugs listed on project
bugs home when the project doesn't use Launchpad, and in the process we
decided to fix Bug #174473, project home page has search form even when
there are no bugs.

== Proposed fix ==

The fix for the first bug is to check for
view/uses_launchpad_bugtracker, and if this is the case, show the bugs
home page as it currently is on lp.net. If not, we don't show anything
on the home page and add a note that the project does not use Launchpad
for bug tracking. There is also a link provided to edit the project
details and change to use Launchpad if desired.

The fix for the second bug is to check view/hot_bugtasks as a condition
for showing the search form. If there are no hot_bugtasks, there are no
bugs filed against the project.

== Pre-implementation notes ==

This branch was done with me and Brian Fromme pairing at the bug heat
sprint, and we consulted Tom, Graham, and Gavin as needed.

== Implementation details ==

There were several broken tests to fix. In some cases, we removed the
failing sections of a test because the workflow was no longer supported.
  In other cases, we updated the test to update data or use
LaunchpadObjectFactory.

== Tests ==

Updated tests to run include:

./bin/test -cvvt xx-advanced-upstream-pending-bugwatch.txt
./bin/test -cvvt xx-portlets-bug-series.txt
./bin/test -cvvt xx-product-bugs-page.txt
./bin/test -cvvt initial-bug-contacts

We added a test to cover new functionality:

./bin/test -cvvt xx-front-page-info.txt

== Demo and Q/A ==

To demo, create a project and confirm that the bugs home page, i.e.
https://bugs.launchpad.dev/test-project/, does not list any of the
normal bugs info.

Then change the details to use malone and confirm that the page has bug
info listed.

Then, file bugs to confirm that a "Hot bugs" list appears.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
   lib/lp/bugs/stories/bugs/xx-front-page-info.txt

lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt
   lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt
   lib/lp/bugs/templates/bugtarget-bugs.pt
   lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt
   lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt

[Eleanor Berger (intellectronica)]

Very nice branch, great to see these bugs fixed at last. As we discussed IRL, a few very minor comments:

1. The text in the doctest reads nicer if its written consistently in present tense.
2. You can use tal:replace instead of tal:content when including the project title to save an unnecessary span element. Just think what it will do for your carbon footprint!

Finally, I'm not sure turning the search box off if no bugs are filed (on a project that does use LP) is better, because one could argue that it helps to have the UI be consistent, so that it's easy to learn. I don't feel deeply about it, but I suggest maybe running it by Martin or Michael.

review: Approve

[Deryck Hodge (deryck)]

Images for UI review:

http://people.canonical.com/~deryck/project-not-using-lp-new-ui.png
http://people.canonical.com/~deryck/project-using-lp-no-bugs-new-ui.png
http://people.canonical.com/~deryck/project-using-lp-no-bugs-old-ui.png

[Martin Albisetti (beuno)]

review: Approve (ui)

=== added file 'lib/lp/bugs/stories/bugs/xx-front-page-info.txt'
--- lib/lp/bugs/stories/bugs/xx-front-page-info.txt	1970-01-01 00:00:00 +0000
+++ lib/lp/bugs/stories/bugs/xx-front-page-info.txt	2010-01-19 16:41:16 +0000
@@ -0,0 +1,41 @@
+A bugs home page for a project shows different information, depending
+on whether or not the project uses malone for bug tracking.
+
+By default, projects are created without using any bugtracker, malone
+or otherwise.  To demonstrate this, a new project is created.
+
+    >>> from canonical.launchpad.ftests import login, logout
+    >>> login('[e-mail]')
+    >>> test_project = factory.makeProduct(
+    ...     name='test-project', title='Simple Test Project')
+    >>> logout()
+
+The bugs home page for the project states that the project does
+not use Launchpad for bug tracking.
+
+    >>> anon_browser.open('http://bugs.launchpad.dev/test-project')
+    >>> uses_malone_p = find_tag_by_id(anon_browser.contents, 'no-malone')
+    >>> print extract_text(uses_malone_p)
+    Simple Test Project does not use Launchpad for bug tracking.
+
+The bugs home page for a project using Launchpad for bug tracking
+shows controls for setting bug supervisor and states that no
+bugs have been filed.
+
+    >>> login('[e-mail]')
+    >>> uses_malone = factory.makeProduct(
+    ...     name='uses-malone', title='Project Uses Malone',
+    ...     official_malone=True)
+    >>> logout()
+
+    >>> anon_browser.open('http://bugs.launchpad.dev/uses-malone')
+    >>> bug_supervisor = find_tag_by_id(
+    ...     anon_browser.contents, 'bug-supervisor')
+    >>> print extract_text(bug_supervisor)
+    Bug supervisor:
+    None set
+
+    >>> bug_list = find_tag_by_id(
+    ...     anon_browser.contents, 'no-bugs-filed')
+    >>> print extract_text(bug_list)
+    There are currently no bugs filed against Project Uses Malone.

=== modified file 'lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt'
--- lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt	2009-08-17 16:41:22 +0000
+++ lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt	2010-01-19 16:41:16 +0000
@@ -25,24 +25,8 @@
   >>> print anon_browser.getLink("hoary").url
   http://bugs.launchpad.dev/ubuntu/hoary/+bugs
 
-The same portlet is available on the bugs homepage for the distro:
-
-  >>> anon_browser.open("http://bugs.launchpad.dev/debian/+bugs-index")
-  >>> portlet = find_portlet(anon_browser.contents, "Series-targeted bugs")
-  >>> print extract_text(portlet)
-  Series-targeted bugs
-  sarge 1
-  woody 2
-
-  >>> anon_browser.open("http://bugs.launchpad.dev/debian/sarge/+bugs-index")
-  >>> portlet = find_portlet(anon_browser.contents, "Series-targeted bugs")
-  >>> print extract_text(portlet)
-  Series-targeted bugs
-  sarge 1
-  woody 2
-
-It's also available for project and project series listings and
-homepages:
+The same portlet is also available for project and project series
+listings and homepages:
 
   >>> anon_browser.open("http://bugs.launchpad.dev/firefox/+bugs")
   >>> portlet = find_portlet(anon_browser.contents, "Series-targeted bugs")

=== modified file 'lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt'
--- lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt	2009-12-15 03:25:42 +0000
+++ lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt	2010-01-19 16:41:16 +0000
@@ -44,21 +44,6 @@
     1 Firefox does not support SVG
       Low New
 
-The page displays the number of bugs that need forwarding upstream for
-products that do not use malone. See xx-product-pending-bugwatch for
-more explanation of why this link is present, and how it is used.
-
-    >>> anon_browser.goBack(1)
-    >>> need_forwarding_bugs_link = anon_browser.getLink(
-    ...     'Bugs need forwarding upstream')
-    Traceback (most recent call last):
-    ...
-    LinkNotFoundError
-
-    >>> anon_browser.open('http://bugs.launchpad.dev/alsa-utils')
-    >>> need_forwarding_bugs_link = anon_browser.getLink(
-    ...     'Bugs need forwarding upstream')
-
 
 == Bugs Fixed Elsewhere ==
 
@@ -80,24 +65,6 @@
     <p>There are currently no open bugs.</p>
     ...
 
-This also works for products not using Launchpad Bugs directly. For
-example users can see all bugs raised against Mozilla Thunderbird that
-are fixed in some other context:
-
-    >>> anon_browser.open('http://bugs.launchpad.dev/thunderbird')
-    >>> fixed_elsewhere_link = anon_browser.getLink('Bugs fixed elsewhere')
-
-Again, the link takes you to the list of the bugs fixed elsewhere.:
-
-    >>> fixed_elsewhere_link.click()
-    >>> anon_browser.url
-    'http://.../+bugs?field.status_upstream=resolved_upstream'
-
-    >>> print find_main_content(anon_browser.contents)
-    <...
-    <p>There are currently no open bugs.</p>
-    ...
-
 
 == Expirable Bugs ==
 

=== modified file 'lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt'
--- lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt	2009-10-02 15:16:03 +0000
+++ lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt	2010-01-19 16:41:16 +0000
@@ -8,20 +8,6 @@
 locate the bugs that need a bugwatch setup.
 
 
-== Common searches on a product's bug page (part 1) ==
-
-No Privileges Person visits the alsa-utils front page on Launchpad.
-He wants to link Launchpad bugs to to the upstream bug tracker. He can
-see that there are '0 bugs need forwarding upstream'.
-
-    >>> user_browser.open('http://bugs.launchpad.dev/alsa-utils/')
-    >>> user_browser.title
-    'Bugs in ALSA utilities'
-
-    >>> pending_watches_link = user_browser.getLink(
-    ...     'Bugs fixed elsewhere')
-
-
 == Marking and searching for pending bugwatches ==
 
 Sample Person is doing some bug reporting and triage for his adopted
@@ -50,8 +36,7 @@
 chooses to search for all bugs that need to be forwarded upstream.
 He sees one match.
 
-    >>> browser.open('http://bugs.launchpad.dev/alsa-utils/')
-    >>> browser.getLink('Advanced search').click()
+    >>> browser.open('http://bugs.launchpad.dev/alsa-utils/+bugs?advanced=1')
     >>> pending_bugwatch_label = (
     ...     'Show bugs that need to be forwarded to an upstream '
     ...     'bug tracker')
@@ -61,23 +46,3 @@
     >>> print extract_text(bug_listing)
     Summary        Importance  Status
     ...Test Bug 1  Undecided   New
-
-
-== Common searches on a product's bug page (part 2) ==
-
-No Privileges Person returns to the alsa-utils front page on Launchpad.
-He wants to link bugs to to the upstream bug tracker.
-
-    >>> user_browser.open('http://bugs.launchpad.dev/alsa-utils/')
-    >>> user_browser.title
-    'Bugs in ALSA utilities'
-
-    >>> pending_watches_link = user_browser.getLink(
-    ...     'Bugs need forwarding upstream')
-    >>> pending_watches_link.click()
-
-    >>> bug_listing = find_tag_by_id(user_browser.contents, 'buglisting')
-    >>> print extract_text(bug_listing)
-    Summary        Importance  Status
-    ...Test Bug 1  Undecided   New
-

=== modified file 'lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt'
--- lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt	2009-11-12 15:33:27 +0000
+++ lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt	2010-01-19 16:41:16 +0000
@@ -110,11 +110,37 @@
     >>> sample_browser.url
     'http://launchpad.dev/testy'
 
+By default, a newly created project doesn't use Launchpad for bug
+tracking, and none of the bug lists or edit controls will be
+available.
+
+    >>> sample_browser.getLink('Bugs').click()
+    >>> uses_malone_p = find_tag_by_id(sample_browser.contents, 'no-malone')
+    >>> print extract_text(uses_malone_p)
+    A product for testing things does not use Launchpad for bug tracking.
+
+We can change the settings to use Launchpad for bug tracking.
+
+    >>> sample_browser.getLink(
+    ...     'Enable bug tracking.').click()
+    >>> print sample_browser.title
+    Change A product for testing things's details : Bugs : Test Product
+    >>> sample_browser.getControl('In Launchpad').click()
+    >>> sample_browser.getControl('Change').click()
+
+Now, information about bug tracking (bug supervisor, security contact)
+and their edit controls are available on the page.
+
+    >>> bug_supervisor = find_tag_by_id(
+    ...     sample_browser.contents, 'bug-supervisor')
+    >>> print extract_text(bug_supervisor)
+    Bug supervisor:
+    None set
+
 Sample Person is a member of "Warty Security Team".  However, he should not be
 able to set Warty Security Team as a bug supervisor for Test Project as he's
 not an admin of that team.
 
-    >>> sample_browser.getLink('Bugs').click()
     >>> sample_browser.getLink('Change bug supervisor').click()
     >>> sample_browser.url
     'http://bugs.launchpad.dev/testy/+bugsupervisor'

=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
--- lib/lp/bugs/templates/bugtarget-bugs.pt	2009-12-19 19:12:34 +0000
+++ lib/lp/bugs/templates/bugtarget-bugs.pt	2010-01-19 16:41:16 +0000
@@ -14,7 +14,7 @@
     <script type="text/javascript" src="/+icing/PlotKit_Packed.js"></script>
   </metal:block>
   <body>
-    <tal:side metal:fill-slot="side">
+    <tal:side metal:fill-slot="side" condition="view/uses_launchpad_bugtracker">
       <div id="involvement" class="portlet involvement">
         <ul>
           <li style="border: none">
@@ -45,94 +45,114 @@
          tal:define="search_url string:+bugs;
                      advanced_search_url string:+bugs?advanced=1">
 
-      <div class="portlet" style="float: right; border: none">
-        <ul>
-          <li id="bugtracker" tal:condition="not: view/uses_launchpad_bugtracker">
-            <strong>Bug tracker:</strong><br />
-            <span style="margin-left: 1em">
-              <tal:bugtracker replace="structure view/bugtracker" />
-            </span>
-          </li>
-          <li tal:define="bug_supervisor context/bug_supervisor">
-            Bug supervisor:<br />
-            <span style="margin-left: 1em">
-              <tal:none condition="not:bug_supervisor">None set</tal:none>
-              <a tal:condition="bug_supervisor"
-                 tal:replace="structure bug_supervisor/fmt:link">Bob Johnson</a>
-              <tal:edit-bug-supervisor
-                  condition="context/menu:bugs/bugsupervisor|nothing">
-                <a tal:define="link context/menu:bugs/bugsupervisor"
-                   tal:condition="link/enabled"
-                   tal:attributes="href link/url; title link/text">
-                  <img tal:attributes="alt link/text" src="/@@/edit" />
-                </a> 
-              </tal:edit-bug-supervisor>
-            </span>
-          </li>
-          <li tal:define="securitycontact context/security_contact">
-            Security contact:<br />
-            <span style="margin-left: 1em">
-              <tal:none condition="not:securitycontact">None set</tal:none>
-              <a tal:condition="securitycontact"
-                 tal:replace="structure securitycontact/fmt:link">
-                Billy Anderson
-              </a>
-              <tal:edit-securitycontact
-                  condition="context/menu:bugs/securitycontact|nothing">
-                <a tal:define="link context/menu:bugs/securitycontact"
-                   tal:condition="link/enabled"
-                   tal:attributes="href link/url; title link/text">
-                  <img tal:attributes="alt link/text" src="/@@/edit" />
+      <tal:uses_malone condition="view/uses_launchpad_bugtracker">
+        <div class="portlet" style="float: right; border: none">
+          <ul>
+            <li id="bugtracker" tal:condition="not: view/uses_launchpad_bugtracker">
+              <strong>Bug tracker:</strong><br />
+              <span style="margin-left: 1em">
+                <tal:bugtracker replace="structure view/bugtracker" />
+              </span>
+            </li>
+            <li id="bug-supervisor"
+                tal:define="bug_supervisor context/bug_supervisor">
+              Bug supervisor:<br />
+              <span style="margin-left: 1em">
+                <tal:none condition="not:bug_supervisor">None set</tal:none>
+                <a tal:condition="bug_supervisor"
+                   tal:replace="structure bug_supervisor/fmt:link">Bob Johnson</a>
+                <tal:edit-bug-supervisor
+                    condition="context/menu:bugs/bugsupervisor|nothing">
+                  <a tal:define="link context/menu:bugs/bugsupervisor"
+                     tal:condition="link/enabled"
+                     tal:attributes="href link/url; title link/text">
+                    <img tal:attributes="alt link/text" src="/@@/edit" />
+                  </a> 
+                </tal:edit-bug-supervisor>
+              </span>
+            </li>
+            <li id="bug-security"
+                tal:define="securitycontact context/security_contact">
+              Security contact:<br />
+              <span style="margin-left: 1em">
+                <tal:none condition="not:securitycontact">None set</tal:none>
+                <a tal:condition="securitycontact"
+                   tal:replace="structure securitycontact/fmt:link">
+                  Billy Anderson
                 </a>
-              </tal:edit-securitycontact>
-            </span>
-          </li>
-          <li>
-          </li>
-        </ul>
-      </div>
-
-      <div class="search-box">
-        <metal:search
-          use-macro="context/@@+bugtarget-macros-search/simple-search-form"
-        />
-      </div>
-      <script type="text/javascript"><!--
-           $('field.searchtext').focus();
-      --></script>
-
-      <h2 style="margin-top: 1em">Hot bugs</h2>
-
-      <table class="listing" id="hot-bugs">
-        <thead>
-          <tr>
-            <th colspan="3">Summary</th>
-            <th>Status</th>
-            <th>Importance</th>
-            <th>Last changed</th>
-          </tr>
-        </thead>
-        <tbody>
-          <tr tal:repeat="bugtask view/hot_bugtasks">
-            <td class="icon left">
-              <img alt="" src="/@@/bug" />
-            </td>
-            <td style="text-align: right">
-              #<span tal:replace="bugtask/bug/id" />
-            </td>
-            <td>
-              <a tal:attributes="href bugtask/fmt:url"
-                 tal:content="bugtask/bug/title" />
-            </td>
-            <td tal:attributes="class string:status${bugtask/status/name}"
-                tal:content="bugtask/status/title" />
-            <td tal:attributes="
-                  class string:importance${bugtask/importance/name}"
-                tal:content="bugtask/importance/title" />
-            <td tal:content="bugtask/bug/date_last_updated/fmt:displaydate" />
-          </tr>
-        </tbody>
-      </table>
+                <tal:edit-securitycontact
+                    condition="context/menu:bugs/securitycontact|nothing">
+                  <a tal:define="link context/menu:bugs/securitycontact"
+                     tal:condition="link/enabled"
+                     tal:attributes="href link/url; title link/text">
+                    <img tal:attributes="alt link/text" src="/@@/edit" />
+                  </a>
+                </tal:edit-securitycontact>
+              </span>
+            </li>
+            <li>
+            </li>
+          </ul>
+        </div>
+
+      <tal:has_hot_bugs condition="view/hot_bugtasks">
+        <div class="search-box">
+          <metal:search
+            use-macro="context/@@+bugtarget-macros-search/simple-search-form"
+          />
+        </div>
+        <script type="text/javascript"><!--
+             $('field.searchtext').focus();
+        --></script>
+
+        <h2 style="margin-top: 1em">Hot bugs</h2>
+
+        <table class="listing" id="hot-bugs">
+          <thead>
+            <tr>
+              <th colspan="3">Summary</th>
+              <th>Status</th>
+              <th>Importance</th>
+              <th>Last changed</th>
+            </tr>
+          </thead>
+          <tbody>
+            <tr tal:repeat="bugtask view/hot_bugtasks">
+              <td class="icon left">
+                <img alt="" src="/@@/bug" />
+              </td>
+              <td style="text-align: right">
+                #<span tal:replace="bugtask/bug/id" />
+              </td>
+              <td>
+                <a tal:attributes="href bugtask/fmt:url"
+                   tal:content="bugtask/bug/title" />
+              </td>
+              <td tal:attributes="class string:status${bugtask/status/name}"
+                  tal:content="bugtask/status/title" />
+              <td tal:attributes="
+                    class string:importance${bugtask/importance/name}"
+                  tal:content="bugtask/importance/title" />
+              <td tal:content="bugtask/bug/date_last_updated/fmt:displaydate" />
+            </tr>
+          </tbody>
+        </table>
+      </tal:has_hot_bugs>
+
+      <tal:no_hot_bugs condition="not: view/hot_bugtasks">
+        <p id="no-bugs-filed"><strong>There are currently no bugs filed against
+          <tal:project_title replace="context/title" />.</strong></p>
+
+        <p id="no-bugs-report"><a href="+filebug">Report a bug.</a></p>
+      </tal:no_hot_bugs>
+    </tal:uses_malone>
+
+    <tal:not_uses_malone condition="not: view/uses_launchpad_bugtracker">
+      <p id="no-malone"><strong><tal:project_title replace="context/title" /> does not use Launchpad for
+        bug tracking.</strong></p>
+
+      <p id="no-malone-edit"><a href="+edit">Enable bug tracking.</a></p>
+    </tal:not_uses_malone>
 
     </div><!-- main -->
   </body>