Merge lp:~deryck/launchpad/max-heat-by-target-511382 into lp:launchpad/db-devel

[Deryck Hodge]

Add a max_heat attribute to each bug target.

[Deryck Hodge (deryck)]

This is the first step in fixing Bug #511382. This branch provides a max_heat attribute on bug targets and a setMaxHeat method. This branch includes the DB patch and a test to exercise the new attribute on each bug target.

I did a implementation call with Björn to make sure the approach was sane.

To run the test:

./bin/test -cvvt test_bugheat

The branch doesn't use max_heat yet. This branch is only to provide the DB changes. A later branch will need to be provided to update this value in an offline-run script and then convert the icon view to use a target's max_heat, rather than the constant MAX_HEAT.

[Stuart Bishop (stub)]

Will Launchpad have other heat in the future? If so, the column needs to be called max_bug_heat to avoid future name conflicts.

Is 0 a sane default? For heat calculations, I imagine this could lead to division by zero errors. If there is no sane default and the heat calculations explicitly checks for '0', we should just use NULL instead.

Otherwise fine. Allocated number is patch-2207-34-0.sql.

Rather than write a new script to update the max heat cache, I think it would be better to add a new task to garbo-daily.py. This provides infrastructure to do the updates in a database friendly manner (with DBLoopTuner), and test infrastructure to speed up writing your tests.

review: Needs Information (db)

[Björn Tillenius (bjornt)]

I have the same questions as Stuart. For now I think it would be better to call it max_bug_heat to avoid confusion. If we add heat to other things, we can rename it, if we want the heat to be shared.

I also think that NULL should be used to define that heat hasn't been calculated yet, unless using 0 makes things easier. Does it? (Using 0 to have a special value is a bit of a hack, when you are restricted to integer values only.)

I have another question as well, though. You have max_heat for Distribution, DistroSeries, and DistributionSourcePackage. Why not DistroSeriesSourcePackage? Is it necessary to go into the *Series level, or could they just delegate to their non-series counterparts?

review: Needs Information (db)

[Deryck Hodge (deryck)]

I'll update the patch and code to use max_bug_heat, that makes sense. I'm also fine to use NULL; again that makes sense. Thanks for the reviews!

I'll fix the branch now and follow up with Björn on IRC about the DistroSeriesSourcePackage question to make sure I understand what is being asked there.

Cheers,
deryck

[Deryck Hodge (deryck)]

Okay, I've updated based on the recommendations here.

I talked to Björn and after a long discussion on IRC came to the conclusion to have max_bug_heat on Product, Project, Distribution, and DistributionSourcePackage. The series versions of these will delegate to those objects.

Does this look good to you guys?

Cheers,
deryck

[Stuart Bishop (stub)]

db patch looks good.

review: Approve (db)

[Eleanor Berger (intellectronica)]

As we discussed on IRC, it will be safer to avoid having a setter for DSP.max_bug_heat, since it uses the distro's value. With that change, r=me.

review: Approve

[Björn Tillenius (bjornt)]

review: Approve (db)

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2010-02-23 15:43:49 +0000
+++ database/schema/comments.sql	2010-02-26 05:16:22 +0000
@@ -461,7 +461,7 @@
 
 COMMENT ON TABLE DistributionSourcePackage IS 'Representing a sourcepackage in a distribution across all distribution series.';
 COMMENT ON COLUMN DistributionSourcePackage.bug_reporting_guidelines IS 'Guidelines to the end user for reporting bugs on a particular a source package in a distribution.';
-
+COMMENT ON COLUMN DistributionSourcePackage.max_bug_heat IS 'The highest heat value across bugs for this source package.';
 
 -- DistributionSourcePackageCache
 
@@ -475,7 +475,6 @@
 COMMENT ON COLUMN DistributionSourcePackageCache.changelog IS 'A concatenation of the source package release changelogs for this source package, where the status is not REMOVED.';
 COMMENT ON COLUMN DistributionSourcePackageCache.archive IS 'The archive where the source is published.';
 
-
 -- DistroSeriesPackageCache
 
 COMMENT ON TABLE DistroSeriesPackageCache IS 'A cache of the text associated with binary packages in the distroseries. This table allows for fast queries to find a binary packagename that matches a given text.';
@@ -612,6 +611,7 @@
 COMMENT ON COLUMN Product.reviewer_whiteboard IS 'A whiteboard for Launchpad admins, registry experts and the project owners to capture the state of current issues with the project.';
 COMMENT ON COLUMN Product.license_approved IS 'The Other/Open Source license has been approved by an administrator.';
 COMMENT ON COLUMN Product.remote_product IS 'The ID of this product on its remote bug tracker.';
+COMMENT ON COLUMN Product.max_bug_heat IS 'The highest heat value across bugs for this product.';
 
 -- ProductLicense
 COMMENT ON TABLE ProductLicense IS 'The licenses that cover the software for a product.';
@@ -703,6 +703,7 @@
 COMMENT ON COLUMN Project.logo IS 'The library file alias of a smaller version of this product''s mugshot.';
 COMMENT ON COLUMN Project.bug_reporting_guidelines IS 'Guidelines to the end user for reporting bugs on products in this project.';
 COMMENT ON COLUMN Project.reviewer_whiteboard IS 'A whiteboard for Launchpad admins, registry experts and the project owners to capture the state of current issues with the project.';
+COMMENT ON COLUMN Project.max_bug_heat IS 'The highest heat value across bugs for products in this project.';
 
 -- ProjectRelationship
 COMMENT ON TABLE ProjectRelationship IS 'Project Relationships. This table stores information about the way projects are related to one another in the open source world. The actual nature of the relationship is stored in the ''label'' field, and possible values are given by the ProjectRelationship enum in dbschema.py. Examples are AGGREGATES ("the Gnome Project AGGREGATES EOG and Evolution and Gnumeric and AbiWord") and SIMILAR ("the Evolution project is SIMILAR to the Mutt project").';
@@ -966,6 +967,7 @@
 COMMENT ON COLUMN Distribution.enable_bug_expiration IS 'Indicates whether automatic bug expiration is enabled.';
 COMMENT ON COLUMN Distribution.bug_reporting_guidelines IS 'Guidelines to the end user for reporting bugs on this distribution.';
 COMMENT ON COLUMN Distribution.reviewer_whiteboard IS 'A whiteboard for Launchpad admins, registry experts and the project owners to capture the state of current issues with the project.';
+COMMENT ON COLUMN Distribution.max_bug_heat IS 'The highest heat value across bugs for this distribution.';
 
 -- DistroSeries
 

=== added file 'database/schema/patch-2207-34-0.sql'
--- database/schema/patch-2207-34-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2207-34-0.sql	2010-02-26 05:16:22 +0000
@@ -0,0 +1,11 @@
+-- Copyright 2010 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE product ADD COLUMN max_bug_heat integer;
+ALTER TABLE project ADD COLUMN max_bug_heat integer;
+ALTER TABLE distribution ADD COLUMN max_bug_heat integer;
+ALTER TABLE distributionsourcepackage ADD COLUMN max_bug_heat integer;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2207, 34, 0);

=== modified file 'lib/lp/bugs/browser/bug.py'
--- lib/lp/bugs/browser/bug.py	2010-02-02 17:26:53 +0000
+++ lib/lp/bugs/browser/bug.py	2010-02-26 05:16:22 +0000
@@ -10,7 +10,6 @@
     'BugContextMenu',
     'BugEditView',
     'BugFacets',
-    'BugHeatView',
     'BugMarkAsAffectingUserView',
     'BugMarkAsDuplicateView',
     'BugNavigation',
@@ -23,13 +22,11 @@
     'BugWithoutContextView',
     'DeprecatedAssignedBugsView',
     'MaloneView',
-    'MAX_HEAT',
     ]
 
 from datetime import datetime, timedelta
 from email.MIMEMultipart import MIMEMultipart
 from email.MIMEText import MIMEText
-from math import floor
 import re
 
 import pytz
@@ -77,10 +74,6 @@
 from canonical.widgets.bug import BugTagsWidget
 from canonical.widgets.project import ProjectScopeWidget
 
-# Constant for the maximum bug heat we'll use for converting
-# IBug.heat to ratio. In the future this should come from the DB.
-# The value must be a float
-MAX_HEAT = 5000.0
 
 class BugNavigation(Navigation):
     """Navigation for the `IBug`."""
@@ -969,18 +962,3 @@
         return html.encode('utf-8')
     return renderer
 
-
-class BugHeatView(LaunchpadView):
-    """View for rendering the graphical (HTML) representation of bug heat."""
-
-    def __call__(self):
-        """Render the bug heat representation."""
-        heat_ratio = floor((self.context.heat / MAX_HEAT) * 4)
-        html = '<span>'
-        for flame in range(1, 5):
-            if flame <= heat_ratio:
-                html += '<img src="/@@/flame-icon" />'
-            else:
-                html += '<img src="/@@/flame-bw-icon" />'
-        html += '</span>'
-        return html

=== modified file 'lib/lp/bugs/browser/bugtask.py'
--- lib/lp/bugs/browser/bugtask.py	2010-02-25 22:00:26 +0000
+++ lib/lp/bugs/browser/bugtask.py	2010-02-26 05:16:22 +0000
@@ -33,7 +33,9 @@
     'BugTaskTextView',
     'BugTaskView',
     'BugTasksAndNominationsView',
+    'bugtask_heat_html',
     'BugsBugTaskSearchListingView',
+    'calculate_heat_display',
     'NominationsReviewTableBatchNavigatorView',
     'TextualBugTaskSearchListingView',
     'get_buglisting_search_filter_url',
@@ -49,6 +51,7 @@
 from simplejson import dumps
 import urllib
 from operator import attrgetter, itemgetter
+from math import floor, log
 
 from zope import component
 from zope.app.form import CustomWidgetFactory
@@ -1080,10 +1083,35 @@
     @property
     def bug_heat_html(self):
         """HTML representation of the bug heat."""
-        view = getMultiAdapter(
-            (self.context.bug, self.request),
-            name='+bug-heat')
-        return view()
+        return bugtask_heat_html(self.context)
+
+
+def calculate_heat_display(heat, max_bug_heat):
+    """Calculate the number of heat 'flames' to display."""
+    heat = float(heat)
+    max_bug_heat = float(max_bug_heat)
+    if heat / max_bug_heat < 0.33333:
+        return 0
+    if heat / max_bug_heat < 0.66666:
+        return int(floor((heat / max_bug_heat) * 4))
+    else:
+        return int(floor((log(heat) / log(max_bug_heat)) * 4))
+
+
+def bugtask_heat_html(bugtask):
+    """Render the HTML representing bug heat for a given bugask."""
+    max_bug_heat = bugtask.target.max_bug_heat
+    if max_bug_heat is None:
+        max_bug_heat = 5000
+    heat_ratio = calculate_heat_display(bugtask.bug.heat, max_bug_heat)
+    html = '<span>'
+    for flame in range(1, 5):
+        if flame <= heat_ratio:
+            html += '<img src="/@@/flame-icon" />'
+        else:
+            html += '<img src="/@@/flame-bw-icon" />'
+    html += '</span>'
+    return html
 
 
 class BugTaskPortletView:
@@ -1967,10 +1995,7 @@
     @property
     def bug_heat_html(self):
         """Returns the bug heat flames HTML."""
-        view = getMultiAdapter(
-            (self.bugtask.bug, self.request),
-            name='+bug-heat')
-        return view()
+        return bugtask_heat_html(self.bugtask)
 
 
 class BugListingBatchNavigator(TableBatchNavigator):

=== modified file 'lib/lp/bugs/browser/configure.zcml'
--- lib/lp/bugs/browser/configure.zcml	2010-02-20 13:16:38 +0000
+++ lib/lp/bugs/browser/configure.zcml	2010-02-26 05:16:22 +0000
@@ -1044,11 +1044,6 @@
             name="+bug-portlet-subscribers-ids"
             class="lp.bugs.browser.bugsubscription.BugPortletSubcribersIds"
             permission="zope.Public"/>
-        <browser:page
-            for="lp.bugs.interfaces.bug.IBug"
-            class="lp.bugs.browser.bug.BugHeatView"
-            permission="zope.Public"
-            name="+bug-heat"/>
         <browser:navigation
             module="lp.bugs.browser.bug"
             classes="

=== modified file 'lib/lp/bugs/browser/tests/bug-heat-view.txt'
--- lib/lp/bugs/browser/tests/bug-heat-view.txt	2010-01-18 22:11:00 +0000
+++ lib/lp/bugs/browser/tests/bug-heat-view.txt	2010-02-26 05:16:22 +0000
@@ -1,15 +1,16 @@
 = Bug heat view =
 
 Bug heat is represented as four flame icons. The quantity of flames that are
-coloured is dependent on the value of the heat field. The view BugHeatView
-is used to render the flames.
+coloured is dependent on the value of the heat field. The function
+bugtask_heat_html is used to render the flames.
 
-    >>> from lp.bugs.browser.bug import MAX_HEAT
+    >>> MAX_HEAT = 5000.0
     >>> from canonical.launchpad.ftests import login, logout
-    >>> from canonical.launchpad.webapp import canonical_url
     >>> from zope.security.proxy import removeSecurityProxy
     >>> from BeautifulSoup import BeautifulSoup
-    >>> def print_flames(html):
+    >>> from lp.bugs.browser.bugtask import bugtask_heat_html
+    >>> def print_flames(bugtask):
+    ...     html = bugtask_heat_html(bugtask)
     ...     soup = BeautifulSoup(html)
     ...     for img in soup.span.contents:
     ...         print img['src']
@@ -20,9 +21,9 @@
 a heat of half the maximum will result in a display of two coloured flames
 and two black-and-white flames.
 
+    >>> removeSecurityProxy(bug.default_bugtask.target).max_bug_heat = MAX_HEAT
     >>> removeSecurityProxy(bug).heat = MAX_HEAT / 2
-    >>> bug_heat_view = create_initialized_view(bug, name='+bug-heat')
-    >>> print_flames(bug_heat_view())
+    >>> print_flames(bug.default_bugtask)
     /@@/flame-icon
     /@@/flame-icon
     /@@/flame-bw-icon
@@ -31,8 +32,7 @@
 A bug with a maximum heat will display all four flames coloured.
 
     >>> removeSecurityProxy(bug).heat = MAX_HEAT
-    >>> bug_heat_view = create_initialized_view(bug, name='+bug-heat')
-    >>> print_flames(bug_heat_view())
+    >>> print_flames(bug.default_bugtask)
     /@@/flame-icon
     /@@/flame-icon
     /@@/flame-icon
@@ -41,11 +41,44 @@
 A heat of less than a quarter of the maximum will display no coloured flames.
 
     >>> removeSecurityProxy(bug).heat = 0.1 * MAX_HEAT
-    >>> bug_heat_view = create_initialized_view(bug, name='+bug-heat')
-    >>> print_flames(bug_heat_view())
+    >>> print_flames(bug.default_bugtask)
     /@@/flame-bw-icon
     /@@/flame-bw-icon
     /@@/flame-bw-icon
     /@@/flame-bw-icon
 
     >>> logout()
+
+
+== Scaling Bug Heat ==
+
+To ensure a reasonable proportion of cold and hot bugs, the number used to
+calculate the number of flames to display is not a straight-forward ratio.
+Instead, we transform it by forcing low heat bugs to produce no flames and
+scaling the hottest bugs logarithmically.
+
+    >>> from lp.bugs.browser.bugtask import calculate_heat_display
+    >>> from math import floor
+
+Heat values less than a third of the maximum heat don't produce any flames.
+
+    >>> print int(floor((300.0 / 1000.0) * 4))
+    1
+    >>> print calculate_heat_display(300.0, 1000.0)
+    0
+
+Heat values higher than a third of the max but lower than two thirds are treated
+as a straightforward ratio.
+
+    >>> print int(floor((500.0 / 1000.0) * 4))
+    2
+    >>> print calculate_heat_display(500.0, 1000.0)
+    2
+
+Heat values higher than two thirds of the maximum heat are scaled upwards.
+
+    >>> print int(floor((700.0 / 1000.0) * 4))
+    2
+    >>> print calculate_heat_display(800.0, 1000.0)
+    3
+

=== modified file 'lib/lp/bugs/interfaces/bug.py'
--- lib/lp/bugs/interfaces/bug.py	2010-02-23 15:34:15 +0000
+++ lib/lp/bugs/interfaces/bug.py	2010-02-26 05:16:22 +0000
@@ -15,6 +15,7 @@
     'IBugBecameQuestionEvent',
     'IBugDelta',
     'IBugSet',
+    'IFileBugData',
     'IFrontPageBugAddForm',
     'IProjectGroupBugAddForm',
     'InvalidBugTargetType',

=== modified file 'lib/lp/bugs/interfaces/bugtarget.py'
--- lib/lp/bugs/interfaces/bugtarget.py	2010-02-25 22:00:26 +0000
+++ lib/lp/bugs/interfaces/bugtarget.py	2010-02-26 05:16:22 +0000
@@ -61,6 +61,8 @@
         description=_("The list of bug tags defined as official."),
         value_type=Tag(),
         readonly=True))
+    max_bug_heat = Attribute(
+        "The current highest bug heat value for this target.")
 
     @call_with(search_params=None, user=REQUEST_USER)
     @operation_parameters(
@@ -219,6 +221,9 @@
                        None, all statuses will be included.
         """
 
+    def setMaxBugHeat(heat):
+        """Set the max_bug_heat for this context."""
+
 
 class IBugTarget(IHasBugs):
     """An entity on which a bug can be reported.

=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py	2010-02-19 16:39:25 +0000
+++ lib/lp/bugs/model/bug.py	2010-02-26 05:16:22 +0000
@@ -13,6 +13,7 @@
     'BugBecameQuestionEvent',
     'BugSet',
     'BugTag',
+    'FileBugData',
     'get_bug_tags',
     'get_bug_tags_open_count',
     ]

=== modified file 'lib/lp/bugs/model/bugtarget.py'
--- lib/lp/bugs/model/bugtarget.py	2010-02-25 22:00:26 +0000
+++ lib/lp/bugs/model/bugtarget.py	2010-02-26 05:16:22 +0000
@@ -25,7 +25,10 @@
 from canonical.launchpad.webapp.interfaces import ILaunchBag
 from lp.bugs.interfaces.bugtarget import IOfficialBugTag
 from lp.registry.interfaces.distribution import IDistribution
+from lp.registry.interfaces.distributionsourcepackage import (
+    IDistributionSourcePackage)
 from lp.registry.interfaces.product import IProduct
+from lp.registry.interfaces.projectgroup import IProjectGroup
 from lp.bugs.interfaces.bugtask import (
     BugTagsSearchCombinator, BugTaskImportance, BugTaskSearchParams,
     BugTaskStatus, RESOLVED_BUGTASK_STATUSES, UNRESOLVED_BUGTASK_STATUSES)
@@ -156,6 +159,17 @@
 
         return self.searchTasks(all_tasks_query)
 
+    def setMaxBugHeat(self, heat):
+        """See `IHasBugs`."""
+        if (IDistribution.providedBy(self)
+            or IProduct.providedBy(self)
+            or IProjectGroup.providedBy(self)
+            or IDistributionSourcePackage.providedBy(self)):
+            # Only objects that don't delegate have a setter.
+            self.max_bug_heat = heat
+        else:
+            raise NotImplementedError
+
     def getBugCounts(self, user, statuses=None):
         """See `IHasBugs`."""
         if statuses is None:

=== modified file 'lib/lp/bugs/tests/test_bugheat.py'
--- lib/lp/bugs/tests/test_bugheat.py	2010-01-21 22:59:32 +0000
+++ lib/lp/bugs/tests/test_bugheat.py	2010-02-26 05:16:22 +0000
@@ -20,6 +20,7 @@
 from lp.bugs.model.bugheat import CalculateBugHeatJob
 from lp.bugs.scripts.bugheat import BugHeatCalculator
 from lp.testing import TestCaseWithFactory
+from lp.testing.factory import LaunchpadObjectFactory
 
 
 class CalculateBugHeatJobTestCase(TestCaseWithFactory):
@@ -214,5 +215,86 @@
         self.assertEqual(bug_job.bug, new_bug)
 
 
+class MaxHeatByTargetBase:
+    """Base class for testing a bug target's max_bug_heat attribute."""
+
+    layer = LaunchpadZopelessLayer
+
+    factory = LaunchpadObjectFactory()
+
+    # The target to test.
+    target = None
+
+    # Does the target have a set method?
+    delegates_setter = False
+
+    def test_target_max_bug_heat_default(self):
+        self.assertEqual(self.target.max_bug_heat, None)
+
+    def test_set_target_max_bug_heat(self):
+        if self.delegates_setter:
+            self.assertRaises(
+                NotImplementedError, self.target.setMaxBugHeat, 1000)
+        else:
+            self.target.setMaxBugHeat(1000)
+            self.assertEqual(self.target.max_bug_heat, 1000)
+
+
+class ProjectMaxHeatByTargetTest(MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a project has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeProduct()
+
+
+class DistributionMaxHeatByTargetTest(MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a distribution has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeDistribution()
+
+
+class DistributionSourcePackageMaxHeatByTargetTest(
+    MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure distro source package has max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeDistributionSourcePackage()
+
+
+class SourcePackageMaxHeatByTargetTest(
+    MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a source package has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeSourcePackage()
+        self.delegates_setter = True
+
+
+class ProductSeriesMaxHeatByTargetTest(
+    MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a product series has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeProductSeries()
+        self.delegates_setter = True
+
+
+class DistroSeriesMaxHeatByTargetTest(
+    MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a distro series has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeDistroSeries()
+        self.delegates_setter = True
+
+
+class ProjectGroupMaxHeatByTargetTest(
+    MaxHeatByTargetBase, unittest.TestCase):
+    """Ensure a project group has a max_bug_heat value that can be set."""
+
+    def setUp(self):
+        self.target = self.factory.makeProject()
+
 def test_suite():
     return unittest.TestLoader().loadTestsFromName(__name__)

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2010-02-18 09:04:51 +0000
+++ lib/lp/registry/configure.zcml	2010-02-26 05:16:22 +0000
@@ -407,7 +407,8 @@
                 official_bug_tags
                 findRelatedArchives
                 findRelatedArchivePublications
-                userHasBugSubscriptions"/>
+                userHasBugSubscriptions
+                max_bug_heat"/>
         <require
             permission="launchpad.AnyPerson"
             attributes="

=== modified file 'lib/lp/registry/model/distribution.py'
--- lib/lp/registry/model/distribution.py	2010-02-16 15:08:03 +0000
+++ lib/lp/registry/model/distribution.py	2010-02-26 05:16:22 +0000
@@ -13,7 +13,7 @@
 
 from sqlobject import BoolCol, ForeignKey, SQLObjectNotFound, StringCol
 from sqlobject.sqlbuilder import SQLConstant
-from storm.locals import Desc, In, Join, SQL
+from storm.locals import Desc, In, Int, Join, SQL
 from storm.store import Store
 from zope.component import getUtility
 from zope.interface import alsoProvides, implements
@@ -34,7 +34,6 @@
 from lp.soyuz.model.binarypackagename import BinaryPackageName
 from lp.soyuz.model.binarypackagerelease import (
     BinaryPackageRelease)
-from lp.bugs.interfaces.bugattachment import BugAttachmentType
 from lp.bugs.model.bug import (
     BugSet, get_bug_tags, get_bug_tags_open_count)
 from lp.bugs.model.bugtarget import (
@@ -179,6 +178,7 @@
     official_blueprints = BoolCol(dbName='official_blueprints', notNull=True,
         default=False)
     active = True # Required by IPillar interface.
+    max_bug_heat = Int()
 
     def __repr__(self):
         return "<%s '%s' (%s)>" % (

=== modified file 'lib/lp/registry/model/distributionsourcepackage.py'
--- lib/lp/registry/model/distributionsourcepackage.py	2010-01-06 12:03:42 +0000
+++ lib/lp/registry/model/distributionsourcepackage.py	2010-02-26 05:16:22 +0000
@@ -142,6 +142,26 @@
         _get_bug_reporting_guidelines,
         _set_bug_reporting_guidelines)
 
+    def _get_max_bug_heat(self):
+        """See `IHasBugs`."""
+        dsp_in_db = self._self_in_database
+        if dsp_in_db is None:
+            return None
+        else:
+            return dsp_in_db.max_bug_heat
+
+    def _set_max_bug_heat(self, value):
+        """See `IHasBugs`."""
+        dsp_in_db = self._self_in_database
+        if dsp_in_db is None:
+            dsp_in_db = DistributionSourcePackageInDatabase()
+            dsp_in_db.sourcepackagename = self.sourcepackagename
+            dsp_in_db.distribution = self.distribution
+            Store.of(self.distribution).add(dsp_in_db)
+        dsp_in_db.max_bug_heat = value
+
+    max_bug_heat = property(_get_max_bug_heat, _set_max_bug_heat)
+
     @property
     def latest_overall_publication(self):
         """See `IDistributionSourcePackage`."""
@@ -474,3 +494,6 @@
         sourcepackagename_id, 'SourcePackageName.id')
 
     bug_reporting_guidelines = Unicode()
+
+    max_bug_heat = Int()
+

=== modified file 'lib/lp/registry/model/distroseries.py'
--- lib/lp/registry/model/distroseries.py	2010-02-22 20:58:16 +0000
+++ lib/lp/registry/model/distroseries.py	2010-02-26 05:16:22 +0000
@@ -624,6 +624,11 @@
         return self.fullseriesname
 
     @property
+    def max_bug_heat(self):
+        """See `IHasBugs`."""
+        return self.distribution.max_bug_heat
+
+    @property
     def last_full_language_pack_exported(self):
         return LanguagePack.selectFirstBy(
             distroseries=self, type=LanguagePackType.FULL,

=== modified file 'lib/lp/registry/model/product.py'
--- lib/lp/registry/model/product.py	2010-02-09 01:31:05 +0000
+++ lib/lp/registry/model/product.py	2010-02-26 05:16:22 +0000
@@ -18,7 +18,7 @@
 import pytz
 from sqlobject import (
     BoolCol, ForeignKey, SQLMultipleJoin, SQLObjectNotFound, StringCol)
-from storm.locals import And, Desc, Join, SQL, Store, Unicode
+from storm.locals import And, Desc, Int, Join, SQL, Store, Unicode
 from zope.interface import implements
 from zope.component import getUtility
 from zope.security.proxy import removeSecurityProxy
@@ -249,6 +249,7 @@
         dbName='official_rosetta', notNull=True, default=False)
     remote_product = Unicode(
         name='remote_product', allow_none=True, default=None)
+    max_bug_heat = Int()
 
     def _getMilestoneCondition(self):
         """See `HasMilestonesMixin`."""

=== modified file 'lib/lp/registry/model/productseries.py'
--- lib/lp/registry/model/productseries.py	2009-12-13 11:55:40 +0000
+++ lib/lp/registry/model/productseries.py	2010-02-26 05:16:22 +0000
@@ -161,6 +161,11 @@
         return "%s/%s" % (self.product.name, self.name)
 
     @property
+    def max_bug_heat(self):
+        """See `IHasBugs`."""
+        return self.product.max_bug_heat
+
+    @property
     def drivers(self):
         """See IProductSeries."""
         drivers = set()

=== modified file 'lib/lp/registry/model/project.py'
--- lib/lp/registry/model/project.py	2010-02-17 11:19:42 +0000
+++ lib/lp/registry/model/project.py	2010-02-26 05:16:22 +0000
@@ -17,6 +17,7 @@
 from sqlobject import (
     AND, ForeignKey, StringCol, BoolCol, SQLObjectNotFound)
 from storm.expr import And, In, SQL
+from storm.locals import Int
 from storm.store import Store
 
 from canonical.database.sqlbase import SQLBase, sqlvalues, quote
@@ -121,6 +122,7 @@
         foreignKey="BugTracker", dbName="bugtracker", notNull=False,
         default=None)
     bug_reporting_guidelines = StringCol(default=None)
+    max_bug_heat = Int()
 
     # convenient joins
 

=== modified file 'lib/lp/registry/model/sourcepackage.py'
--- lib/lp/registry/model/sourcepackage.py	2010-02-24 13:49:17 +0000
+++ lib/lp/registry/model/sourcepackage.py	2010-02-26 05:16:22 +0000
@@ -443,6 +443,11 @@
                 BugTask.sourcepackagename == self.sourcepackagename),
             user)
 
+    @property
+    def max_bug_heat(self):
+        """See `IHasBugs`."""
+        return self.distribution_sourcepackage.max_bug_heat
+
     def createBug(self, bug_params):
         """See canonical.launchpad.interfaces.IBugTarget."""
         # We don't currently support opening a new bug directly on an