Merge lp:~deryck/launchpad/has-bug-heat-interface-529846 into lp:launchpad

[Deryck Hodge]

Imlement IHasBugHeat interface for targets which can have bug heat.

This branch fixes bug 529846. It creates an IHasBugHeat interface and
makes use of this for bug targets that should have bug heat. It is not
used for IPerson, for example.

There is no functionality changed here; this just cleans up the code a bit.

To test:

./bin/test -cvvt test_bugheat

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/model/distributionsourcepackage.py
  lib/lp/registry/model/project.py
  lib/lp/registry/model/productseries.py
  lib/lp/registry/configure.zcml
  lib/lp/bugs/model/bugtarget.py
  lib/lp/bugs/interfaces/bugtarget.py
  lib/lp/registry/model/sourcepackage.py
  lib/lp/registry/model/product.py
  lib/lp/registry/model/person.py
  lib/lp/registry/model/distroseries.py
  lib/lp/registry/model/distribution.py

[Guilherme Salgado (salgado)]

Looks good to me; just one minor nitpick below

 review approve
 status approved

On Fri, 2010-03-19 at 15:41 +0000, Deryck Hodge wrote:
> === modified file 'lib/lp/bugs/model/bugtarget.py'
> --- lib/lp/bugs/model/bugtarget.py 2010-03-09 15:13:40 +0000
> +++ lib/lp/bugs/model/bugtarget.py 2010-03-19 15:41:50 +0000
> @@ -9,6 +9,7 @@
> __all__ = [
> 'BugTargetBase',
> 'HasBugsBase',
> + 'HasBugHeatMixin',
> 'OfficialBugTag',
> 'OfficialBugTagTargetMixin',
> ]
> @@ -162,8 +163,57 @@
>
> return self.searchTasks(all_tasks_query)
>
> + @property
> + def has_bugtasks(self):
> + """See `IHasBugs`."""
> + # Check efficiently if any bugtasks exist. We should avoid
> + # expensive calls like all_bugtasks.count(). all_bugtasks
> + # returns a storm.SQLObjectResultSet instance, and this
> + # class does not provide methods like is_empty(). But we can
> + # indirectly call SQLObjectResultSet._result_set.is_empty()
> + # by converting all_bugtasks into a boolean object.
> + return bool(self.all_bugtasks)
> +
> + def getBugCounts(self, user, statuses=None):
> + """See `IHasBugs`."""
> + if statuses is None:
> + statuses = BugTaskStatus.items
> + statuses = list(statuses)
> +
> + count_column = """
> + COUNT (CASE WHEN BugTask.status = %s
> + THEN BugTask.id ELSE NULL END)"""
> + select_columns = [count_column % sqlvalues(status)
> + for status in statuses]
> + conditions = [
> + '(%s)' % self._getBugTaskContextClause(),
> + 'BugTask.bug = Bug.id',
> + 'Bug.duplicateof is NULL']
> + privacy_filter = get_bug_privacy_filter(user)
> + if privacy_filter:
> + conditions.append(privacy_filter)
> +
> + cur = cursor()
> + cur.execute(
> + "SELECT %s FROM BugTask, Bug WHERE %s" % (
> + ', '.join(select_columns), ' AND '.join(conditions)))
> + counts = cur.fetchone()
> + return dict(zip(statuses, counts))
> +
> +
> +

One blank line too much here.

> +class BugTargetBase(HasBugsBase):
> + """Standard functionality for IBugTargets.
> +
> + All IBugTargets should inherit from this class.
> + """
> +
> +

--
Guilherme Salgado <email address hidden>

review: Approve

=== modified file 'lib/lp/bugs/interfaces/bugtarget.py'
--- lib/lp/bugs/interfaces/bugtarget.py	2010-03-10 14:14:38 +0000
+++ lib/lp/bugs/interfaces/bugtarget.py	2010-03-24 13:00:54 +0000
@@ -12,6 +12,7 @@
     'BugDistroSeriesTargetDetails',
     'IBugTarget',
     'IHasBugs',
+    'IHasBugHeat',
     'IHasOfficialBugTags',
     'IOfficialBugTag',
     'IOfficialBugTagTarget',
@@ -56,10 +57,8 @@
         "A list of unassigned BugTasks for this target.")
     all_bugtasks = Attribute(
         "A list of all BugTasks ever reported for this target.")
-    max_bug_heat = Attribute(
-        "The current highest bug heat value for this target.")
     has_bugtasks = Attribute(
-        "True if at least one BugTask has ever been reported for this target.")
+        "True if a BugTask has ever been reported for this target.")
 
     @call_with(search_params=None, user=REQUEST_USER)
     @operation_parameters(
@@ -211,13 +210,6 @@
                        None, all statuses will be included.
         """
 
-    def setMaxBugHeat(heat):
-        """Set the max_bug_heat for this context."""
-
-    def recalculateMaxBugHeat():
-        """Recalculate and set the max_bug_heat for this context."""
-
-
 
 class IBugTarget(IHasBugs):
     """An entity on which a bug can be reported.
@@ -257,6 +249,19 @@
     LAZR_WEBSERVICE_EXPORTED)['params']['target'].schema = IBugTarget
 
 
+class IHasBugHeat(Interface):
+    """An entity which has bug heat."""
+
+    max_bug_heat = Attribute(
+        "The current highest bug heat value for this entity.")
+
+    def setMaxBugHeat(heat):
+        """Set the max_bug_heat for this context."""
+
+    def recalculateMaxBugHeat():
+        """Recalculate and set the max_bug_heat for this context."""
+
+
 class BugDistroSeriesTargetDetails:
     """The details of a bug targeted to a specific IDistroSeries.
 

=== modified file 'lib/lp/bugs/model/bugtarget.py'
--- lib/lp/bugs/model/bugtarget.py	2010-03-09 15:13:40 +0000
+++ lib/lp/bugs/model/bugtarget.py	2010-03-24 13:00:54 +0000
@@ -9,6 +9,7 @@
 __all__ = [
     'BugTargetBase',
     'HasBugsBase',
+    'HasBugHeatMixin',
     'OfficialBugTag',
     'OfficialBugTagTargetMixin',
     ]
@@ -162,8 +163,56 @@
 
         return self.searchTasks(all_tasks_query)
 
+    @property
+    def has_bugtasks(self):
+        """See `IHasBugs`."""
+        # Check efficiently if any bugtasks exist. We should avoid
+        # expensive calls like all_bugtasks.count(). all_bugtasks
+        # returns a storm.SQLObjectResultSet instance, and this
+        # class does not provide methods like is_empty(). But we can
+        # indirectly call SQLObjectResultSet._result_set.is_empty()
+        # by converting all_bugtasks into a boolean object.
+        return bool(self.all_bugtasks)
+
+    def getBugCounts(self, user, statuses=None):
+        """See `IHasBugs`."""
+        if statuses is None:
+            statuses = BugTaskStatus.items
+        statuses = list(statuses)
+
+        count_column = """
+            COUNT (CASE WHEN BugTask.status = %s
+                        THEN BugTask.id ELSE NULL END)"""
+        select_columns = [count_column % sqlvalues(status)
+                          for status in statuses]
+        conditions = [
+            '(%s)' % self._getBugTaskContextClause(),
+            'BugTask.bug = Bug.id',
+            'Bug.duplicateof is NULL']
+        privacy_filter = get_bug_privacy_filter(user)
+        if privacy_filter:
+            conditions.append(privacy_filter)
+
+        cur = cursor()
+        cur.execute(
+            "SELECT %s FROM BugTask, Bug WHERE %s" % (
+                ', '.join(select_columns), ' AND '.join(conditions)))
+        counts = cur.fetchone()
+        return dict(zip(statuses, counts))
+
+
+class BugTargetBase(HasBugsBase):
+    """Standard functionality for IBugTargets.
+
+    All IBugTargets should inherit from this class.
+    """
+
+
+class HasBugHeatMixin:
+    """Standard functionality for objects implementing IHasBugHeat."""
+
     def setMaxBugHeat(self, heat):
-        """See `IHasBugs`."""
+        """See `IHasBugHeat`."""
         if (IDistribution.providedBy(self)
             or IProduct.providedBy(self)
             or IProjectGroup.providedBy(self)
@@ -174,7 +223,7 @@
             raise NotImplementedError
 
     def recalculateMaxBugHeat(self):
-        """See `IHasBugs`."""
+        """See `IHasBugHeat`."""
         if IProductSeries.providedBy(self):
             return self.product.recalculateMaxBugHeat()
         if IDistroSeries.providedBy(self):
@@ -239,50 +288,6 @@
         if IProduct.providedBy(self) and self.project is not None:
             self.project.recalculateMaxBugHeat()
 
-    @property
-    def has_bugtasks(self):
-        """See `IHasBugs`."""
-        # Check efficiently if any bugtasks exist. We should avoid
-        # expensive calls like all_bugtasks.count(). all_bugtasks
-        # returns a storm.SQLObjectResultSet instance, and this
-        # class does not provide methods like is_empty(). But we can
-        # indirectly call SQLObjectResultSet._result_set.is_empty()
-        # by converting all_bugtasks into a boolean object.
-        return bool(self.all_bugtasks)
-
-    def getBugCounts(self, user, statuses=None):
-        """See `IHasBugs`."""
-        if statuses is None:
-            statuses = BugTaskStatus.items
-        statuses = list(statuses)
-
-        count_column = """
-            COUNT (CASE WHEN BugTask.status = %s
-                        THEN BugTask.id ELSE NULL END)"""
-        select_columns = [count_column % sqlvalues(status)
-                          for status in statuses]
-        conditions = [
-            '(%s)' % self._getBugTaskContextClause(),
-            'BugTask.bug = Bug.id',
-            'Bug.duplicateof is NULL']
-        privacy_filter = get_bug_privacy_filter(user)
-        if privacy_filter:
-            conditions.append(privacy_filter)
-
-        cur = cursor()
-        cur.execute(
-            "SELECT %s FROM BugTask, Bug WHERE %s" % (
-                ', '.join(select_columns), ' AND '.join(conditions)))
-        counts = cur.fetchone()
-        return dict(zip(statuses, counts))
-
-
-
-class BugTargetBase(HasBugsBase):
-    """Standard functionality for IBugTargets.
-
-    All IBugTargets should inherit from this class.
-    """
 
 
 class OfficialBugTagTargetMixin:

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2010-03-08 09:38:21 +0000
+++ lib/lp/registry/configure.zcml	2010-03-24 13:00:54 +0000
@@ -107,6 +107,8 @@
         <allow
             interface="lp.registry.interfaces.distroseries.IDistroSeriesPublic"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="canonical.launchpad.interfaces.IHasQueueItems"/>
         <allow
             interface="lp.translations.interfaces.translationimportqueue.IHasTranslationImports"/>
@@ -270,6 +272,8 @@
         <allow
             interface="lp.registry.interfaces.projectgroup.IProjectGroupPublic"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="canonical.launchpad.interfaces.IFAQCollection"/>
         <allow
             interface="canonical.launchpad.interfaces.IQuestionCollection"/>
@@ -358,6 +362,8 @@
     <class
         class="lp.registry.model.distributionsourcepackage.DistributionSourcePackage">
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="lp.translations.interfaces.customlanguagecode.IHasCustomLanguageCodes"/>
 
         <allow
@@ -408,9 +414,7 @@
                 official_bug_tags
                 findRelatedArchives
                 findRelatedArchivePublications
-                userHasBugSubscriptions
-                max_bug_heat
-                recalculateMaxBugHeat"/>
+                userHasBugSubscriptions"/>
         <require
             permission="launchpad.AnyPerson"
             attributes="
@@ -1067,6 +1071,8 @@
         <allow
             interface="lp.registry.interfaces.product.IProductPublic"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="lp.translations.interfaces.translationimportqueue.IHasTranslationImports"/>
         <allow
             interface="lp.translations.interfaces.customlanguagecode.IHasCustomLanguageCodes"/>
@@ -1312,6 +1318,8 @@
             permission="launchpad.Edit"
             interface="lp.registry.interfaces.productseries.IProductSeriesEditRestricted"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="lp.translations.interfaces.translationimportqueue.IHasTranslationImports"/>
         <allow
             interface="lp.translations.interfaces.potemplate.IHasTranslationTemplates"/>
@@ -1380,6 +1388,8 @@
         <allow
             interface="lp.registry.interfaces.distribution.IDistributionPublic"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="lp.translations.interfaces.translationimportqueue.IHasTranslationImports"/>
         <require
             permission="launchpad.Edit"
@@ -1510,6 +1520,8 @@
         <allow
             interface="lp.registry.interfaces.sourcepackage.ISourcePackage"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasBugHeat"/>
+        <allow
             interface="canonical.launchpad.interfaces.IHasBuildRecords"/>
         <allow
             interface="lp.translations.interfaces.translationimportqueue.IHasTranslationImports"/>

=== modified file 'lib/lp/registry/model/distribution.py'
--- lib/lp/registry/model/distribution.py	2010-03-23 15:14:41 +0000
+++ lib/lp/registry/model/distribution.py	2010-03-24 13:00:54 +0000
@@ -37,7 +37,7 @@
 from lp.bugs.model.bug import (
     BugSet, get_bug_tags, get_bug_tags_open_count)
 from lp.bugs.model.bugtarget import (
-    BugTargetBase, OfficialBugTagTargetMixin)
+    BugTargetBase, HasBugHeatMixin, OfficialBugTagTargetMixin)
 from lp.bugs.model.bugtask import BugTask
 from lp.soyuz.model.build import Build
 from lp.registry.model.distributionmirror import DistributionMirror
@@ -78,6 +78,7 @@
 from lp.soyuz.interfaces.archivepermission import (
     IArchivePermissionSet)
 from lp.bugs.interfaces.bugsupervisor import IHasBugSupervisor
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.interfaces.bugtask import (
     BugTaskStatus, UNRESOLVED_BUGTASK_STATUSES)
 from lp.soyuz.interfaces.build import IBuildSet
@@ -121,11 +122,13 @@
                    HasSpecificationsMixin, HasSprintsMixin, HasAliasMixin,
                    HasTranslationImportsMixin, KarmaContextMixin,
                    OfficialBugTagTargetMixin, QuestionTargetMixin,
-                   StructuralSubscriptionTargetMixin, HasMilestonesMixin):
+                   StructuralSubscriptionTargetMixin, HasMilestonesMixin,
+                   HasBugHeatMixin):
     """A distribution of an operating system, e.g. Debian GNU/Linux."""
     implements(
-        IDistribution, IFAQTarget, IHasBugSupervisor, IHasBuildRecords,
-        IHasIcon, IHasLogo, IHasMugshot, ILaunchpadUsage, IQuestionTarget)
+        IDistribution, IFAQTarget, IHasBugHeat, IHasBugSupervisor,
+        IHasBuildRecords, IHasIcon, IHasLogo, IHasMugshot, ILaunchpadUsage,
+        IQuestionTarget)
 
     _table = 'Distribution'
     _defaultOrder = 'name'

=== modified file 'lib/lp/registry/model/distributionsourcepackage.py'
--- lib/lp/registry/model/distributionsourcepackage.py	2010-03-09 16:26:04 +0000
+++ lib/lp/registry/model/distributionsourcepackage.py	2010-03-24 13:00:54 +0000
@@ -29,8 +29,9 @@
 from canonical.launchpad.interfaces.lpstorm import IStore
 from canonical.lazr.utils import smartquote
 from lp.answers.interfaces.questiontarget import IQuestionTarget
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.model.bug import BugSet, get_bug_tags_open_count
-from lp.bugs.model.bugtarget import BugTargetBase
+from lp.bugs.model.bugtarget import BugTargetBase, HasBugHeatMixin
 from lp.bugs.model.bugtask import BugTask
 from lp.code.model.hasbranches import HasBranchesMixin, HasMergeProposalsMixin
 from lp.registry.interfaces.distributionsourcepackage import (
@@ -58,7 +59,8 @@
                                 StructuralSubscriptionTargetMixin,
                                 HasBranchesMixin,
                                 HasCustomLanguageCodesMixin,
-                                HasMergeProposalsMixin):
+                                HasMergeProposalsMixin,
+                                HasBugHeatMixin):
     """This is a "Magic Distribution Source Package". It is not an
     SQLObject, but instead it represents a source package with a particular
     name in a particular distribution. You can then ask it all sorts of
@@ -67,7 +69,8 @@
     """
 
     implements(
-        IDistributionSourcePackage, IHasCustomLanguageCodes, IQuestionTarget)
+        IDistributionSourcePackage, IHasBugHeat, IHasCustomLanguageCodes,
+        IQuestionTarget)
 
     def __init__(self, distribution, sourcepackagename):
         self.distribution = distribution

=== modified file 'lib/lp/registry/model/distroseries.py'
--- lib/lp/registry/model/distroseries.py	2010-03-17 04:05:42 +0000
+++ lib/lp/registry/model/distroseries.py	2010-03-24 13:00:54 +0000
@@ -45,8 +45,9 @@
         BinaryPackageRelease)
 from lp.bugs.model.bug import (
     get_bug_tags, get_bug_tags_open_count)
-from lp.bugs.model.bugtarget import BugTargetBase
+from lp.bugs.model.bugtarget import BugTargetBase, HasBugHeatMixin
 from lp.bugs.model.bugtask import BugTask
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.interfaces.bugtask import UNRESOLVED_BUGTASK_STATUSES
 from lp.soyuz.model.component import Component
 from lp.soyuz.model.distroarchseries import (
@@ -126,11 +127,11 @@
 class DistroSeries(SQLBase, BugTargetBase, HasSpecificationsMixin,
                    HasTranslationImportsMixin, HasTranslationTemplatesMixin,
                    HasMilestonesMixin, SeriesMixin,
-                   StructuralSubscriptionTargetMixin):
+                   StructuralSubscriptionTargetMixin, HasBugHeatMixin):
     """A particular series of a distribution."""
     implements(
-        ICanPublishPackages, IDistroSeries, IHasBuildRecords, IHasQueueItems,
-        IHasTranslationTemplates)
+        ICanPublishPackages, IDistroSeries, IHasBugHeat, IHasBuildRecords,
+        IHasQueueItems, IHasTranslationTemplates)
 
     _table = 'DistroSeries'
     _defaultOrder = ['distribution', 'version']
@@ -1943,7 +1944,8 @@
         result_set = store.using((DistroSeries, POTemplate)).find(
             DistroSeries,
             DistroSeries.hide_all_translations == False,
-            DistroSeries.id == POTemplate.distroseriesID).config(distinct=True)
+            DistroSeries.id == POTemplate.distroseriesID).config(
+                distinct=True)
         # XXX: henninge 2009-02-11 bug=217644: Convert to sequence right here
         # because ResultSet reports a wrong count() when using DISTINCT. Also
         # ResultSet does not implement __len__(), which would make it more

=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py	2010-03-11 20:59:17 +0000
+++ lib/lp/registry/model/person.py	2010-03-24 13:00:54 +0000
@@ -837,16 +837,6 @@
         """No-op, to satisfy a requirement of HasBugsBase."""
         pass
 
-    @property
-    def max_bug_heat(self):
-        """Return None as this attribute is not implemented for a person.
-
-        XXX deryck 2010-02-28 bug=529846
-        This requires a DB patch to be done correctly, and we're
-        near release and tests are failing.
-        """
-        return None
-
     def searchTasks(self, search_params, *args, **kwargs):
         """See `IHasBugs`."""
         if search_params is None and len(args) == 0:

=== modified file 'lib/lp/registry/model/product.py'
--- lib/lp/registry/model/product.py	2010-02-24 15:28:07 +0000
+++ lib/lp/registry/model/product.py	2010-03-24 13:00:54 +0000
@@ -34,10 +34,11 @@
 from lp.code.model.branchvisibilitypolicy import (
     BranchVisibilityPolicyMixin)
 from lp.code.model.hasbranches import HasBranchesMixin, HasMergeProposalsMixin
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.model.bug import (
     BugSet, get_bug_tags, get_bug_tags_open_count)
 from lp.bugs.model.bugtarget import (
-    BugTargetBase, OfficialBugTagTargetMixin)
+    BugTargetBase, HasBugHeatMixin, OfficialBugTagTargetMixin)
 from lp.bugs.model.bugtask import BugTask
 from lp.bugs.model.bugtracker import BugTracker
 from lp.bugs.model.bugwatch import BugWatch
@@ -169,13 +170,15 @@
               QuestionTargetMixin, HasTranslationImportsMixin,
               HasAliasMixin, StructuralSubscriptionTargetMixin,
               HasMilestonesMixin, OfficialBugTagTargetMixin, HasBranchesMixin,
-              HasCustomLanguageCodesMixin, HasMergeProposalsMixin):
+              HasCustomLanguageCodesMixin, HasMergeProposalsMixin,
+              HasBugHeatMixin):
 
     """A Product."""
 
     implements(
-        IFAQTarget, IHasBugSupervisor, IHasCustomLanguageCodes, IHasIcon,
-        IHasLogo, IHasMugshot, ILaunchpadUsage, IProduct, IQuestionTarget)
+        IFAQTarget, IHasBugHeat, IHasBugSupervisor, IHasCustomLanguageCodes,
+        IHasIcon, IHasLogo, IHasMugshot, ILaunchpadUsage, IProduct,
+        IQuestionTarget)
 
     _table = 'Product'
 

=== modified file 'lib/lp/registry/model/productseries.py'
--- lib/lp/registry/model/productseries.py	2010-03-23 00:39:45 +0000
+++ lib/lp/registry/model/productseries.py	2010-03-24 13:00:54 +0000
@@ -26,7 +26,8 @@
 from canonical.database.enumcol import EnumCol
 from canonical.database.sqlbase import (
     SQLBase, quote, sqlvalues)
-from lp.bugs.model.bugtarget import BugTargetBase
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
+from lp.bugs.model.bugtarget import BugTargetBase, HasBugHeatMixin
 from lp.bugs.model.bug import (
     get_bug_tags, get_bug_tags_open_count)
 from lp.bugs.model.bugtask import BugTask
@@ -78,12 +79,12 @@
     return date + landmark['name']
 
 
-class ProductSeries(SQLBase, BugTargetBase, HasMilestonesMixin,
-                    HasSpecificationsMixin, HasTranslationImportsMixin,
-                    HasTranslationTemplatesMixin,
+class ProductSeries(SQLBase, BugTargetBase, HasBugHeatMixin,
+                    HasMilestonesMixin, HasSpecificationsMixin,
+                    HasTranslationImportsMixin, HasTranslationTemplatesMixin,
                     StructuralSubscriptionTargetMixin, SeriesMixin):
     """A series of product releases."""
-    implements(IProductSeries, IHasTranslationTemplates)
+    implements(IHasBugHeat, IProductSeries, IHasTranslationTemplates)
 
     _table = 'ProductSeries'
 

=== modified file 'lib/lp/registry/model/project.py'
--- lib/lp/registry/model/project.py	2010-02-24 15:28:07 +0000
+++ lib/lp/registry/model/project.py	2010-03-24 13:00:54 +0000
@@ -44,9 +44,10 @@
 from lp.code.model.branchvisibilitypolicy import (
     BranchVisibilityPolicyMixin)
 from lp.code.model.hasbranches import HasBranchesMixin, HasMergeProposalsMixin
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.model.bug import (
     get_bug_tags, get_bug_tags_open_count)
-from lp.bugs.model.bugtarget import BugTargetBase
+from lp.bugs.model.bugtarget import BugTargetBase, HasBugHeatMixin
 from lp.bugs.model.bugtask import BugTask
 from lp.answers.model.faq import FAQ, FAQSearch
 from lp.registry.model.karma import KarmaContextMixin
@@ -72,10 +73,10 @@
               MakesAnnouncements, HasSprintsMixin, HasAliasMixin,
               KarmaContextMixin, BranchVisibilityPolicyMixin,
               StructuralSubscriptionTargetMixin,
-              HasBranchesMixin, HasMergeProposalsMixin):
+              HasBranchesMixin, HasMergeProposalsMixin, HasBugHeatMixin):
     """A Project"""
 
-    implements(IProjectGroup, IFAQCollection, IHasIcon, IHasLogo,
+    implements(IProjectGroup, IFAQCollection, IHasBugHeat, IHasIcon, IHasLogo,
                IHasMugshot, ISearchableByQuestionOwner)
 
     _table = "Project"

=== modified file 'lib/lp/registry/model/sourcepackage.py'
--- lib/lp/registry/model/sourcepackage.py	2010-03-08 12:53:59 +0000
+++ lib/lp/registry/model/sourcepackage.py	2010-03-24 13:00:54 +0000
@@ -24,8 +24,9 @@
 from lp.buildmaster.interfaces.buildbase import BuildStatus
 from lp.code.model.branch import Branch
 from lp.code.model.hasbranches import HasBranchesMixin, HasMergeProposalsMixin
+from lp.bugs.interfaces.bugtarget import IHasBugHeat
 from lp.bugs.model.bug import get_bug_tags_open_count
-from lp.bugs.model.bugtarget import BugTargetBase
+from lp.bugs.model.bugtarget import BugTargetBase, HasBugHeatMixin
 from lp.bugs.model.bugtask import BugTask
 from lp.soyuz.interfaces.archive import IArchiveSet, ArchivePurpose
 from lp.soyuz.model.build import Build, BuildSet
@@ -157,7 +158,8 @@
 
 class SourcePackage(BugTargetBase, SourcePackageQuestionTargetMixin,
                     HasTranslationImportsMixin, HasTranslationTemplatesMixin,
-                    HasBranchesMixin, HasMergeProposalsMixin):
+                    HasBranchesMixin, HasMergeProposalsMixin,
+                    HasBugHeatMixin):
     """A source package, e.g. apache2, in a distroseries.
 
     This object is not a true database object, but rather attempts to
@@ -166,8 +168,8 @@
     """
 
     implements(
-        ISourcePackage, IHasBuildRecords, IHasTranslationTemplates,
-        IQuestionTarget)
+        ISourcePackage, IHasBugHeat, IHasBuildRecords,
+        IHasTranslationTemplates, IQuestionTarget)
 
     classProvides(ISourcePackageFactory)