Merge lp:~deryck/launchpad/filebug-input-display-346722 into lp:launchpad

[Deryck Hodge]

[Deryck Hodge (deryck)]

Bug 346722 describes a simple problem creating enormous pain for Ubuntu.
The filebug input is so small that crash summaries don't display fully
and more duplicates reports are filled than perhaps could be if the user
could better double check the generated summary against possible dupes.

This branch makes the input longer so that long summaries are readable
and also adds the query to the heading above the dupes, so that the user
can see the query he or she entered when comparing to possible dupes.

beuno has signed off on the UI for this, since we're at a sprint
together currently.

== Tests ==

./bin/test -vv -t xx-displaying-similar-bugs.txt

This test has been updated to test that the query is re-displayed in the
heading.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
   lib/lp/bugs/browser/bugtarget.py
   lib/lp/bugs/stories/guided-filebug/xx-displaying-similar-bugs.txt
   lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt

[Jeroen T. Vermeulen (jtv)]

The code is good (not much to go wrong in any case) and I'm sure a nice
improvement. I do have some misgivings about plunking possibly long or
punctuated search strings into running text, but that's a UI design call.

review: Approve

=== modified file 'lib/lp/bugs/browser/bugtarget.py'
--- lib/lp/bugs/browser/bugtarget.py	2009-09-25 06:30:06 +0000
+++ lib/lp/bugs/browser/bugtarget.py	2009-10-01 13:12:17 +0000
@@ -903,7 +903,7 @@
     # XXX: Brad Bollenbach 2006-10-04: This assignment to actions is a
     # hack to make the action decorator Just Work across inheritance.
     actions = FileBugViewBase.actions
-    custom_widget('title', TextWidget, displayWidth=40)
+    custom_widget('title', TextWidget, displayWidth=65)
     custom_widget('tags', BugTagsWidget)
 
     _SEARCH_FOR_DUPES = ViewPageTemplateFile(

=== modified file 'lib/lp/bugs/stories/guided-filebug/xx-displaying-similar-bugs.txt'
--- lib/lp/bugs/stories/guided-filebug/xx-displaying-similar-bugs.txt	2009-08-18 11:04:38 +0000
+++ lib/lp/bugs/stories/guided-filebug/xx-displaying-similar-bugs.txt	2009-10-01 13:12:17 +0000
@@ -80,6 +80,13 @@
       Closed (0 comments) last updated 2006-05-19...
       When I press print in Firefox...
 
+To help the user verify if a bug is indeed simliar to the problem
+being reported, the user's original summary is displayed above
+the list of potentially similar bugs.
+
+    >>> query = find_tag_by_id(user_browser.contents, 'filebug-query-heading')
+    >>> print extract_text(query)
+    Is "reflow" one of these bugs?
 
 == Projects ==
 

=== modified file 'lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt'
--- lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt	2009-08-18 16:32:03 +0000
+++ lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt	2009-10-01 13:12:17 +0000
@@ -24,14 +24,7 @@
     <div tal:condition="view/isPrivate" id="privacy" class="aside private">
       This report will be private, though you can disclose it later.
     </div>
-    <h2>
-      <tal:heading condition="not:view/show_duplicate_list">
-        Report a bug
-      </tal:heading>
-      <tal:heading condition="view/show_duplicate_list">
-        Is the bug you&rsquo;re reporting one of these?
-      </tal:heading>
-    </h2>
+    <h1>Report a bug</h1>
   </div>
 
   <div metal:fill-slot="main">

=== modified file 'lib/lp/bugs/templates/bugtarget-macros-filebug.pt'
--- lib/lp/bugs/templates/bugtarget-macros-filebug.pt	2009-09-14 13:33:19 +0000
+++ lib/lp/bugs/templates/bugtarget-macros-filebug.pt	2009-10-01 13:12:17 +0000
@@ -361,6 +361,8 @@
 </metal:bug_reporting_guidelines>
 
 <metal:similar-bugs define-macro="display-similar-bugs">
+  <p id="filebug-query-heading">Is "<strong><span tal:replace="view/search_text">my submitted bug
+    summary</span></strong>" one of these bugs?</p>
   <ul id="similar-bugs">
     <li tal:repeat="bug view/similar_bugs" class="similar-bug">
       <table tal:define="bugtask python:view.getRelevantBugTask(bug)">