Merge lp:~deryck/launchpad/convert-tags-management-page-424383 into lp:launchpad
Proposed by
Deryck Hodge
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~deryck/launchpad/convert-tags-management-page-424383 |
Merge into: | lp:launchpad |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~deryck/launchpad/convert-tags-management-page-424383 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer (community) | ui | Approve | |
Abel Deuring (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
This branch updates the official tag management page to the 3.0 UI.
These are just mechanical changes. The is tracked as bug 424383.
This is a pretty straight forward conversion, making the changes to the
template, dropping the entry from pagetitles, and adding label and
page_title properties to the view.
A screenshot of the work is here:
http:// launchpadlibrar ian.net/ 31318614/ tag-management- update. png
I did constrain the management form to a column in the YUI grid, which I
personally liked better than the form spreading out the width of the
page. But if UI reviewers don't like this, I can certainly and easily
go back to the old form layout.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: bugs/browser/ bugtarget. py /launchpad/ pagetitles. py bugs/templates/ official- bug-target- manage- tags.pt
lib/lp/
lib/canonical
lib/lp/