Merge lp:~deryck/launchpad/bug-page-distro-max-heat-532099 into lp:launchpad

[Deryck Hodge]

Use distribution context on bug page when displaying flame icons for packages.

This is a fix for bug 532099.

If a package has only a few bugs reported against it, then the bug page
for a bug with any heat at all will likely end up with four flame icons.
 This is a bit weird for two reasons -- the bug has a low heat value and
users clicking through from a distro bug page with see flame when there
wasn't in the bug list.

To fix this, we use the distro context on the bug page for packages.

A test has been update for this change. Run it with:

./bin/test -cvvt xx-bug-heat-on-bug-page.txt

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/stories/bugs/xx-bug-heat-on-bug-page.txt
  lib/lp/bugs/browser/bugtask.py

[Eleanor Berger (intellectronica)]

review: Approve (code)

=== modified file 'lib/lp/bugs/browser/bugtask.py'
--- lib/lp/bugs/browser/bugtask.py	2010-03-10 22:19:37 +0000
+++ lib/lp/bugs/browser/bugtask.py	2010-03-15 18:02:26 +0000
@@ -1083,7 +1083,11 @@
     @property
     def bug_heat_html(self):
         """HTML representation of the bug heat."""
-        return bugtask_heat_html(self.context)
+        if IDistributionSourcePackage.providedBy(self.context.target):
+            return bugtask_heat_html(
+                self.context, target=self.context.distribution)
+        else:
+            return bugtask_heat_html(self.context)
 
 
 def calculate_heat_display(heat, max_bug_heat):

=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-heat-on-bug-page.txt'
--- lib/lp/bugs/stories/bugs/xx-bug-heat-on-bug-page.txt	2010-02-25 19:49:02 +0000
+++ lib/lp/bugs/stories/bugs/xx-bug-heat-on-bug-page.txt	2010-03-15 18:02:26 +0000
@@ -3,5 +3,33 @@
 The bug heat appears on the bug index page as four flames.
 
     >>> anon_browser.open('http://bugs.launchpad.dev/firefox/+bug/1')
-    >>> print find_tag_by_id(anon_browser.contents, 'registration').fetch('img')[0]
+    >>> print find_tag_by_id(
+    ...     anon_browser.contents, 'registration').fetch('img')[0]
     <img src="/@@/bug-heat-0.png" alt="0 out of 4 heat flames" title="Heat: 0" />
+
+Packages use their distribution as context when generating flame icons
+for a bug page, since a package of low heat value could be displayed
+with four flames if there are few reported bugs against the package.
+
+    >>> from canonical.launchpad.ftests import login, logout
+    >>> from canonical.launchpad.webapp import canonical_url
+    >>> from lp.bugs.interfaces.bug import CreateBugParams
+    >>> login('[e-mail]')
+    >>> max_heat = 5000.0
+    >>> distro = factory.makeDistribution()
+    >>> dsp = factory.makeDistributionSourcePackage(distribution=distro)
+    >>> person = factory.makePerson()
+    >>> bug_params = CreateBugParams(
+    ...     owner=person,
+    ...     title="A new bug",
+    ...     comment="This is a new bug")
+    >>> dsp_bug = dsp.createBug(bug_params)
+    >>> dsp_bug.setHeat(max_heat/4)
+    >>> dsp.setMaxBugHeat(max_heat/4)
+    >>> distro.setMaxBugHeat(max_heat)
+    >>> logout()
+
+    >>> anon_browser.open(canonical_url(dsp_bug))
+    >>> print find_tag_by_id(
+    ...     anon_browser.contents, 'registration').fetch('img')[0]
+    <img src="/@@/bug-heat-0.png" alt="0 out of 4 heat flames" title="Heat: 1250" />