Merge lp:~deryck/launchpad/bug-activity-do-not-snapshot-680131 into lp:launchpad
Proposed by
Deryck Hodge
Status: | Merged |
---|---|
Approved by: | Deryck Hodge |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13107 |
Proposed branch: | lp:~deryck/launchpad/bug-activity-do-not-snapshot-680131 |
Merge into: | lp:launchpad |
Diff against target: |
45 lines (+8/-3) 3 files modified
lib/lp/bugs/interfaces/bug.py (+2/-2) lib/lp/bugs/tests/test_bug.py (+4/-0) lib/lp/bugs/tests/test_bugs_webservice.py (+2/-1) |
To merge this branch: | bzr merge lp:~deryck/launchpad/bug-activity-do-not-snapshot-680131 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+62035@code.launchpad.net |
Commit message
[r=sinzui][bug=680131] Add doNotSnapshot to IBug.activity to fix OOPS when marking yourself as affected by a bug.
Description of the change
This makes sure bug activity is not snapshotted to keep from OOPSing when a bug is marked as affecting a user. This happens on bug 1 as noted in bug 680131. I chatted with Curtis about how to fix this long term, so we don't have to continually doNotSnapshot CollectionFields. But I spotted the offending attribute on IBug while working today and thought it an easy enough fix to land right away.
To post a comment you must log in.
I should mention to, I will continue to work on the better, long term fix for this, too. This is just an immediate fix to close the current bug.