Merge lp:~deryck/groundcontrol/keyword-search-name into lp:groundcontrol

Proposed by Deryck Hodge
Status: Merged
Merge reported by: Martin Owens
Merged at revision: not available
Proposed branch: lp:~deryck/groundcontrol/keyword-search-name
Merge into: lp:groundcontrol
Diff against target: 12 lines (+1/-1)
1 file modified
GroundControl/ (+1/-1)
To merge this branch: bzr merge lp:~deryck/groundcontrol/keyword-search-name
Reviewer Review Type Date Requested Status
Martin Owens Approve
Review via email:

Description of the change

I didn't realize that the "Name or Bug ID" on the text field in the project bugs view would allow me to do text search on project bugs. I was likely confused because Launchpad bugs has the concept of nick names for bugs, which act like bug IDs. Probably no one else would be confused by this, except someone like me with knowledge of Launchpad minutiu, but I think changing the lanugage to read "Search or Bug ID" would make this a better more clear.

This branch implements that language change and updates the strings in po files. I want to request you consider it for merging into Ground Control trunk. I'm happy to do any further work I need to do to get it ready to land, assuming you like the change in language.

Thanks. Cheers,

To post a comment you must log in.
Revision history for this message
Martin Owens (doctormo) wrote :

This is very good and I accept your string changes, I would ask if you could revert the po changes as I do those through another branche.

272. By Deryck Hodge

Revert po changes per review request.

Revision history for this message
Deryck Hodge (deryck) wrote :

po changes reverted. Thanks for the quick review!

Revision history for this message
Martin Owens (doctormo) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GroundControl/'
2--- GroundControl/ 2010-02-10 04:53:14 +0000
3+++ GroundControl/ 2010-05-11 20:54:31 +0000
4@@ -131,7 +131,7 @@
5 self.widget("findButton").show()
6 self.widget("term").show()
7 if self._project:
8- self.widget("searchLabel").set_text(_("Name or Bug ID:"))
9+ self.widget("searchLabel").set_text(_("Search or Bug ID:"))
10 self.widget("findButton").set_label(_("Find in %s") %
11 else:
12 self.widget("searchLabel").set_text(_("Bug ID:"))


People subscribed via source and target branches