Code review comment for lp:~dennis/update-notifier/apt-proxies

Dennis Kaarsemaker (dennis) wrote :

On do, 2014-06-05 at 14:16 +0000, Michael Vogt wrote:
> Review: Needs Information
>
> Hey Dennis, nice to see you again :)
>
> I like your branch and I think its indeed pretty anoying that the data
> downloader does not use the native apt proxy setup. I think we could
> do even better by using the apt acquire system to download the
> file(s). I outlined this here: lp:~mvo/update-notifier/use-apt-helper.
> This will also make sure we support e.g. the auto proxy discovery.
>
> What do you think? Could you give the alternative implemenation a
> testrun and let me know if it honors the proxy for you?

That works just fine for me, I'd prefer your solution over mine.
--
Dennis Kaarsemaker
http://www.kaarsemaker.net

« Back to merge proposal