lp:~denim2x/gtksourceview/gtksourceview

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:gtksourceview

Cassidy James Blaede: Pending requested 2015-06-25

Diff: 114 lines (+109/-0)

1 file modified

data/language-specs/mustache.lang (+109/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

4217. By denim2x on 2015-06-25

Created mustache.lang

4216. By Balázs Úr on 2015-06-22

Updated Hungarian translation

4215. By Sébastien Wilmet on 2015-06-22

Post-release version bump

4214. By Sébastien Wilmet on 2015-06-22

Release 3.17.3

4213. By Dimitris Spingos on 2015-06-22

Updated Greek translation

4212. By Paolo Borelli <email address hidden> on 2015-06-21

Add "smart-backspace" property

Ported from gnome-builder code. Gedit has a smart-spaces plugin
with the same logic, so it makes sense to consolidate the
implementation in gtksourceview itself

4211. By Sébastien Wilmet on 2015-06-20

FileLoader: document not_undoable_action() and set_modified() behavior

Since apps rely on that, it's better to document it.

4210. By Sébastien Wilmet on 2015-06-20

Revert "FileLoader: call gtk_text_buffer_set_modified()"

This reverts commit db7a028d94e5a4f9bea089e0db5d0a06489c52d8.

To follow the least surprise principle, it's better to always do the
same thing, that is, set the modified bit to FALSE after a file loading.
The FileLoader thus resets the buffer with a certain (unmodified)
content.

The rationale behind the commit was to have good defaults for the most
common cases. That is, when loading from a GFile, the contents is
usually stored on disk and we can mark the buffer in a "saved/safe"
state (i.e. not modified). On the other hand when loading from a
GInputStream, the common case is for stdin, in which case the app
doesn't know if the contents is stored on disk or not, so it's better to
set the buffer as modified to avoid data loss (when closing the buffer
the user will typically get a dialog window asking for saving the
content). So the idea was to explain in the docs that when loading from
a GInputStream, the app must explicitly acknowledge that the buffer is
in a saved state, while loading from a GFile the reverse must be done if
the GFile is a temporary file. So the idea was to make the good way the
easy way, by default the app would have nothing to do, it would just
work.

Anyway, even if it was not documented that
gtk_text_buffer_set_modified(false) was called, changing that can be
seen as an API break. The set_modified() was not part of the "interface"
(the I in API), it was an implementation detail, so that's why the
change can also be seen as acceptable. In an API, everything that is not
documented can be considered as "undefined behavior".

4209. By Sébastien Wilmet on 2015-06-14

file: add is_local() function

And add a recommendation for check_file_on_disk().

4208. By Sébastien Wilmet on 2015-06-14

FileLoader: call gtk_text_buffer_set_modified()

Set the buffer as modified when loading from an input stream (e.g.
stdin).

GtkSourceBufferOutputStream doesn't know if the contents comes from a
GFile or a GInputStream, GtkSourceFileLoader does.