deluge:develop

Last commit made on 2020-04-30
Get this branch:
git clone -b develop https://git.launchpad.net/deluge

Branch merges

Branch information

Name:
develop
Repository:
lp:deluge

Recent commits

23a48dd... by Calum Lind <email address hidden> on 2020-04-27

[#3309|GTK] Fix cmp function for None types

Comparisons on Python 3 are much stricter resulting in the following
error comparing with None:

    TypeError: '>' not supported between instances of 'NoneType' and 'str'

Fix this by getting the type of the other value and getting it's default
value.

d02fa72... by Calum Lind <email address hidden> on 2020-04-27

[Console] Fix hostlist status lookup errors

If a host in hostlist failed DNS lookup or other issue it was returning
a tuple instead of deferred. Fix this in hostlist by returning a
defer.succeed.

A race condition with BaseMode was also encountered when
update_hosts_status calls update_select_host_popup and
ConnectionManager does not have a rows attribute. Fix this by init
BaseMode before update_hosts_status and remove already called
update_select_host_popup.

62d8749... by Calum Lind <email address hidden> on 2020-04-25

[#3348] Fix TypeError adding peers to torrents

Python3 has stricter type checking and passing a port as string results
in libtorrent raising a TypeError.

Fixed by casting port to int, along with refactoring to ensure ipv6 is
correctly parsing and a useful error is output to user with invalid ip
or port details.

https://dev.deluge-torrent.org/ticket/3348

76f0bf2... by Nitzan Raz on 2019-07-20

Ctl+Q to quit Deluge GTK without killing daemon

635f6d9... by Calum Lind <email address hidden> on 2019-12-13

[Config] Fix loading config with double-quotes in string

If a password or other string contained a double-quote then the config
would fail to be loaded on startup and reset.

This occurred due to fixing a similar issue with curly braces for #3079
in commit 33e9545cd44 and the checking for double-quotes had unforseen
consequences.

To resolve both these issues the code to check for json objects in
config files was simplified and utilises the json module raw_decode
method to ensure the extracted string indexes are json objects.

672e3c4... by bendikro <email address hidden> on 2020-04-12

[Tests] Add pytest markers to tox.ini

Remove pytest warnings due to unknown markers

c1110e4... by bendikro <email address hidden> on 2020-04-01

[Tests] Fix tests failing when deluged fails to listen

Commit b32c5d824 changed the logged message in deluge/core/daemon_entry.py
when libtorrent fails to listen on the given port, without updating the
trigger expression in deluge/tests/common.py:start_core to match the new output.

Fix by updating the trigger match expressions to match the new log output

742c8a9... by bendikro <email address hidden> on 2019-10-24

[Tests] Fix PytestDeprecationWarning from pytest

Accessing pytest.config is deprecated and produces:
PytestDeprecationWarning: the pytest.config global is deprecated. Please use
request.config or pytest_configure (if you're a pytest plugin) instead.

Fix by using a pytest.fixture

3427ae4... by bendikro <email address hidden> on 2020-04-12

[GTK] Remove PyGIWarning in gtk3/files_tab.py

Remove warning: PyGIWarning: Gtk was imported without specifying a version first

034db27... by bendikro <email address hidden> on 2020-04-01

[GTK] Add more width to outgoing ports spinbuttons in network preferences

The spinbuttons would sometimes be truncated.
Fix by increasing the width