Merge ~dekarl/maas:fix-power-apc into maas:master

[Karl Egly]

Mark APC Power Driver as queryable

Mark APC Power Driver Queryable

Inspired by Vamsidhar Juvvigunta on the Forum at
https://discourse.maas.io/t/power-type-apc-in-maas-2-7-2-8-query-fails-but-on-off-works/1948

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-power-apc lp:~dekarl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8241/console
COMMIT: 1e346460f85caf7043e39f50ce3a05f9e1e1a611

review: Needs Fixing

[Adam Collard (adam-collard)]

> UNIT TESTS
> -b fix-power-apc lp:~dekarl/maas/+git/maas into -b master lp:~maas-
> committers/maas
>
> STATUS: FAILED
> LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8241/console
> COMMIT: 1e346460f85caf7043e39f50ce3a05f9e1e1a611

Thanks for the contribution - the test that is failing is https://paste.ubuntu.com/p/d6BRvHBVdr/ and the error is https://paste.ubuntu.com/p/2jbfqrq3Jq/

Can you update your branch to change the power type in the test to "manual"?

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-power-apc lp:~dekarl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 6064c9af8ae27f35f7232ade8d3c911192739457

review: Approve

[Karl Egly (dekarl)]

Hi Adam, thank you for taking the time to look into the failing test. I have applied the suggested changes.

[Adam Collard (adam-collard)]

review: Approve

[MAAS Lander (maas-lander)]

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

[MAAS Lander (maas-lander)]

LANDING
-b fix-power-apc lp:~dekarl/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8281/consoleText

diff --git a/src/maasserver/models/tests/test_node.py b/src/maasserver/models/tests/test_node.py
index 8e53695..adfb86a 100644
--- a/src/maasserver/models/tests/test_node.py
+++ b/src/maasserver/models/tests/test_node.py
@@ -9206,7 +9206,7 @@ class TestNode_PowerQuery(MAASTransactionServerTestCase):
     def test_updates_power_state_unknown_for_non_queryable_power_type(self):
         node = yield deferToDatabase(
             transactional(factory.make_Node),
-            power_type="apc",
+            power_type="manual",
             power_state=POWER_STATE.ON,
         )
         mock_power_control = self.patch(node, "_power_control_node")
diff --git a/src/provisioningserver/drivers/power/apc.py b/src/provisioningserver/drivers/power/apc.py
index 1fe8505..4a2710f 100644
--- a/src/provisioningserver/drivers/power/apc.py
+++ b/src/provisioningserver/drivers/power/apc.py
@@ -44,7 +44,6 @@ class APCPowerDriver(PowerDriver):
         ),
     ]
     ip_extractor = make_ip_extractor("power_address")
-    queryable = False
 
     def detect_missing_packages(self):
         binary, package = ["snmpset", "snmp"]