Linaro Fetch Image

Merge lp:~deeptik/linaro-fetch-image/fix-android into lp:linaro-fetch-image

  1. fix-android
  2. Merge into linaro-fetch-image
Proposed by Deepti B. Kalakeri
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 22
Merged at revision: 23
Proposed branch: lp:~deeptik/linaro-fetch-image/fix-android
Merge into: lp:linaro-fetch-image
Diff against target: 12 lines (+1/-1)
1 file modified
linaro_fetch_image/fetch_image.py (+1/-1)
To merge this branch: bzr merge lp:~deeptik/linaro-fetch-image/fix-android
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+129397@code.launchpad.net

Description of the change

Fixing the Android failures.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Definitely works. I would like it if we could use a more restrictive search, but finding all links is probably the most robust way (providing the wrong one isn't used by accident)! Unfortunately the page has two div's with an id="content" at the moment, which is invalid HTML. Was working yesterday :-(

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_fetch_image/fetch_image.py'
2--- linaro_fetch_image/fetch_image.py 2012-10-12 11:01:12 +0000
3+++ linaro_fetch_image/fetch_image.py 2012-10-12 11:50:28 +0000
4@@ -117,7 +117,7 @@
5 dir = []
6 # Use BeautifulSoup to parse the HTML and iterate over all 'a' tags
7 soup = BeautifulSoup.BeautifulSoup(page)
8- links = soup.find("div", {"id" : "content"}).find("table").findAll("a")
9+ links = soup.findAll("a")
10 for link in links:
11 for attr, value in link.attrs:
12 if(attr == "href"):

Subscribers

People subscribed via source and target branches