Merge lp:~deeptik/lava-dashboard/test_result_view_work into lp:lava-dashboard

[Deepti B. Kalakeri]

Outline of the Test Result details view.
Please review and let me know your comments.

Thanks!!!
Deepti.

[Zygmunt Krynicki (zyga)]

Overall looks good but you seem to have missed to bzr add the template file: dashboard_app/test_result_detail.html.

review: Needs Fixing

[Deepti B. Kalakeri (deeptik)]

On Thursday 23 December 2010 07:46 PM, Zygmunt Krynicki wrote:
> Review: Needs Fixing
> Overall looks good but you seem to have missed to bzr add the template file: dashboard_app/test_result_detail.html.
>
>
>
oops! I am sorry for missing it, I have added it and pushed it to the
same branch.
Please review it.

Thanks and Regards,
Deepti.

[lp:~deeptik/lava-dashboard/test_result_view_work]

121. By Deepti B. Kalakeri on 2010-12-23

Adding the missing template changes for test result display view

122. By Deepti B. Kalakeri on 2010-12-23

Adding a simple json development data set for test result detail view

123. By Deepti B. Kalakeri on 2010-12-23

Improving the test run detail view

=== modified file 'dashboard_app/models.py'
--- dashboard_app/models.py	2010-12-20 11:52:16 +0000
+++ dashboard_app/models.py	2010-12-23 19:53:10 +0000
@@ -735,3 +735,8 @@
                 (duration.days * 24 * 60 * 60 * 10 ** 6))
 
     duration = property(_get_duration, _set_duration)
+
+    @models.permalink
+    def get_absolute_url(self):
+        return ("dashboard_app.views.test_result_detail",
+                [self.pk])

=== modified file 'dashboard_app/urls.py'
--- dashboard_app/urls.py	2010-12-13 13:08:20 +0000
+++ dashboard_app/urls.py	2010-12-23 19:53:10 +0000
@@ -27,11 +27,14 @@
         restricted_view,
         dashboard_xml_rpc_handler,
         test_run_detail,
+        test_result_detail,
         )
 
 urlpatterns = patterns('',
         url(r'^streams/$', bundle_stream_list,
             name='dashboard_app.bundle_stream_list'),
+        url(r'^test-results/(?P<pk>[0-9]+)/$',
+            test_result_detail, name='dashboard_app.views.test_result_detail'),
         url(r'^test-runs/(?P<analyzer_assigned_uuid>[a-zA-Z0-9-]+)/$',
             test_run_detail, name='dashboard_app.views.test_run_detail'),
         url(r'^streams(?P<pathname>/[a-zA-Z0-9/-]+/)$', bundle_stream_detail,

=== modified file 'dashboard_app/views.py'
--- dashboard_app/views.py	2010-12-21 16:02:22 +0000
+++ dashboard_app/views.py	2010-12-23 19:53:10 +0000
@@ -31,7 +31,7 @@
 from django.template import RequestContext
 
 from dashboard_app.dispatcher import DjangoXMLRPCDispatcher
-from dashboard_app.models import (Bundle, BundleStream, TestRun)
+from dashboard_app.models import (Bundle, BundleStream, TestRun, TestResult)
 from dashboard_app.xmlrpc import DashboardAPI
 
 
@@ -155,6 +155,21 @@
         resp.status_code = 403
         return resp
 
+def test_result_detail(request, pk):
+    test_result = get_object_or_404(TestResult, pk=pk)
+    if test_result.test_run.bundle.bundle_stream.can_access(request.user):
+        return list_detail.object_detail(
+                request,
+                slug_field = 'id',
+                slug = pk,
+                queryset = TestResult.objects.all(),
+                template_name = 'dashboard_app/test_result_detail.html',
+                template_object_name = 'test_result',
+            )
+    else:
+        resp = render_to_response("403.html", RequestContext(request))
+        resp.status_code = 403
+        return resp
 
 def auth_test(request):
     response = HttpResponse(mimetype="text/plain")

=== added file 'dashboard_server/templates/dashboard_app/test_result_detail.html'
--- dashboard_server/templates/dashboard_app/test_result_detail.html	1970-01-01 00:00:00 +0000
+++ dashboard_server/templates/dashboard_app/test_result_detail.html	2010-12-23 19:53:10 +0000
@@ -0,0 +1,66 @@
+{% extends "base.html" %}
+{% load i18n %}
+{% load humanize %}
+{% load pagination_tags %}
+
+
+{% block title %}
+| {% trans "Test Results" %}
+| {{ test_result }}
+{% endblock %}
+
+
+{% block breadcrumbs %}
+<li><a href="{% url dashboard_app.views.bundle_stream_list %}">{% trans "Bundle Streams" %}</a></li>
+<li><a href="{{ test_result.test_run.bundle.bundle_stream.get_absolute_url }}">{{ test_result.test_run.bundle.bundle_stream }}</a></li>
+<li><a href="{{ test_result.test_run.get_absolute_url }}">{{ test_result.test_run }}</a></li>
+<li><a href="{{ test_result.get_absolute_url }}">{{ test_result }}</a></li>
+{% endblock %}
+
+
+{% block sidebar %}
+<dl>
+  <dt>{% trans "Test Name" %}</dt>
+  <dd>{{ test_result.test_run.test }}</dd>
+  <dt>{% trans "Test case" %}</dt>
+  <dd>{{ test_result.test_case }}</dd>
+  <dt>{% trans "Log file name" %}</dt>
+  <dd>{{ test_result.filename }}</dd>
+  <dt>{% trans "Line no." %}</dt>
+  <dd>{{ test_result.lineno }}</dd>
+  <dt>{% trans "Test executed at" %}</dt>
+  <dd>
+  {{ test_result.timestamp|naturalday }}
+  {{ test_result.timestamp|time }}
+  </dd>
+  <dt>{% trans "Time taken to execute test" %}</dt>
+  <dd>{{ test_result.duration }}</dd>
+</dl>
+{% endblock %}
+
+
+{% block content %}
+{% if test_result.attributes.values %}
+<h2>{% trans "Test log [" %}{{ test_result.filename }}{% trans "] Details:" %}</h2>
+<p>{{ test_result.message }}</p>
+  <table class="data">
+      <tr><th colspan="4">{% trans "Test Result attribute information" %}</th></tr>
+      <tr>
+      <th>{% trans "Id" %}</th>
+      <th>{% trans "Content Type Id" %}</th>
+      <th>{% trans "Attribute Name" %}</th>
+      <th>{% trans "Attribute Value" %}</th>
+      </tr>
+      {% for item in test_result.attributes.values %}
+      <tr>
+        <td width="1%">{{ item.id }}</td>
+        <td width="1%">{{ item.content_type_id }}</td>
+        <td width="1%">{{ item.name }}</td>
+        <td width="1%">{{ item.value }}</td>
+      </tr>
+     {% endfor %}
+  </table>
+{% else %}
+  {%trans "There are no attributes listed for " %}{{ test_result }}
+{% endif %}
+{% endblock %}

=== modified file 'dashboard_server/templates/dashboard_app/test_run_detail.html'
--- dashboard_server/templates/dashboard_app/test_run_detail.html	2010-12-21 16:11:43 +0000
+++ dashboard_server/templates/dashboard_app/test_run_detail.html	2010-12-23 19:53:10 +0000
@@ -59,9 +59,10 @@
     <td width="1%">{{ page_obj.start_index|add:forloop.counter0 }}</td>
     <td>{{ test_result.test_case }}</td>
     <td>
-      <img src="{{ MEDIA_URL }}assets/images/icon-{{ test_result.result_code }}.png" 
-      alt="{{ test_result.get_result_display }}" width="16" height="16" />
-      {{ test_result.get_result_display }}
+      <a href ="{{test_result.get_absolute_url}}">
+      <img src="{{ MEDIA_URL }}assets/images/icon-{{ test_result.result_code }}.png"
+      alt="{{ test_result.get_result_display }}" width="16" height="16" border="0"/></a>
+      <a href ="{{test_result.get_absolute_url}}">{{ test_result.get_result_display }}</a>
     </td>
     {% if test_result.measurement %}
     <td>{{ test_result.measurement|default_if_none:"" }} {{ test_result.units }}</td>

=== added file 'example_bundles/test_result_detail.json'
--- example_bundles/test_result_detail.json	1970-01-01 00:00:00 +0000
+++ example_bundles/test_result_detail.json	2010-12-23 19:53:10 +0000
@@ -0,0 +1,80 @@
+{
+  "test_runs": [
+    {
+      "test_results": [
+        {
+          "test_case_id": "helix-0", 
+          "result": "pass",
+          "message": "Test result Message scrubbed from the log file",
+          "timestamp": "2010-09-17T16:34:21Z",
+          "log_filename": "testoutput.log",
+          "log_lineno": 1,
+          "duration" : "1d 1s 1us",
+           "attributes": {
+                          "attr1": "value1",
+                          "attr2": "value2"
+                         }
+        }, 
+        {
+          "test_case_id": "helix-1", 
+          "result": "fail",
+          "message": "Test result Message scrubbed from the log file",
+          "timestamp": "2010-09-18T16:34:21Z",
+          "log_filename": "testoutput.log",
+          "log_lineno": 2,  
+          "duration" : "1d 1s 1us",
+           "attributes": {
+                          "attr1": "value1",
+                          "attr2": "value2"
+                         }
+        }, 
+        {
+          "test_case_id": "helix-2", 
+          "result": "skip",
+          "message": "Test result Message scrubbed from the log file",
+          "timestamp": "2010-09-19T16:34:21Z",
+          "log_filename": "testoutput.log",
+          "log_lineno": 3,  
+          "duration" : "1d 1s 1us",
+           "attributes": {
+                          "attr1": "value1",
+                          "attr2": "value2"
+                         }
+        }, 
+        {
+          "test_case_id": "helix-3", 
+          "result": "unknown",
+          "message": "Test result Message scrubbed from the log file",
+          "timestamp": "2010-09-20T16:34:21Z",
+          "log_filename": "testoutput.log",
+          "log_lineno": 4,  
+          "duration" : "1d 1s 1us",
+           "attributes": {
+                          "attr1": "value1",
+                          "attr2": "value2"
+                         }
+        }, 
+        {
+          "test_case_id": "helix-4", 
+          "result": "unknown",
+          "measurement": 512.0,
+          "units": "bits/s",
+          "message": "Test result Message scrubbed from the log file",
+          "timestamp": "2010-09-21T16:34:21Z",
+          "log_filename": "testoutput.log",
+          "log_lineno": 5,  
+          "duration" : "1d 1s 1us",
+           "attributes": {
+                          "attr1": "value1",
+                          "attr2": "value2"
+                         }
+        } 
+      ], 
+      "analyzer_assigned_date": "2010-10-15T22:05:45Z", 
+      "time_check_performed": false, 
+      "analyzer_assigned_uuid": "00000000-0000-0000-0000-000000000005",
+      "test_id": "double-helix"
+    }
+  ], 
+  "format": "Dashboard Bundle Format 1.0"
+}