Code review comment for lp:~deeptik/lava-dashboard/kernel-ci-data-veiw-report

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is good to land as is but needs some more subsequent work:

1) The query should be fine tuned, in particular ths e join between build results and test result should permit broken builds to be listed (without any test data) (the outer left join vs inner join)

2) The data view documentation and summary should have non-dummy values. Summary is a short one-line description that shows up in help text and various pages. Documentation is a longer free form text.

3) The report page should be extended to explain what is being observed, how to interpret the data, which bundle streams are being analyzed and how the data is being produced. This would make it a very worthwhile target for being displayed or linked to on the validation front page.

review: Approve

« Back to merge proposal