Merge lp:~deepak-willowit/domsense-agilebg-addons/no-lpr into lp:domsense-agilebg-addons/6.1

[Deepak Seshadri]

[Leonardo Pistone (lepistone)]

Deepak,

thanks for your work! could you elaborate a bit on why this is needed?

review: Needs Information

[Deepak Seshadri (deepak-willowit)]

Hi Leonardo,

It's a lot cleaner to use the methods provided by an API instead of
invoking a system command.

In our case, we have just a proxy forwarding all CUPS connections to
localhost over to a remote server - this setup doest not have a local
version of CUPS's lpr replacement command-line utilities installed,
and hence the addon failed to print any reports. Using the API removes
this requirement, and as I stated earlier, is a lot cleaner.

Regards,

Deepak Seshadri
WillowIT

On 5 March 2012 19:29, Leonardo Pistone - Agile BG - Domsense
<email address hidden> wrote:
> Review: Needs Information
>
> Deepak,
>
> thanks for your work! could you elaborate a bit on why this is needed?
> --
> https://code.launchpad.net/~deepak-willowit/domsense-agilebg-addons/no-lpr/+merge/95849
> You are the owner of lp:~deepak-willowit/domsense-agilebg-addons/no-lpr.

[Franco Tampieri (dr.dran)]

Hi Deepak,

I believe that the proposed work in this merge is very good, however, would consider at this point, for reasons of flexibility and possibility of different configurations, also the following assumptions:

- Give the option to directly use CUPS or LPR (So who uses windows as LPR server may use base_print_to_report)

- Another important feature would be able to choose the cups server on which to lean, when you can only use the local server

What do you think you can implement these features in your patch to make it more complete?

Best Regards

Franco

[Willow IT's Code Repository Admin (code-repository)]

Hi Franco,

I certainly agree that the your second suggestion would make the module a lot more useful, but perhaps should be incorporated separately.

However, Using the CUPS API call instead of invoking LPR is guaranteed to work anywhere - even more so as the module uses the CUPS API to retrieve the list of configured printers anyway. I really don't see the advantage of using the LPR command on a system that already has CUPS installed. The LPR replacement command is only available for purposes of retaining backward compatibility so that scripts that depend on LPR already don't break on a system with a modern printing framework such as CUPS.

Regards,

Deepak

[Franco Tampieri (dr.dran)]

Hi Deepak,

"I really don't see the advantage of using the LPR command on a system that already has CUPS installed. The LPR replacement command is only available for purposes of retaining backward compatibility so that scripts that depend on LPR already don't break on a system with a modern printing framework such as CUPS."

Certainly you're right, but if OpenERP is installed on a windows server, you can not use a CUPS server to use the local printer on the server and I find illogical to create a external CUPS server to interface to the shared printers on that server.

Maintaining compatibility with the old LPR is possible to include a broader spectrum of configurations according to the most various installations.

Regards,

Franco

[lp:~deepak-willowit/domsense-agilebg-addons/no-lpr]

160. By Deepak Seshadri on 2012-05-03

[MERGE] New security added for general users.

161. By Deepak Seshadri on 2012-05-03

[MERGE] raise exception after sending report

[Franco Tampieri (dr.dran)]

Hi deepak,

we have planned to update the base_report_to_printer module, and we want test your brach on cups installation, and plus we need to insert the lrp compatibility for windows users and next we need to use the python win32 api to interface the module with a windows shared printer on windows native installation.

Tell me something if you agreee with it.

Best Regards

Franco Tampieri

[Lorenzo Battistini (elbati)]

Hello, please refer to https://launchpad.net/report-print-send project.

review: Needs Resubmitting

Unmerged revisions

161. By Deepak Seshadri on 2012-05-03

[MERGE] raise exception after sending report

160. By Deepak Seshadri on 2012-05-03

[MERGE] New security added for general users.

159. By Deepak Seshadri on 2012-03-05

[FIX] base_report_to_printer

Use the printFile function provided by the CUPS API instead of invoking
the lpr command to actually print the report.

=== modified file 'base_report_to_printer/printing.py'
--- base_report_to_printer/printing.py	2011-11-16 16:50:17 +0000
+++ base_report_to_printer/printing.py	2012-05-03 07:14:17 +0000
@@ -238,13 +238,14 @@
                 printer_system_name = printer
             else:
                 printer_system_name = printer.system_name
+
+            printer_connection = cups.Connection()
             if format == 'raw':
-                # -l is the same as -o raw
-                cmd = "lpr -l -P %s %s" % (printer_system_name,file_name)
+                printer_connection.printFile(printer_system_name, file_name, '', {'raw': ''})
             else:
-                cmd = "lpr -P %s %s" % (printer_system_name,file_name)
-            logger.notifyChannel("report", netsvc.LOG_INFO,"Printing job : '%s'" % cmd)
-            os.system(cmd)
+                printer_connection.printFile(printer_system_name, file_name, '', {})
+
+            logger.notifyChannel("report", netsvc.LOG_INFO,"Printing job: '%s' to '%s'" % (file_name, printer_system_name))
 
     _inherit = 'ir.actions.report.xml'
     _columns = {
@@ -353,6 +354,8 @@
                     and self._reports[report_id].get('format', False)):
                     report_obj.print_direct(cr, uid, base64.encodestring(self._reports[report_id]['result']),
                         self._reports[report_id]['format'], printer)
+                    cr.close()
+                    raise osv.except_osv(_('Printed !'), _("Your print job has been sent to printer '%s'." % (printer.name,)))
         cr.close()
 
         res = super(virtual_report_spool, self).exp_report_get(db, uid, report_id)

=== modified file 'base_report_to_printer/security/security.xml'
--- base_report_to_printer/security/security.xml	2011-09-26 09:48:19 +0000
+++ base_report_to_printer/security/security.xml	2012-05-03 07:14:17 +0000
@@ -48,5 +48,21 @@
                         <field eval="0" name="perm_write"/>
                         <field eval="0" name="perm_create"/>
                 </record>
+                <record id="ir_model_access_printingactionall" model="ir.model.access">
+                        <field name="model_id" ref="model_printing_action"/>
+                        <field eval="1" name="perm_read"/>
+                        <field eval="&quot;&quot;&quot;printing_action all&quot;&quot;&quot;" name="name"/>
+                        <field eval="0" name="perm_unlink"/>
+                        <field eval="0" name="perm_write"/>
+                        <field eval="0" name="perm_create"/>
+                </record>
+                <record id="ir_model_access_printingreportxmlactionall" model="ir.model.access">
+                        <field name="model_id" ref="model_printing_report_xml_action"/>
+                        <field eval="1" name="perm_read"/>
+                        <field eval="&quot;&quot;&quot;printing_report_xml_action all&quot;&quot;&quot;" name="name"/>
+                        <field eval="0" name="perm_unlink"/>
+                        <field eval="0" name="perm_write"/>
+                        <field eval="0" name="perm_create"/>
+                </record>
         </data>
 </openerp>