Merge lp:~deejay1/acire/launchpad-integration into lp:acire

[Łukasz Jernaś]

If you haven't started your rework of acire (as I can't see anything on Launchpad) you probably can merge this is.

[Jono Bacon (jonobacon)]

Thanks for the patch, deejay! I tried it but the translate menu item takes me to a non-exist Lucid source package: can you change it so it goes straight to the upstream project?

review: Needs Information

[Łukasz Jernaś (deejay1)]

Hmm, looks like there's no way to specify that for the launchpad-integration script. But I think such functionality could be added to its fromDesktopFile() function which currently isn't implemented. I will write a blueprint for it as the functionality I'm currently thinking of could be even useful for fdo...

Unmerged revisions

53. By Łukasz Jernaś on 2010-04-10

Add Launchpad integration with a small help menu reorder.
(Borrowed from PyJunior)

=== modified file 'bin/acire'
--- bin/acire	2010-03-26 19:41:43 +0000
+++ bin/acire	2010-04-10 10:40:35 +0000
@@ -34,6 +34,14 @@
     print "PyGtk ver. 2.3.90 or later required for FileChooserDialog, to save snippets."
 ###/Needed to check for GTK version
 
+# optional Launchpad integration
+# this shouldn't crash if not found as it is simply used for bug reporting
+try:
+    import LaunchpadIntegration
+    launchpad_available = True
+except:
+    launchpad_available = False
+
 
 # Check if we are working in the source tree or from the installed 
 # package and mangle the python path accordingly
@@ -85,6 +93,16 @@
         #self.preferences = dlg.get_preferences()
 
         #code for other initialization actions should be added here
+        global launchpad_available
+	if launchpad_available:
+            # see https://wiki.ubuntu.com/UbuntuDevelopment/Internationalisation/Coding for more information
+            # about LaunchpadIntegration
+            helpmenu = self.builder.get_object('helpMenu')
+            if helpmenu:
+                LaunchpadIntegration.set_sourcepackagename('acire')
+                LaunchpadIntegration.add_items(helpmenu, 1, False, True)
+            else:
+                launchpad_available = False
 
         # browser for grabbing docs titles
         self.browser = Browser()

=== modified file 'data/ui/AcireWindow.ui'
--- data/ui/AcireWindow.ui	2010-03-20 22:57:40 +0000
+++ data/ui/AcireWindow.ui	2010-04-10 10:40:35 +0000
@@ -45,18 +45,9 @@
                 <property name="label" translatable="yes">_Help</property>
                 <property name="use_underline">True</property>
                 <child type="submenu">
-                  <object class="GtkMenu" id="menu3">
+                  <object class="GtkMenu" id="helpMenu">
                     <property name="visible">True</property>
-                    <child>
-                      <object class="GtkImageMenuItem" id="imagemenuitem10">
-                        <property name="label">gtk-about</property>
-                        <property name="visible">True</property>
-                        <property name="use_underline">True</property>
-                        <property name="use_stock">True</property>
-                        <signal name="activate" handler="about"/>
-                      </object>
-                    </child>
-                    <child>
+		    <child>
                       <object class="GtkImageMenuItem" id="imagemenuitem1">
                         <property name="label" translatable="yes">Contribute Snippet...</property>
                         <property name="visible">True</property>
@@ -65,6 +56,15 @@
                         <signal name="activate" handler="contribute_snippet_info"/>
                       </object>
                     </child>
+                    <child>
+                      <object class="GtkImageMenuItem" id="imagemenuitem10">
+                        <property name="label">gtk-about</property>
+                        <property name="visible">True</property>
+                        <property name="use_underline">True</property>
+                        <property name="use_stock">True</property>
+                        <signal name="activate" handler="about"/>
+                      </object>
+                    </child>
                   </object>
                 </child>
               </object>