Merge lp:~decathorpe/capnet-assist/fix-1664680 into lp:~elementary-apps/capnet-assist/trunk
Proposed by
Fabio Valentini
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Cody Garver | ||||
| Approved revision: | 136 | ||||
| Merged at revision: | 136 | ||||
| Proposed branch: | lp:~decathorpe/capnet-assist/fix-1664680 | ||||
| Merge into: | lp:~elementary-apps/capnet-assist/trunk | ||||
| Diff against target: |
10 lines (+0/-1) 1 file modified
CMakeLists.txt (+0/-1) |
||||
| To merge this branch: | bzr merge lp:~decathorpe/capnet-assist/fix-1664680 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neal Gompa (community) | Approve | ||
| David Hewitt | code, function | Approve | |
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Commit message
cmake: don't override CFLAGS
Description of the change
This removes the broken CFLAGS override from the CMake build configuration.
To post a comment you must log in.
Revision history for this message
| David Hewitt (davidmhewitt) wrote | # |
review:
Approve
(code, function)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The -g flag is also being set in src/CMakeLists.txt anyway so we definitely shouldn't be setting -ggdb as well. Especially not in this way that overwrites other CFLAGS.