ufw

Merge ~debian-janitor/ufw:lintian-fixes into ufw:debian/master

Proposed by Debian Janitor
Status: Merged
Merged at revision: 1590779bf775de3f39bcba559c7619602f3a685b
Proposed branch: ~debian-janitor/ufw:lintian-fixes
Merge into: ufw:debian/master
Diff against target: 62 lines (+15/-3)
5 files modified
debian/changelog (+7/-0)
debian/config (+3/-1)
debian/copyright (+1/-1)
debian/upstream/metadata (+3/-0)
debian/watch (+1/-1)
Reviewer Review Type Date Requested Status
Jamie Strandboge Approve
Review via email: mp+388443@code.launchpad.net

Commit message

Fix lintian issues: Set upstream metadata fields: Repository, Repository-Browse., Update watch file format version to 4., Use secure copyright file specification URI., Use set -e rather than passing -e on the shebang-line.

Description of the change

Fix some issues reported by lintian
* Use secure copyright file specification URI. (insecure-copyright-format-uri)
* Use set -e rather than passing -e on the shebang-line. (maintainer-script-without-set-e)
* Set upstream metadata fields: Repository, Repository-Browse. (upstream-metadata-file-is-missing, upstream-metadata-missing-repository)
* Update watch file format version to 4. (older-debian-watch-file-standard)

This merge proposal was created automatically by the Janitor bot.
For more information, including instructions on how to disable
these merge proposals, see https://janitor.debian.net/lintian-fixes.

You can follow up to this merge proposal as you normally would.

The bot will automatically update the merge proposal to resolve merge conflicts
or close the merge proposal when all changes are applied through other means
(e.g. cherry-picks). Updates may take several hours to propagate.

Build and test logs for this branch can be found at
https://janitor.debian.net/lintian-fixes/pkg/ufw/e9f11848-6f2b-425f-bfda-b14132a536a2.

These changes have no impact on the binary debdiff. See
https://janitor.debian.net/api/run/e9f11848-6f2b-425f-bfda-b14132a536a2/debdiff?filter_boring=1 to
download the raw debdiff.

You can also view the diffoscope diff at
https://janitor.debian.net/api/run/e9f11848-6f2b-425f-bfda-b14132a536a2/diffoscope?filter_boring=1,
or unfiltered at https://janitor.debian.net/api/run/e9f11848-6f2b-425f-bfda-b14132a536a2/diffoscope.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

LGTM. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f708003..0353d6f 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,11 +1,18 @@
6 ufw (0.36-8) UNRELEASED; urgency=medium
7
8+ [ Jamie Strandboge ]
9 * ufw.lintian-overrides:
10 - remove init.d-script-possible-missing-stop override
11 - adjust "allow to" override
12 - override spare-manual-page for ufw-framework as it gives additional
13 details for the ufw command
14
15+ [ Debian Janitor ]
16+ * Use secure copyright file specification URI.
17+ * Use set -e rather than passing -e on the shebang-line.
18+ * Set upstream metadata fields: Repository, Repository-Browse.
19+ * Update watch file format version to 4.
20+
21 -- Jamie Strandboge <jamie@ubuntu.com> Tue, 22 Sep 2020 11:50:27 -0500
22
23 ufw (0.36-7) unstable; urgency=medium
24diff --git a/debian/config b/debian/config
25index ed17f0b..094d5bf 100644
26--- a/debian/config
27+++ b/debian/config
28@@ -1,4 +1,6 @@
29-#!/bin/sh -e
30+#!/bin/sh
31+
32+set -e
33
34 # debconf
35 . /usr/share/debconf/confmodule
36diff --git a/debian/copyright b/debian/copyright
37index 6c90a2b..b32db5d 100644
38--- a/debian/copyright
39+++ b/debian/copyright
40@@ -1,4 +1,4 @@
41-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
42+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
43 Upstream-Name: ufw
44 Upstream-Contact: Jamie Strandboge <jamie@canonical.com>
45 Upstream-Source: https://code.launchpad.net/ufw
46diff --git a/debian/upstream/metadata b/debian/upstream/metadata
47new file mode 100644
48index 0000000..a0f4fb2
49--- /dev/null
50+++ b/debian/upstream/metadata
51@@ -0,0 +1,3 @@
52+---
53+Repository: https://code.launchpad.net/ufw
54+Repository-Browse: https://code.launchpad.net/ufw
55diff --git a/debian/watch b/debian/watch
56index 9453078..e1b5fa6 100644
57--- a/debian/watch
58+++ b/debian/watch
59@@ -1,2 +1,2 @@
60-version=3
61+version=4
62 https://launchpad.net/ufw/+download/ https://launchpad.net/ufw/.*/ufw-(.*)\.tar\.gz

Subscribers

People subscribed via source and target branches