Merge ~debian-janitor/git-build-recipe:lintian-fixes into git-build-recipe:master

Proposed by Debian Janitor on 2020-05-06
Status: Merged
Merged at revision: 23284cf654a803d9f9338a503968c1f613aaebfe
Proposed branch: ~debian-janitor/git-build-recipe:lintian-fixes
Merge into: git-build-recipe:master
Diff against target: 33 lines (+3/-2)
3 files modified
debian/changelog (+2/-0)
debian/control (+1/-1)
dev/null (+0/-1)
Reviewer Review Type Date Requested Status
Colin Watson 2020-05-06 Approve on 2020-05-06
Review via email: mp+383534@code.launchpad.net

Commit message

Fix lintian issues: Bump debhelper from deprecated 9 to 12., Remove unnecessary X-Python{,3}-Version field in debian/control., Set debhelper-compat version in Build-Depends., Use secure copyright file specification URI.

Description of the change

Fix some issues reported by lintian
* Use secure copyright file specification URI. (insecure-copyright-format-uri)
* Remove unnecessary X-Python{,3}-Version field in debian/control. (ancient-python-version-field)
* Bump debhelper from deprecated 9 to 12. (package-uses-deprecated-debhelper-compat-version)
* Set debhelper-compat version in Build-Depends. (uses-debhelper-compat-file)

This merge proposal was created automatically by the Janitor bot.
For more information, including instructions on how to disable
these merge proposals, see https://janitor.debian.net/lintian-fixes.

You can follow up to this merge proposal as you normally would.

Build and test logs for this branch can be found at
https://janitor.debian.net/lintian-fixes/pkg/git-build-recipe/23653ad9-aa07-43fb-80c3-b259a1680dac.

These changes have no impact on the binary debdiff. See
https://janitor.debian.net/api/run/23653ad9-aa07-43fb-80c3-b259a1680dac/debdiff?filter_boring=1 to
download the raw debdiff.

You can also view the diffoscope diff at
https://janitor.debian.net/api/run/23653ad9-aa07-43fb-80c3-b259a1680dac/diffoscope?filter_boring=1,
or unfiltered at https://janitor.debian.net/api/run/23653ad9-aa07-43fb-80c3-b259a1680dac/diffoscope.

To post a comment you must log in.
Colin Watson (cjwatson) :
review: Approve
Colin Watson (cjwatson) wrote :

Actually, this is a problem and I'll need to partially revert it (probably tomorrow). See my comments in https://code.launchpad.net/~debian-janitor/git-build-recipe/+git/git-build-recipe/+merge/376594. In that MP you said that you were adding an override for git-build-recipe to use --compat-release; did that override somehow get lost?

Jelmer Vernooij (jelmer) wrote :

On Wed, May 06, 2020 at 09:26:00PM -0000, Colin Watson wrote:
> Actually, this is a problem and I'll need to partially revert it (probably tomorrow). See my comments in https://code.launchpad.net/~debian-janitor/git-build-recipe/+git/git-build-recipe/+merge/376594. In that MP you said that you were adding an override for git-build-recipe to use --compat-release; did that override somehow get lost?
Sorry, I think I forgot to actually put it in. It's just gone in - https://salsa.debian.org/jelmer/debian-janitor/-/commit/864d89262bf3afb41c54522bcc2c70f27f0ecd3d. I'll trigger a rerun.

Jelmer

--
Jelmer Vernooń≥ <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc

Colin Watson (cjwatson) wrote :

Thanks. I've reverted this merge, since xenial only has debhelper 9 and no debhelper-compat.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 674b14e..ae18455 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -2,6 +2,8 @@ git-build-recipe (0.3.7) UNRELEASED; urgency=medium
6
7 * Use secure copyright file specification URI.
8 * Remove unnecessary X-Python{,3}-Version field in debian/control.
9+ * Bump debhelper from deprecated 9 to 12.
10+ * Set debhelper-compat version in Build-Depends.
11
12 -- Debian Janitor <janitor@jelmer.uk> Fri, 20 Dec 2019 13:47:13 +0000
13
14diff --git a/debian/compat b/debian/compat
15deleted file mode 100644
16index ec63514..0000000
17--- a/debian/compat
18+++ /dev/null
19@@ -1 +0,0 @@
20-9
21diff --git a/debian/control b/debian/control
22index aeb453f..fc1882d 100644
23--- a/debian/control
24+++ b/debian/control
25@@ -3,7 +3,7 @@ Section: vcs
26 Priority: optional
27 Maintainer: Colin Watson <cjwatson@ubuntu.com>
28 Standards-Version: 3.9.7
29-Build-Depends: debhelper (>= 9), dh-python, python3 (>= 3.1.2-8~), python3-setuptools, python3-dateutil, python3-debian, python3-testtools, python3-fixtures, python3-nose, devscripts, git, pristine-tar, quilt
30+Build-Depends: debhelper-compat (= 12), dh-python, python3 (>= 3.1.2-8~), python3-setuptools, python3-dateutil, python3-debian, python3-testtools, python3-fixtures, python3-nose, devscripts, git, pristine-tar, quilt
31 Homepage: https://launchpad.net/git-build-recipe
32 Vcs-Git: https://git.launchpad.net/git-build-recipe
33 Vcs-Browser: https://git.launchpad.net/git-build-recipe

Subscribers

People subscribed via source and target branches