Merge lp:~debfx/messagingmenu-extension/lp817598 into lp:messagingmenu-extension

Proposed by Felix Geyer
Status: Merged
Merged at revision: 69
Proposed branch: lp:~debfx/messagingmenu-extension/lp817598
Merge into: lp:messagingmenu-extension
Diff against target: 49 lines (+12/-8)
2 files modified
modules/LibUnity.jsm (+6/-4)
modules/MessagingMenu.jsm (+6/-4)
To merge this branch: bzr merge lp:~debfx/messagingmenu-extension/lp817598
Reviewer Review Type Date Requested Status
Mike Conley Pending
Review via email: mp+74489@code.launchpad.net

Description of the change

Make the messaging menu work when libunity isn't installed.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/LibUnity.jsm'
2--- modules/LibUnity.jsm 2011-09-06 13:54:17 +0000
3+++ modules/LibUnity.jsm 2011-09-07 18:01:23 +0000
4@@ -54,12 +54,11 @@
5 try {
6 libunity = ctypes.open("libunity.so.5");
7 } catch(e) {
8- libunity = ctypes.open("libunity.so.4");
9+ try {
10+ libunity = ctypes.open("libunity.so.4");
11+ } catch(e) {}
12 }
13
14- if (!libunity)
15- throw "libunity is unavailable";
16-
17 return libunity;
18 });
19
20@@ -240,6 +239,9 @@
21 },
22
23 isAvailable: function LUP_isAvailable() {
24+ if (!libunity)
25+ return false;
26+
27 var ret = false;
28 try {
29 var inspector = unity_inspector_get_default();
30
31=== modified file 'modules/MessagingMenu.jsm'
32--- modules/MessagingMenu.jsm 2011-09-05 17:48:06 +0000
33+++ modules/MessagingMenu.jsm 2011-09-07 18:01:23 +0000
34@@ -685,10 +685,12 @@
35 set badgeCount(aCount) {
36 LOG("Setting total new count to " + aCount.toString());
37 this._badgeCount = aCount;
38- if (aCount > 0) {
39- LibUnity.setCount(aCount);
40- } else {
41- LibUnity.setCount(null);
42+ if (LibUnity.isAvailable()) {
43+ if (aCount > 0) {
44+ LibUnity.setCount(aCount);
45+ } else {
46+ LibUnity.setCount(null);
47+ }
48 }
49 },
50

Subscribers

People subscribed via source and target branches

to all changes: