Merge lp:~debfx/firefox/firefox-trunk.head.kde into lp:firefox/trunk

Proposed by Felix Geyer
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~debfx/firefox/firefox-trunk.head.kde
Merge into: lp:firefox/trunk
Diff against target: 25 lines (+1/-7)
1 file modified
debian/patches/mozilla-kde.patch (+1/-7)
To merge this branch: bzr merge lp:~debfx/firefox/firefox-trunk.head.kde
Reviewer Review Type Date Requested Status
Mozilla Team Pending
Review via email: mp+83920@code.launchpad.net

Description of the change

Fix LP: #885836 - can't save files in KDE

I know that the patch is disabled in the trunk branch but I want to make sure that the bugfix doesn't regress again.

To post a comment you must log in.

Unmerged revisions

1059. By Felix Geyer

Fix LP: #885836 - can't save files in KDE

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/mozilla-kde.patch'
2--- debian/patches/mozilla-kde.patch 2011-10-19 11:07:16 +0000
3+++ debian/patches/mozilla-kde.patch 2011-11-30 11:22:33 +0000
4@@ -206,7 +206,7 @@
5 ===================================================================
6 --- /dev/null 1970-01-01 00:00:00.000000000 +0000
7 +++ mozilla/toolkit/xre/nsKDEUtils.cpp 2011-10-19 12:03:37.379620517 +0100
8-@@ -0,0 +1,334 @@
9+@@ -0,0 +1,328 @@
10 +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
11 +/* ***** BEGIN LICENSE BLOCK *****
12 + * Version: MPL 1.1/GPL 2.0/LGPL 2.1
13@@ -407,12 +407,6 @@
14 + {
15 + if( !startHelper())
16 + return false;
17-+ // if Gtk has meanwhile gotten a grab (bnc#555202, somehow the file dialog
18-+ // is called with a delay), then do not do anything, as this app would keep
19-+ // the grabs but block waiting for the helper, which would be unable to do
20-+ // anything because of the grab
21-+ if( blockUi && gdk_pointer_is_grabbed())
22-+ return false;
23 + feedCommand( command );
24 + // do not store the data in 'this' but in extra structure, just in case there
25 + // is reentrancy (can there be? the event loop is re-entered)

Subscribers

People subscribed via source and target branches