Merge lp:~death-7/wicd/wicd into lp:wicd
Proposed by
Deathzor
on 2014-07-07
Status: | Rejected |
---|---|
Rejected by: | Tom Van Braeckel on 2014-12-11 |
Proposed branch: | lp:~death-7/wicd/wicd |
Merge into: | lp:wicd |
Diff against target: |
32 lines (+12/-3) 1 file modified
wicd/wnettools.py (+12/-3) |
To merge this branch: | bzr merge lp:~death-7/wicd/wicd |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Van Braeckel (community) | 2014-07-07 | Needs Fixing on 2014-12-11 | |
Review via email:
|
Description of the change
Minor bug fix ( affecting gentoo dhclient users )
To post a comment you must log in.
lp:~death-7/wicd/wicd
updated
on 2014-07-07
I added some inline notes about what, in my opinion, needs fixing.
I'm a bit skeptical about the "hacky" nature of the changes, so it would be great if you could elaborate on that a bit, about why dhclient reads from STDIN on Gentoo... I am using it as well and I don't notice any problems, so why is Gentoo's dhclient different?
Please improve, thanks a lot in advance, and we'll merge it!