Merge ~deadlight/maas:filter-selected-cross into ~deadlight/maas:vanilla

Proposed by Karl Williams
Status: Merged
Merged at revision: 814ecadb2e5e1dcda1a6ac6bb8e65e874939838e
Proposed branch: ~deadlight/maas:filter-selected-cross
Merge into: ~deadlight/maas:vanilla
Diff against target: 23 lines (+7/-1)
1 file modified
src/maasserver/static/scss/_maas.scss (+7/-1)
Reviewer Review Type Date Requested Status
Anthony Dillon (community) Approve
Karl Williams Pending
Review via email: mp+337574@code.launchpad.net

Description of the change

Added crosses to selected node filters

QA:
 - Go to 'nodes'
 - Select some filters
 - See that they now have a cross when selected

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM Checked on FF and Chrome

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/scss/_maas.scss b/src/maasserver/static/scss/_maas.scss
2index 6b4358d..c6d8dc1 100644
3--- a/src/maasserver/static/scss/_maas.scss
4+++ b/src/maasserver/static/scss/_maas.scss
5@@ -244,11 +244,17 @@
6 .col-12 {
7 width: 100%;
8 }
9-
10+
11 // Can be removed when the settings section is updated
12 .errorlist {
13 list-style: none;
14 display: inline-block;
15 margin-left: 0;
16 }
17+
18+ // Sidebar selected state
19+ .sidebar__second-level .is-active {
20+ background: transparent url('../assets/images/89c10794-remove.svg') top $sp-small right $sp-large no-repeat;
21+ background-size: 12px;
22+ }
23 }

Subscribers

People subscribed via source and target branches

to all changes: