Merge lp:~deadlight/canonical-identity-provider/password-reset into lp:~deadlight/canonical-identity-provider/vanilla
Status: | Merged |
---|---|
Approved by: | Karl Williams |
Approved revision: | 1696 |
Merged at revision: | 1696 |
Proposed branch: | lp:~deadlight/canonical-identity-provider/password-reset |
Merge into: | lp:~deadlight/canonical-identity-provider/vanilla |
Prerequisite: | lp:~deadlight/canonical-identity-provider/faq |
Diff against target: |
264 lines (+93/-80) 4 files modified
src/webui/templates/bad_token.html (+19/-11) src/webui/templates/registration/email_sent.html (+31/-34) src/webui/templates/registration/forgot_password.html (+27/-21) src/webui/templates/registration/reset_password.html (+16/-14) |
To merge this branch: | bzr merge lp:~deadlight/canonical-identity-provider/password-reset |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Anthony Dillon (community) | Approve | ||
Karl Williams | Pending | ||
Review via email: mp+370763@code.launchpad.net |
Description of the change
Updated the password reset flow to Vanilla Framework
----
QA:
- setup your environment as per the README
- source ./env/bin/activate
- make mail-debug
[NEW TERMINAL]
- source ./env/bin/activate
- make start-db
- make run
- go to [HOST]:8000
- Create a new user
- Logout
- Click "forgot password" under the login form
- Check the page styling
- Enter the email address for the created user and submit the form
- Check the styling of the second step
- Check the other terminal terminal to see the email that would be sent and copy the link provided
- Check the styling of the form and submit
- You can check the styling for the error where the link from the email is invalid buy visiting: [HOST]:
Unfortunately cannot yet QA due to local env setup issues
Have eyeballed the code and raised some issues inline.