Merge lp:~deadlight/canonical-identity-provider/language into lp:~deadlight/canonical-identity-provider/vanilla

Proposed by Karl Williams
Status: Merged
Merge reported by: Karl Williams
Merged at revision: not available
Proposed branch: lp:~deadlight/canonical-identity-provider/language
Merge into: lp:~deadlight/canonical-identity-provider/vanilla
Prerequisite: lp:~deadlight/canonical-identity-provider/ssh-keys
Diff against target: 119 lines (+37/-56)
1 file modified
src/webui/templates/select_language.html (+37/-56)
To merge this branch: bzr merge lp:~deadlight/canonical-identity-provider/language
Reviewer Review Type Date Requested Status
Anthony Dillon (community) Approve
Karl Williams Pending
Review via email: mp+371657@code.launchpad.net

Description of the change

Converted the language selection page to Vanilla

QA:
- npm i
- ./node_modules/gulp/bin/gulp.js sass
- source env/bin/activate
- make start-db
- make run
- Visit http://[CONTAINER IP]:8000/set_language

To post a comment you must log in.
1712. By Karl Williams

Styled selct language page with Vnailla Framework

Revision history for this message
Karl Williams (deadlight) wrote :

QA'd in person

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Two small suggestions

review: Needs Fixing
1713. By Karl Williams

Fix button style and add external link class

Revision history for this message
Karl Williams (deadlight) wrote :

Fixed issues raised in comments

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webui/templates/select_language.html'
2--- src/webui/templates/select_language.html 2014-12-09 21:41:56 +0000
3+++ src/webui/templates/select_language.html 2019-08-23 13:39:12 +0000
4@@ -1,78 +1,59 @@
5-{% extends "base.html" %}
6+{% extends "vanilla/base.html" %}
7 {% load i18n %}
8
9 {% comment %}
10-Copyright 2010 Canonical Ltd. This software is licensed under the
11+Copyright 2010-2019 Canonical Ltd. This software is licensed under the
12 GNU Affero General Public License version 3 (see the file LICENSE).
13 {% endcomment %}
14
15 {% block title %}
16- {% trans "Choose your language" %}
17+ {% trans "Choose your language" %}
18 {% endblock %}
19
20 {% block text_title %}
21- <h1 class="u1-h-main">{% trans "Choose your language" %}</h1>
22+ <h1>{% trans "Choose your language" %}</h1>
23 {% endblock %}
24
25 {% block bodyclass %}set-language{% endblock %}
26 {% block menu %}{% endblock %}
27
28 {% block extra_css %}
29-<style type="text/css">
30+ <style type="text/css">
31 .set-language footer .language {
32- display: none;
33+ display: none;
34 }
35-</style>
36+ </style>
37 {% endblock %}
38
39+{% block content_class %}{% endblock %}
40+
41 {% block content %}
42-
43-<div class="yui3-g-r">
44-
45- <div class="yui3-u-1-2 language-select">
46-
47- <form action="" method="post">
48-
49- {% csrf_token %}
50- <input type="hidden" name="next" value="{{next}}">
51-
52- {% for lang in supported_languages %}
53- <p>
54- <input id="lang-{{lang.0}}" type="radio" name="language"
55- {% if LANGUAGE_CODE == lang.0 %}checked="checked"{% endif %}
56- value="{{lang.0}}">
57-
58- <label for="lang-{{lang.0}}">
59- {{lang.1}}
60- </label>
61- </p>
62- {% endfor %}
63-
64- <button type="submit" name="submit" data-qa-id="choose_language" class="btn cta">
65- {% trans "Choose language" %}
66- </button>
67- </form>
68-
69- </div>
70-
71- <div class="yui3-u-1-3 cannot-find-language">
72-
73- <div class="box">
74-
75- <div class="title">
76- <h3>{% trans "Can't find your language?" %}</h3>
77- </div>
78-
79- <div class="body">
80-
81- <p>{% blocktrans %}We welcome volunteers to help us translate this site to new languages. If you are able to help, please visit our <a href="https://translations.launchpad.net/canonical-identity-provider">translations site</a> to get started.{% endblocktrans %}
82- </p>
83-
84- </div>
85-
86- </div>
87-
88- </div>
89-
90-</div>
91+ <div class="row">
92+ <div class="col-8">
93+ <form action="" method="post">
94+ {% csrf_token %}
95+ <input type="hidden" name="next" value="{{next}}">
96+ <ul class="p-list is-split">
97+ {% for lang in supported_languages %}
98+ <li class="p-list__item">
99+ <input id="lang-{{lang.0}}" type="radio" name="language" {% if LANGUAGE_CODE == lang.0 %}checked="checked"{% endif %} value="{{lang.0}}">
100+ <label for="lang-{{lang.0}}">
101+ {{lang.1}}
102+ </label>
103+ </li>
104+ {% endfor %}
105+ </ul>
106+ <button type="submit" name="submit" data-qa-id="choose_language" class="p-button--positive">
107+ {% trans "Choose language" %}
108+ </button>
109+ </form>
110+ </div>
111+ <div class="col-4">
112+ <div class="p-card">
113+ <h3>{% trans "Can't find your language?" %}</h3>
114+ <p>{% blocktrans %}We welcome volunteers to help us translate this site to new languages. If you are able to help, please visit our <a class="p-link--external" href="https://translations.launchpad.net/canonical-identity-provider">translations site</a> to get started.{% endblocktrans %}
115+ </p>
116+ </div>
117+ </div>
118+ </div>
119 {% endblock %}

Subscribers

People subscribed via source and target branches

to all changes: