Merge lp:~deadlight/canonical-identity-provider/applications into lp:~deadlight/canonical-identity-provider/vanilla
Proposed by
Karl Williams
Status: | Merged |
---|---|
Approved by: | Karl Williams |
Approved revision: | 1709 |
Merged at revision: | 1709 |
Proposed branch: | lp:~deadlight/canonical-identity-provider/applications |
Merge into: | lp:~deadlight/canonical-identity-provider/vanilla |
Prerequisite: | lp:~deadlight/canonical-identity-provider/devices-list |
Diff against target: |
91 lines (+40/-33) 1 file modified
src/webui/templates/account/applications.html (+40/-33) |
To merge this branch: | bzr merge lp:~deadlight/canonical-identity-provider/applications |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Anthony Dillon (community) | Approve | ||
Barry McGee | Pending | ||
Review via email: mp+371462@code.launchpad.net |
Description of the change
Converted the /+applications page to Vanilla Framework
QA:
- npm i
- ./node_
- source env/bin/activate
- make start-db
- make run
- Visit http://[CONTAINER IP]:8000/ in your browser
- Create an account using the form
- Go to http://[CONTAINER IP]:8000/
Note: I'm not sure how to test adding applications in development but you can hack the template file (applications.html) to display a dummy table by stripping out the tests and missing variables.
To post a comment you must log in.
QA looks good but would be nice to overflow the tables. I believe they will require a wrapping div with some styles.