Merge lp:~dduffey/maas/wedge-1.9 into lp:maas/1.9

[David Duffey]

Added Facebook Wedge OpenBMC power driver support

[Blake Rouse (blake-rouse)]

Thanks for working on this. Many things need to be addressed in this branch. I have included many inline comments, but the real blockers are below.

1. We almost always land in trunk and then backport. So you need to have this working on MAAS trunk first. There is a big different between 1.9 and trunk now, and that is trunk is python 3 only. YOu need to make sure this works with MAAS trunk and on Xenial and then do the backport. That needs to be QA'd on both 1.9 and trunk. We cannot help you with the QA process as we do not have access to this hardware.

2. No unit tests have been provided with this branch. It is a requirement that any branch that lands in MAAS contain unit tests. This power driver will be something people will come to rely on working, adding unit tests will ensure that it does not get broken as other features, fixes, and more power drivers are added to MAAS.

review: Needs Fixing

[David Duffey (dduffey)]

Hi Blake, thanks for reviewing this. I have updated this to trunk / python 3 and tested with MAAS 2.0 and a Facebook 40 and a Facebook 100. Facebook is going to have an event in January where they would like to highlight MAAS, so I'm going to try and get through these. I've put comments below where need some guidance.

I'll ask Luke Williams to write the unit tests (a bit beyond my abilities), if you have some particularly 'good' one we should try and follow.

Unmerged revisions

4540. By David Duffey on 2016-02-08

Added Facebook Wedge OpenBMC Power Driver

=== modified file 'src/provisioningserver/drivers/power/__init__.py'
--- src/provisioningserver/drivers/power/__init__.py	2015-11-17 19:49:40 +0000
+++ src/provisioningserver/drivers/power/__init__.py	2016-02-08 17:27:30 +0000
@@ -322,6 +322,7 @@
 from provisioningserver.drivers.power.amt import AMTPowerDriver
 from provisioningserver.drivers.power.apc import APCPowerDriver
 from provisioningserver.drivers.power.dli import DLIPowerDriver
+from provisioningserver.drivers.power.wedge import WedgePowerDriver
 from provisioningserver.drivers.power.ether_wake import EtherWakePowerDriver
 from provisioningserver.drivers.power.fence_cdu import FenceCDUPowerDriver
 from provisioningserver.drivers.power.hmc import HMCPowerDriver
@@ -337,6 +338,7 @@
 registered_power_drivers = [
     APCPowerDriver(),
     DLIPowerDriver(),
+    WedgePowerDriver(),
     HMCPowerDriver(),
     IPMIPowerDriver(),
     MicrosoftOCSPowerDriver(),

=== added file 'src/provisioningserver/drivers/power/wedge.py'
--- src/provisioningserver/drivers/power/wedge.py	1970-01-01 00:00:00 +0000
+++ src/provisioningserver/drivers/power/wedge.py	2016-02-08 17:27:30 +0000
@@ -0,0 +1,81 @@
+# Copyright 2015 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Wedge Power Driver."""
+
+from __future__ import (
+    absolute_import,
+    print_function,
+    unicode_literals,
+    )
+
+str = None
+
+__metaclass__ = type
+__all__ = []
+
+from provisioningserver.drivers.power import (
+    PowerDriver,
+    PowerError,
+    PowerFatalError,
+)
+
+from paramiko import (
+    AutoAddPolicy,
+    SSHClient,
+    SSHException,
+)
+
+def extract_wedge_parameters(context):
+    ip = context.get('power_address')
+    username = context.get('power_user')
+    password = context.get('power_pass')
+    return ip, username, password
+
+class WedgePowerDriver(PowerDriver):
+    name = 'wedge'
+    description = "Facebook Wedge OpenBmc Power Driver."
+    settings = []
+
+    def detect_missing_packages(self):
+        # uses pure-python paramiko ssh client - nothing to look for!
+        return []
+
+    def _run_ssh_command(self, ip, username, password, command):
+        """Run a single command and return unparsed text from stdout."""
+        self._ssh = SSHClient()
+        self._ssh.set_missing_host_key_policy(AutoAddPolicy())
+        self._ssh.connect(ip, username=username, password=password)
+        try:
+            _, stdout, _ = self._ssh.exec_command(command)
+            output = stdout.read()
+        finally:
+            self._ssh.close()
+
+        return output
+
+    def power_on(self, system_id, context):
+        """Power on Wedge."""
+        ip, username, password = (extract_wedge_parameters(context))
+        power_state = self._run_ssh_command(ip, username, password, "/usr/local/bin/wedge_power.sh on")
+
+    def power_off(self, system_id, context):
+        """Power off Wedge."""
+        ip, username, password = (extract_wedge_parameters(context))
+        power_state = self._run_ssh_command(ip, username, password, "/usr/local/bin/wedge_power.sh off")
+
+    def power_query(self, system_id, context):
+        """Power query Wedge."""
+        ip, username, password = (extract_wedge_parameters(context))
+        power_state = self._run_ssh_command(ip, username, password, "/usr/local/bin/wedge_power.sh status")
+        return power_state.split("Microserver power is ")[1].split('\n')[0]
+
+
+# The following is just for debugging purposes
+def main():
+    wedge = WedgePowerDriver()
+    power_state = wedge._run_ssh_command("192.168.10.32", "root", "0penBmc", "/usr/local/bin/wedge_power.sh status")
+    print(power_state.split("Microserver power is ")[1].split('\n')[0])
+
+if __name__ == "__main__":
+    main()

=== modified file 'src/provisioningserver/power/__init__.py'
--- src/provisioningserver/power/__init__.py	2015-12-04 20:57:06 +0000
+++ src/provisioningserver/power/__init__.py	2016-02-08 17:27:30 +0000
@@ -32,6 +32,7 @@
     'amt',
     'hmc',
     'ipmi',
+    'wedge',
     'mscm',
     'msftocs',
     'sm15k',

=== modified file 'src/provisioningserver/power/schema.py'
--- src/provisioningserver/power/schema.py	2015-11-02 16:53:04 +0000
+++ src/provisioningserver/power/schema.py	2016-02-08 17:27:30 +0000
@@ -271,6 +271,16 @@
         ],
     },
     {
+        'name': 'wedge',
+        'description': 'Facebook Wedge OpenBMC',
+        'fields': [
+            make_json_field('power_address', "OpenBMC IP Address"),
+            make_json_field('power_user', "OpenBMC username"),
+            make_json_field(
+                'power_pass', "OpenBMC password", field_type='password'),
+        ],
+    },
+    {
         'name': 'ucsm',
         'description': "Cisco UCS Manager",
         'fields': [