Code review comment for lp:~ddormer/kali/kali-update

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

You probably want itertools.product, not itertools.combinations; something like this:

self.ids = itertools.product(*[string.ascii_uppercase] * 6)

It's a little ugly because the signature of itertools.product is stupid, but I think that should do the trick. Otherwise, I think this looks good.

review: Needs Fixing

« Back to merge proposal